From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AF4934107A for ; Thu, 19 Feb 2026 14:48:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771512534; cv=none; b=np3ilHoVDDa2uCHmIZj0X+C8feokGEdCDK8JCPimr51S8f3nkJB8MdWS31HAuoXNgZrth2yFHBnYE+f97uVAihtPnHcnYcDVuz+kNi2W1YDEPTfJ4+LbNx9n4QpYPVQYp+TVSkMvzin16pYrz5/wBAB+3UN8EKnSlGJHENvpwjo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771512534; c=relaxed/simple; bh=WPmhXugb1c1vgwttHqeNFzRAWMC2sPpK/CO3Rxgm6MM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dWQCluDDNckiZ00vpfCeTnk0tD3/vnkq7q0gnEjiwSq+j9hiE1iljpsDLmgFPoIO6OnFVwmfuhKQVvMWZLzi+Iv3VvKWf94V9lo6/wAhWd8QCxgHDObrjz3x+Z9kKgtAELA+9qpQ/Pe2OhDup9bqGkS1h9D+dii3EpKFhd5KgOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name; spf=pass smtp.mailfrom=chrisdown.name; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b=l5pdEYVB; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="l5pdEYVB" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-354bc7c2c46so657222a91.0 for ; Thu, 19 Feb 2026 06:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; t=1771512532; x=1772117332; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=RIxeJm6i4/A2str+yjAuZbdYnAKk+uBxuRi2OKTMMf4=; b=l5pdEYVBnvnSJCd4DdY0Ojm2u4LgmU1ZSM3IlB2PZh0lFdpSRJLYFwtBcMXDmuw7R4 yO0GVLnWnO9dbckcahKRtGsCSvQQJOIMM10Uj6KLCIZyvOeo0ZGCj7swdtBdzjKJTHc4 8haC9sy2RTch/yvcyLZmEtkvQiFuPwcj47u+U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771512532; x=1772117332; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RIxeJm6i4/A2str+yjAuZbdYnAKk+uBxuRi2OKTMMf4=; b=b9nMS9KNHRVgEf0GrGXNkmz28K/qv9Ft+yTOia19wHl96dqMIcRBEm4+Q9tsSCqMnx U6akrb8tmb3L8Z56icRk077tA1yWZXv5sFmGt7GgDnOzyJWqIaP0stXprdH5GFSl/sv8 ZDQmSTlgQL6v/Pky+OSqgCMYGOoocsIqyDXEaSN6OLEbc3JVl3Gu4kfthaoKINvbFnnc G+z6GFkMQmVqUZkRsMLcU6U287a2xkRxfF9b7CLgjF6WIPxCM04WWFBS70AWPRYFhgS0 2pPDBS+QQYpi2GbND0dNlSHIHp35ax7OlijQBcJN7ZDrAXMdMgqGSci7m83JtiL69xLP z2+w== X-Forwarded-Encrypted: i=1; AJvYcCUTYy5b7KLRqBw0zDdhsCSHkH5hf2aiaa/dCj0OYVGm3hx4K6hgqfWWepT7GVX3cpAOeefj5AGs9/2U/0U=@vger.kernel.org X-Gm-Message-State: AOJu0YwSGEDjGgTtL16RQag6odEv9mpxl2GfUGGAXWzPAVT7yI+aRFbG ez9Jlu7NcZPDoI1/6FeWhOmVM80ZrQYb337bL0gkxPBhEctZ5SmNObd/1ql8WhHfrxc= X-Gm-Gg: AZuq6aKBAZac/b7/Xm1NERsag3qtTlj/SN9iJT638SCtgXFKCJdpczU2fhtHMRstAWu mE2EbGVhEkfTDf4+nbAPwYMEdsvld306sh0z3kDyFcdrqXT/90xdSIEVKgf54bqOBZtxgDYrvK2 cFau8UgYpJvPwfdRcrKAOF9yiPn/x8Q2udzfPwAg9KCVeBLydqkeH8ti94rum8jdNq79ZTcuyW0 81Jkpbd81VtfrDt9P1UQtrGK47B7xSOL/HZ+1tHo/X9B0lfro5B0KNjCRq64NxVTP3UpgZG3COv 4nlVel/vuA9tUCVW+QgUQY+1vG/mTPrmbbfgMeBchjxDxI9qpNxtg1no6JsrgDuQtYu+vu1Ygoh 0T0gRbR5E9r/10bQxLS3eefPm8dVAU0sJH/9VcCF5Ck3bC1+Nf1dZW+MvjDJJmuSKX7lx4m+rrR po6PUiSIfjMRI+ceNR7HLv X-Received: by 2002:a17:90b:528d:b0:356:2313:33b6 with SMTP id 98e67ed59e1d1-356aad9f3b9mr17144310a91.29.1771512531945; Thu, 19 Feb 2026 06:48:51 -0800 (PST) Received: from localhost ([175.139.248.66]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35895141ec6sm1521335a91.2.2026.02.19.06.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 06:48:51 -0800 (PST) Date: Thu, 19 Feb 2026 22:48:49 +0800 From: Chris Down To: Petr Mladek Cc: John Ogness , Sergey Senozhatsky , Steven Rostedt , Marcos Paulo de Souza , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/8] printk: Separate code for adding/updating preferred console metadata Message-ID: References: <20260206165002.496724-1-pmladek@suse.com> <20260206165002.496724-4-pmladek@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260206165002.496724-4-pmladek@suse.com> User-Agent: Mutt/2.2.15 (2b349c5e) (2025-10-02) Petr Mladek writes: >@@ -2531,28 +2587,14 @@ static int __add_preferred_console(const char *name, const short idx, > for (i = 0, pc = preferred_consoles; > i < MAX_PREFERRED_CONSOLES && (pc->name[0] || pc->devname[0]); > i++, pc++) { >- if ((name && strcmp(pc->name, name) == 0 && pc->index == idx) || >- (devname && strcmp(pc->devname, devname) == 0)) { >- if (!brl_options) >- preferred_dev_console = i; >- set_user_specified(pc, user_specified); >- return 0; >- } So, in this old code when __add_preferred_console() finds an existing matching entry, it returns immediately without touching the options at all. But in the new patch the loop breaks out and falls through to update_preferred_console(), which only conditionally updates options. This has different behaviour. For example if you imagine SPCR/DT setting the options, before they win out against the command line, but now they do not. This may well be intended, since the user cmdline probably should win over the platform defaults anyway. I'd argue that sounds like the right behaviour anyway. But I don't see this change being mentioned as intentional in the changelog. Is it? If it is, let's mention it there. With this clarified: Acked-by: Chris Down