From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F605340A57 for ; Thu, 19 Feb 2026 14:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771512592; cv=none; b=iZq2MLCyBIM7R7RrSp6L6vqT53JL7mO+5LJAp5a4fdmZObSF5ZtHzZqAmufHz974ad5tHob/U09zpBFaYUnYL6vOdrbnceEz6evDIeUZgauq0A4+gjeA3/YsliWum8bFrqlwyXIqGVoQnIWY6IqKoFI+2MBOxnK3JJL8BseY/Lw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771512592; c=relaxed/simple; bh=WOsEvJECxDcnFyatli1Lw1CXWGrV80hTUwC3vlGoK/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AGv7iD91GIbJ+NufxBOVEL7T/dD3/Svk/Bis4BCGTMUTFw7TTbQ4efPwnFtIVzBobOKUNItWKo6juALN5CR3fQOSVYqLfoDFA46piUgmEIZRR3SJe+rdjF5swAJzp0gzHa/HrO2RPoxgEb4lAmvhd6B79oPwKVbbcuXWKHpH+lk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name; spf=pass smtp.mailfrom=chrisdown.name; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b=uYIdve3w; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="uYIdve3w" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a8a7269547so9698235ad.0 for ; Thu, 19 Feb 2026 06:49:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; t=1771512591; x=1772117391; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WOsEvJECxDcnFyatli1Lw1CXWGrV80hTUwC3vlGoK/8=; b=uYIdve3wvAXFeYYLfxsv5DbBn27PwAeZkW/3pteiEwo4PfjnhTb0LLwuBV0zmjHh/Z FDyEHU+6qYln+rkWiXCZKpZKXqoUH0RWxF7/JbmGYeXOUNQf7B7Ey+e1BUMpwmtKKVSb cedTzFuKXKkvHva03TgNZxVAIIQBHWeeEIFik= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771512591; x=1772117391; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WOsEvJECxDcnFyatli1Lw1CXWGrV80hTUwC3vlGoK/8=; b=DqY5fo1h2HsUYjh1qMhwWqrU7iK/QpD9lqSn3m/r4gDOncMvMldE0f+GBp2xpcHeud 3lRf436+fssdYFJP7eXtYRQXy6ZI1JlfOdUhvssYIkGZkLqflAkP2KOjgYmk25ryARiu rYN7b/IW/cb4JJdzYccsmslE+jZ/7/rZjKqNmlMX+zwtVpODt12vUeix/Ft/pi633sQK K+ZhD6qB6LteA1hMjkXvbX2PtCHwuWUo6zOi3SaG7hVceHmfd9rzbjUERXjMImX1TdYe EOO6L80OtZ8nWCH7K0O3zI8Eydx754Url6ODozz7h2u+PQewz7sxBYX/D20K/VWY/uUc 62lw== X-Forwarded-Encrypted: i=1; AJvYcCVz3igNtDOYzqERz4WdbOMkY5c9sU9pATDgwM2h7jVCrY6/dykTkTSMhbpm4eFpA6j+Nt2fa5nMfkB0H80=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3zGDMyXzbfgfjaO4zv3Bk9wdT14462RjZMqqfp4t7jewJ8Ow9 4zz2JY2O1gXNUYb+hunB32WxrPwTCs7MJpCklmldK1FwFLMLsNnB0FxfStg1mM9T4WKxCgZlKQh RmN4osZLWY5qG X-Gm-Gg: AZuq6aLOcgMh4SGaIhP3F0D/ZK8Wv6/grZwgr33xFa00Lg+O2/e7skspBksPOM6oyOB 7KxF2YBjzAP3okATwSVGSc7CJg6Rr3y2C/DEm1/786OVSXWoVP5fHtoRiyJZ2z+BMts/B5swEP+ vX8FAOoBXhfJiwEm7EbeLIN66FaeXDbDXbIt4X55I9smGFGY1IPfyTx7nR4thXFpSAXwDooyVgJ Cbx5KozvLw5JefUidwss9nnoTD0gWp2WZtM+LJj3reM93T7u9tVO2EmpO+eEIuSTWVcJszFqYLL z/KMxQ1ARtGboIReZRlGjgqioWZmbkOGE++/dg9R6U8L92xh5Rr9p9+a1R+C1JSeokubuZc/Sln iCBiSB8YnxbiRkz8b2QZIL6+XFPzlOamSD+UiTF0jW56EaxAN326JnDedj77V9pfcDvwEOikPFT KI7FDb/86TqIjmpodTLwLWVbm+fcdFMNQ= X-Received: by 2002:a17:902:d546:b0:2a9:327f:aa31 with SMTP id d9443c01a7336-2ab4cfa4f33mr201422805ad.21.1771512590688; Thu, 19 Feb 2026 06:49:50 -0800 (PST) Received: from localhost ([175.139.248.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1aaeb759sm153372475ad.83.2026.02.19.06.49.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 06:49:50 -0800 (PST) Date: Thu, 19 Feb 2026 22:49:48 +0800 From: Chris Down To: Petr Mladek Cc: John Ogness , Sergey Senozhatsky , Steven Rostedt , Marcos Paulo de Souza , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] printk: Cleanup _braille_(un)register_console() wrappers Message-ID: References: <20260206165002.496724-1-pmladek@suse.com> <20260206165002.496724-5-pmladek@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260206165002.496724-5-pmladek@suse.com> User-Agent: Mutt/2.2.15 (2b349c5e) (2025-10-02) Petr Mladek writes: >The _braille_(un)register_console() wrappers currently attempt to hide >implementation details like the CON_BRL flag and pc->brl_options. This >forces callers to handle an unconventional tri-state return value (0 for >NOP, >0 for success, <0 for error), which makes the control flow harder >to follow and non-standard. > >Refactor the wrappers to use standard kernel return codes (0 for success, >-ERRCODE on failure). Move the responsibility of checking brl_options >to the caller to make the logic more explicit. > >Additionally, move the assignment of the CON_BRL flag from the internal >wrapper to braille_register_console(). This aligns it with how >CON_ENABLED is handled. To maintain symmetry and fix a potential bug >where flags might persist after removal, explicitly clear both >CON_ENABLED and CON_BRL in braille_unregister_console(). > >Signed-off-by: Petr Mladek Nice, looks good. Thanks! Acked-by: Chris Down