From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: bhargav <rougueprince47@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] iio: frequency: ad9523: fix implicit variable usage in macros
Date: Thu, 19 Feb 2026 22:36:59 +0200 [thread overview]
Message-ID: <aZd0a0mgtBWp5EgX@smile.fi.intel.com> (raw)
In-Reply-To: <20260219203215.15566-2-rougueprince47@gmail.com>
On Fri, Feb 20, 2026 at 02:02:13AM +0530, bhargav wrote:
> macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and
> AD9523_CLK_DIST_DIV_REV(x) implicitly relied on variable
> named 'ret' instead of using passed argument 'x'.
>
> Update the macros to explicitly
> use the argument 'x' for their operations.
>
> This also resolves the following checkpatch.pl warning:
> WARNING: Argument 'x' is not used in function-like macro
...
> #define AD9523_CLK_DIST_DIV_PHASE(x) (((x) & 0x3F) << 18)
> -#define AD9523_CLK_DIST_DIV_PHASE_REV(x) ((ret >> 18) & 0x3F)
> +#define AD9523_CLK_DIST_DIV_PHASE_REV(x) ((x >> 18) & 0x3F)
See above, this should be '(x)' and not 'x'.
...
> #define AD9523_CLK_DIST_DIV(x) ((((x) - 1) & 0x3FF) << 8)
> -#define AD9523_CLK_DIST_DIV_REV(x) (((ret >> 8) & 0x3FF) + 1)
> +#define AD9523_CLK_DIST_DIV_REV(x) (((x >> 8) & 0x3FF) + 1)
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-19 20:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 1:02 [PATCH] iio:frequency:ad9523:convert symbolic permissions to octal and remove unwanted arguments in macro bhargav
2026-02-19 7:44 ` Andy Shevchenko
2026-02-19 20:32 ` [PATCH v2 0/3] iio: frequency: ad9523: fix checkpatch warnings bhargav
2026-02-19 20:32 ` [PATCH v2 1/3] iio: frequency: ad9523: fix implicit variable usage in macros bhargav
2026-02-19 20:36 ` Andy Shevchenko [this message]
2026-02-19 20:32 ` [PATCH v2 2/3] iio: frequency: ad9523: avoid multiple line dereferences for pdata bhargav
2026-02-19 20:38 ` Andy Shevchenko
2026-02-19 20:32 ` [PATCH v2 3/3] iio: frequency: ad9523: fix checkpatch warnings for symbolic permissions bhargav
2026-02-19 20:46 ` Andy Shevchenko
2026-02-19 21:35 ` [PATCH v3 0/3] iio: frequency: ad9523: fix checkpatch warnings bhargav
2026-02-19 21:35 ` [PATCH v3 1/3] iio: frequency: ad9523: fix implicit variable usage in macros bhargav
2026-02-20 7:21 ` Andy Shevchenko
2026-02-19 21:35 ` [PATCH v3 2/3] iio: frequency: ad9523: avoid multiple line dereferences for pdata bhargav
2026-02-19 21:35 ` [PATCH v3 3/3] iio: frequency: ad9523: fix checkpatch warnings for symbolic permissions bhargav
2026-02-20 7:24 ` Andy Shevchenko
2026-02-20 7:22 ` [PATCH v3 0/3] iio: frequency: ad9523: fix checkpatch warnings Andy Shevchenko
2026-02-22 13:50 ` Jonathan Cameron
2026-02-22 13:58 ` Jonathan Cameron
2026-02-22 21:19 ` Rogue prince
2026-02-23 8:35 ` Andy Shevchenko
2026-02-23 20:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZd0a0mgtBWp5EgX@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rougueprince47@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome