From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26023239E88 for ; Fri, 20 Feb 2026 05:23:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771565039; cv=none; b=iRnGCUTpqOZdz5qm9r4C/M6J0nkDibAmc7RI6OCbDpr0pRSA+qtx2QdUIpPpvHraJm4eCCf1n8aZTQ2j5o4FyiTtC4yCr57PNegZr8ylKN6tlpfOcZWrw8fu6quQvuCaU8Qt0o2NkOcx7DWPosSbgK1tzJfrLpkPJr0xDCu+ozs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771565039; c=relaxed/simple; bh=UHd4B3J7HEupzmWVv7GzRXngOGVQEy+4OCQQYYWfbl8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d9iNpju2DgEYgKAee2Te8rm4GbJu8g8FMI/cI0IWzfpxm7qf1ZE95TsZ1zy81BAtUS7ceyLNcF4p+uwTWeEuO6Gh1Ej9abF2ghXV22IZa7pjmeT+Lj2Y9eIQx0Ds9zehklx296PTOot1da5KQp+qWz5hA9/9fkdFGu9fdCFamcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=NxyRk/52; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="NxyRk/52" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-8cb3b3e643dso110792985a.2 for ; Thu, 19 Feb 2026 21:23:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1771565036; x=1772169836; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W3KruqnMh9Yui6pRs3kQeBNIY15XR1zawggAIpyZqDw=; b=NxyRk/52bsWJ0Jazv0Gp6xB9qLLNJtUMG8Xl4X5K29LUSoVjI1nM3lbkGtvVaxX7BD PRaJdWDpH0XbhUf1ObD05jT4I/8yNtZBOMdr6OzKYxiBjgrRC/wO/ue0Zkn1WK+2+B2L Ct7DgWShFmlIVvL+QYZ3/csgBCyVLcsuSyDzAelIi2jpuv7E04FHqeLBJfZn53CvAYFf 1kurdrd9huDOyXNqkM7RhRN5Irkl1UFdZPoW+doqr16XFKQUEo7uQ5eq/TyqMmIObYT5 2frCeFhZqyxOK0Fpzx3bg6KgojNj6fQDi1oouzPWVb+VgcydcKUs0QyWk2bdK2Rt303w 18iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771565036; x=1772169836; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W3KruqnMh9Yui6pRs3kQeBNIY15XR1zawggAIpyZqDw=; b=r5LOIvXi5eZ10q+IPXlkGCkscLF+zB96EZRaWs/w7fYEk6VY87iZNIOjyCIG9EjBdh b5sqeT7e8MA+d2Tz6s4BB2VbPKnG7ukb8p7fBFOKEdn/cXhoGFwizb0Hy8sSdBQl7vcp 2dhg76ai2SPyxQ1Qkv+EgB5n49hhg0G613c6JCG0BZrNGTzVIOK2/2J9tQBHBoei2cUp /svz4XMtIr302PXeY/pKoAqTg17bQAd8jEM7NKKP28w3byXAA6vomhk9/CNVktijaEEp iLAtDlF+N7qs31ZZcmTtG3btJwum0HzocJdjnlVmKkFzDzIrGoFG4pzkFuMV/SI8m7mK RiKw== X-Forwarded-Encrypted: i=1; AJvYcCVBZyGKBJJ3LlVXzNLQrmqBoxBvnUoSxDT2/Myq00duvswMhRiYxymOtn7fwZD7c/8bGAa4x+noYBDY8KA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5kSKiCw4VL3zZvVy7CEHbJmXHldy8uaigJ9CdqBOczjAwF9z7 +KSZ+ah6BJkK8SDtYI+ub9sBwlX/0JXniA8i3XQvLhfYFPUtx6ba6Q2JspRUEotFti4= X-Gm-Gg: AZuq6aLPjmS/6gJzOfkbhx5SjE04pOExsf1Y2vrAMKo4+vBrn6DLL6yvlVI43BRuAPN F2iBNCVGwRRyK2USjpdY6cnrpKACOY51d3jCSk0ja3pWMpL9sBoEuUqHA0Z9fvp4uF9Gf+FM8xD zcyg/GOPkQPYpeDlXOSUKCRnJ70NHlSDCqM8Mx+w3zSj3KzlllQ2fOgE8xiiGxrINb2yCE3LjKX 0qPBBw639cAv4jlT+Ma4p5dUYFheqAUrfU8CthUZXQlN9ipcV+lgBqXf4RLOK0aJQatAnN5Mnmj CtCqj962zOkvCrylJL3DlDZaOZwufG12OQ4DHH+xe0KPqdVxLUDWiY5UdcHRWH/9FBR90C0k1Zp CuYPA6XSEUu++foBSJDp8Tugj7IWeYr9ETPPA4isTagC3iGSn8tJAx6Nz5bRq7dNJpoORCuuIO3 W8GIv6g8eNKBc2CXeDilGPlHUZipE5FKhLVVEoQGvfieoQBx6wuKLkQalOIFF0kwsSIDMjaJJGS 0EJAD3EOQ== X-Received: by 2002:a05:620a:2996:b0:8c7:a84:d0e4 with SMTP id af79cd13be357-8cb740324d6mr936535985a.24.1771565036560; Thu, 19 Feb 2026 21:23:56 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8971cdb5dbfsm266965576d6.41.2026.02.19.21.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 21:23:56 -0800 (PST) Date: Fri, 20 Feb 2026 00:23:54 -0500 From: Gregory Price To: Dave Jiang Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave@stgolabs.net, jonathan.cameron@huawei.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com Subject: Re: [PATCH v3 3/3] cxl/core: use cleanup.h for devm_cxl_add_dax_region Message-ID: References: <20260211204206.2171525-1-gourry@gourry.net> <20260211204206.2171525-4-gourry@gourry.net> <68d44fc4-55fe-42df-85ea-cffc60454325@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68d44fc4-55fe-42df-85ea-cffc60454325@intel.com> On Tue, Feb 17, 2026 at 04:55:13PM -0700, Dave Jiang wrote: > > > On 2/11/26 1:42 PM, Gregory Price wrote: > > Cleanup the gotos in the function. > > > > No functional change intended. > > > > Signed-off-by: Gregory Price > > --- > > drivers/cxl/core/region_dax.c | 21 ++++++++------------- > > drivers/cxl/cxl.h | 1 + > > 2 files changed, 9 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/cxl/core/region_dax.c b/drivers/cxl/core/region_dax.c > > index c8dd2bd1d9b9..49907c6c7620 100644 > > --- a/drivers/cxl/core/region_dax.c > > +++ b/drivers/cxl/core/region_dax.c > > @@ -81,29 +81,24 @@ static void cxlr_dax_unregister(void *_cxlr_dax) > > > > int devm_cxl_add_dax_region(struct cxl_region *cxlr) > > { > > - struct cxl_dax_region *cxlr_dax; > > - struct device *dev; > > + struct cxl_dax_region *cxlr_dax __free(put_cxl_dax_region) = NULL; > > int rc; > > > > cxlr_dax = cxl_dax_region_alloc(cxlr); > > The typical __cleanup() pattern is to move the variable declaration here in order to minimize unintended issues between declare and check. > Ah, relatively new pattern for me, i'll clean it up > > if (IS_ERR(cxlr_dax)) > > return PTR_ERR(cxlr_dax); > > > > - dev = &cxlr_dax->dev; > > Given that this local var is used multiple times, maybe we should keep it? > Fair, will re-spin claned up ~Gregory