mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	driver-core@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/2] driver core: provide device_match_fwnode_ext()
Date: Fri, 20 Feb 2026 09:27:37 +0200	[thread overview]
Message-ID: <aZgM6ZaBrwM6H1_i@smile.fi.intel.com> (raw)
In-Reply-To: <aZeu11bBxxgXNMyd@google.com>

On Thu, Feb 19, 2026 at 04:47:59PM -0800, Dmitry Torokhov wrote:
> On Thu, Feb 19, 2026 at 03:15:53PM -0600, Bartosz Golaszewski wrote:
> > On Thu, 19 Feb 2026 17:54:24 +0100, Dmitry Torokhov
> > <dmitry.torokhov@gmail.com> said:
> > > On Thu, Feb 19, 2026 at 05:39:47PM +0100, Bartosz Golaszewski wrote:

...

> > > I think it really needs a good explanation given how it goes through
> > > secondaries on one side but not on the other (but maybe it should? Why
> > > one would not want to match secondary?)
> > >
> > 
> > I don't think it should. You have one, concrete fwnode and you want to match
> > it against a struct device: in this variant both its primary and secondary
> > nodes. I don't think we should do a four-way matching.
> 
> I wonder why you consider these 2 distinct fwnodes instead of a single
> object that has multiple components? After all in device we have a
> pointer to fwnode, and not list of fwnodes....

For the matter of fact the struct fwnode_handle is a single-linked list with
a limitation to have up to two entries. And the second one is a problematic
design as these years showed.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-02-20  7:27 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 16:31 [PATCH 0/2] driver core: provide and use device_match_fwnode_ext() Bartosz Golaszewski
2026-02-19 16:31 ` [PATCH 1/2] driver core: provide device_match_fwnode_ext() Bartosz Golaszewski
2026-02-19 16:36   ` Greg Kroah-Hartman
2026-02-19 16:39     ` Bartosz Golaszewski
2026-02-19 16:50       ` Greg Kroah-Hartman
2026-02-19 16:54       ` Dmitry Torokhov
2026-02-19 21:15         ` Bartosz Golaszewski
2026-02-20  0:47           ` Dmitry Torokhov
2026-02-20  7:27             ` Andy Shevchenko [this message]
2026-02-20 11:06             ` Bartosz Golaszewski
2026-02-19 16:55       ` Danilo Krummrich
2026-02-19 19:27         ` Andy Shevchenko
2026-02-19 21:18           ` Bartosz Golaszewski
2026-02-20  0:21             ` Danilo Krummrich
2026-02-20  7:42             ` Andy Shevchenko
2026-02-20 11:21               ` Bartosz Golaszewski
2026-02-19 21:16         ` Bartosz Golaszewski
2026-02-19 19:58   ` Andy Shevchenko
2026-02-19 21:21     ` Bartosz Golaszewski
2026-02-20  7:36       ` Andy Shevchenko
2026-02-20 11:25         ` Bartosz Golaszewski
2026-02-20 12:08           ` Rafael J. Wysocki
2026-02-20 14:35             ` Bartosz Golaszewski
2026-02-20 14:49               ` Andy Shevchenko
2026-02-20 14:55               ` Rafael J. Wysocki
2026-02-20 15:43             ` Danilo Krummrich
2026-02-20 16:03               ` Rafael J. Wysocki
2026-02-19 16:31 ` [PATCH 2/2] gpiolib: use device_match_fwnode_ext() Bartosz Golaszewski
2026-02-19 17:32 ` [PATCH 0/2] driver core: provide and " Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZgM6ZaBrwM6H1_i@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=brgl@kernel.org \
    --cc=dakr@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=driver-core@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome