From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26232335543 for ; Fri, 20 Feb 2026 08:03:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771574638; cv=none; b=aIciyREcIf8Qk1RG5wFeki4MM6Q0GXjFZMfuaEzW4rnEwyQfdmrm0D4E+PpnAirqTCFa5kJ8vUHlO4gpbvrOaZvNg5Wf8fPJzMU3IUoiUVQ25at+eFgficPpzeTprTXhfPMK4qUibQk5Y+AsKmSBgaPs+L/9IDXaYxPVqaa6dTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771574638; c=relaxed/simple; bh=WCpY8DamAm/k+L3M/EaCHKxmn5LryL5yTFHZ4s/JLXY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NCjo1MZ0f1oi/6Uug1KfgpDwkZw6XAf91QTbHyTO1aahfo+wXophwEaed90M19GV8m88UVs6Q0OwVK2+OwjspYndNYtdjG5FeB1sLIhb+QZHslRzxL80ldBUmyVfNPUpV3QCWnJ4CQw17JOV40CdNU6cHo+rpjHU2+78kE5gn/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DqKQR97q; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DqKQR97q" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-436e8758b91so1324499f8f.0 for ; Fri, 20 Feb 2026 00:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771574634; x=1772179434; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1eHENbQgxiG8g4Iw6sBHR/5X6KByktzSsOmA3jGT73U=; b=DqKQR97q/u1bxOjH5XrKnjCX2k4FnGh3lQPGdeF/IspCRrgMV3vvsufZ1DmpLGWxTQ DYm6yq4QrMFpevZ9N5/Nml9PnlgXJt6bxqVR0lx7fiCbkNlnlkAFLaizY8k5iA3syPNa /gz/N7IQb8HvTG6ZkDO/q9tWD85Q11NmvdqglnKjqYqHwgwYCELUfnI78SkJsk3wzUOn bkepg9omLAGQOImREueBfDeckxz2knRoRNyaKAZ7DaRNPK4VmqZhfK6xhCKKMu7ELcEf FU5aX07sDHY8IEvh0wGbblQVwQZbOMROr0gOri4bHJswhR3eVTqDwoc7ucHu0R9NaN6t +EdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771574634; x=1772179434; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1eHENbQgxiG8g4Iw6sBHR/5X6KByktzSsOmA3jGT73U=; b=HZPu2KjE9e7kub1RmkQGQ9EEumA6ykRKk1n8xhb3prX3JjKti4xgqGWhyanfVEwCay 7Sren6PgrDvBpKFVi4QWpsDMLPqGSd/J+Zkr62dHR3CfOFdLLNLZO6ItjqPeSV2EJtyC D+CrfWZRK976fCRKRbKjYJJua5wWCgaCg5RDOsQLWQUCRqW8EE7J+Dxdqd+XCQsGuGta YPzgWVm2hLREOmnRwboYv0gVErsJ91cYd9HGomPDzK5ba6QWnDASOlthkZcE1eL3bqal x+PHMKiChELpSilRvB/EfV0VWsyAPb9huz6yrlJDoYMmBFbdlM2VG+ItJyolimFSZ06C 9oFQ== X-Forwarded-Encrypted: i=1; AJvYcCXQZ4rsHO/lEle3bWZPrSS3/9gafnn/HAQW1Z2aMznJwB1WafKiwNHIITJNFiw/qXj6JW3dO4mqzUkVLwU=@vger.kernel.org X-Gm-Message-State: AOJu0YxnmyQhYSKWrGVs6Vmuv60afZ5r1liL1ze9QLi1pHYo/SqdMYrc G67oAC4wxleiAY7Gq/cJcSkEXUIW8apKUMyM6SfwYj+qwlbo0Reg3w12VUdClH9pkW0= X-Gm-Gg: AZuq6aLhao/aGhjqfen7QPz9Vdv5gn7l2VDBE7p5wbsTAQ+ZJuWfaeR16RIj9o9q4PA FTrnuEausVFzLPCXQQeEdm5wPsDSu8oPFUsJtlYjV57M6Qq/mvmAV7rWbgxq1w39wiUnh/6vstO UyDGRQT78tMRZ58WbqsrxQirryHOtrapN80WzBLlmKIWbxyapmi3dPJZx/5RbqqJIwLMOUBWVcS z62uK1X5t5XKXAmBcTxmjFtNpNDyc2LVgMCbiTHeRE+azNq2VguxutbTJ3p8Zt/K+c4IqvG4rT1 PyuFJKrieAzEdo1y5zQWyQL3r6akXgItWDqOj7azhAtG6WpbmU1ho8dKnpoDYSWqx1wO0+7yvAa Lyu7EFd7WMwloc47vt/rUqVf6nugtolVST1nP6YkkkxOD0EAOuIaHch488keJKQ4IKOD8Jv8MdN tLjm9sDZ4LT++pxk5DGQe9NGbXKJFl X-Received: by 2002:a05:6000:438a:b0:437:6aca:d1cc with SMTP id ffacd0b85a97d-4379db372f1mr36014949f8f.23.1771574634151; Fri, 20 Feb 2026 00:03:54 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ac8075sm51473944f8f.29.2026.02.20.00.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 00:03:53 -0800 (PST) Date: Fri, 20 Feb 2026 11:03:50 +0300 From: Dan Carpenter To: Hardik Phalet Cc: linux-staging@lists.linux.dev, vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] staging: greybus: audio: fix NULL dereference in gb_audio_manager_get_module() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Feb 20, 2026 at 05:44:19AM +0000, Hardik Phalet wrote: > Empty Message > From 3b496a0daa8cbbbe50a7a09e6daf7bb4d8e6e9e5 Mon Sep 17 00:00:00 2001 > From: Hardik Phalet > Date: Fri, 20 Feb 2026 10:41:49 +0530 > Subject: [PATCH v1 1/2] staging: greybus: audio: fix NULL dereference in > gb_audio_manager_get_module() > > gb_audio_manager_get_module() calls gb_audio_manager_get_locked(), which > can return NULL when the requested id does not exist. The returned > pointer is dereferenced unconditionally via kobject_get(), leading to a > NULL pointer dereference. > > Only take a kobject reference when the module is found. > > Signed-off-by: Hardik Phalet > --- > drivers/staging/greybus/audio_manager.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c > index 27ca5f796c5f..1da8804e61ca 100644 > --- a/drivers/staging/greybus/audio_manager.c > +++ b/drivers/staging/greybus/audio_manager.c > @@ -111,7 +111,8 @@ struct gb_audio_manager_module *gb_audio_manager_get_module(int id) I don't think the gb_audio_manager_get_module() function is ever called. Otherwise probably this would need a Fixes tag. regards, dan carpenter