From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BB182FFDF4 for ; Fri, 20 Feb 2026 08:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771574917; cv=none; b=SBAIaO1B8LFEqjyIJVIbuvCH7mrRMG6zkPxOR2e/4G3Oj2TNVEZAo66xEIiUY4GDEz2ghfTC2TTRd+Qdc5XithAWjw7DGGUbO4bMK/VOdvstdQHc/hfLoY/2XzEFUqg5w8XDXVtMjgRp+E1CFKoAJX6a0ZkLbm3naLQz4yPGpYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771574917; c=relaxed/simple; bh=xUjfoouKyYB3IsvJO8ZYZ9AbvYHgrq10uRETmPCEXfs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c5SYgnlfBoH9qHJARw2/cDKgVMmx/ZBZEvooaZL9Q0EemwLl0aJa23rpTGhVxdiHiWqanPkWvW0VgmLnZ3IBoadFHUhfLlDEmWaKDYyGpvimo4Cb2KN0kV7O5bsEwLPrkAdOM5Z2pmeSs1RypAbjkz905/bv1ydejwBCBCzR8U4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JEZyEt8Z; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JEZyEt8Z" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4833115090dso16664835e9.3 for ; Fri, 20 Feb 2026 00:08:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771574914; x=1772179714; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PW5/Tx2f7vm6B1RaJRWVO1XGu49Vd/tH4yy2gBO2bc0=; b=JEZyEt8ZEibLbaQoWWcTKOr5KKjTNsBGqoR3mWCZKQwRX67bir3HRsgNgttqHg5Ykm 0hAJqo+8epP63DvlY2PXM+G0qDdpYgPXggP82OS7/+rkwe8sAhUvOszrd7tPpIsD9DY2 BvLKY6eeRs1gyrLHe+XvPEtzUa0sG965g88A6pBnq/W5ds7V9T2mg+AP6Ag2U1IYCw2P g9+KmIRDDJopzVzDVHNXrka/yOaU7QNINGI/SsXzPDxIymjRwR9DHYP3aHiX56XbJ44r UX3C9j6dIB2FW0tfaP9OKbvL2KNlEjyGMArYdCaVK4JLyOCyQa5agI14xASF3oJ9oWdP 2ZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771574914; x=1772179714; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PW5/Tx2f7vm6B1RaJRWVO1XGu49Vd/tH4yy2gBO2bc0=; b=LrJ01h5wt+91eSncnsA0bAPZM4Nm8d04kLH1c5aNxQZu2vAPtbCtjblwh259y70ZkV RUj0fYUBug/FFd1bNjNb9pTOFrFzSJyJLa9kvSA2j9M3ER187aSX2GIZJLgK0h2G8kJo CUF9QhzDoJ6VFhe1T6llcjWA0qhnOkyJ6QIhPs+1iV/D58761bC5rhHvuvOnyDdisOJe L4ick845hFUdWx8KBR9nxlXIokFdLpN0QyxGf2hNUY/2fQFYq28EfTP4+iyc/PziddpP UcCeoLg6ldHYaajsnBL71MNZzOA7FY06ghAB6I4IjwncJFkVALvI4aFQNaIFMfCMKPi6 JBvg== X-Forwarded-Encrypted: i=1; AJvYcCVgXB5tZGNVymelQz1Y6AUCUmoCvNFpLRy6FwJt5Vi5zDtaiYCvF033zsQudbnPsg88TnyX1vn9nc0Gmag=@vger.kernel.org X-Gm-Message-State: AOJu0YxNku3+1gkGd7FJyKdK+3Z2ds/hlDtvIbrD4WjN3iQTbPzbjcbm F+uIfDLFayE/SwINCwsGbW2LfvjEETQKgmwwahyp7LvjidhNpSg+1G30SLA8po7HRSQ= X-Gm-Gg: AZuq6aLQsCH1EVKHF9uuvMK+bk/Go71ZeOLwsgKLzbahuSy+asvKV0FVYzIoFAty/S7 uhhiEIF+4DK3efMvPEGz3gaLM/K+5e5Dlk39Kl9ro8RtVwuco7Jr8VPq8ZqeFz4KbuVZVmj8GnX dv/q2P0gYtyiv73UhaOLTNSYOhLDcfm4Z+++FEIvWoIvCjBY3zRRHYYk9QMmkkMi7kqhZ8H3pu8 52C1MfsoG2cYqYAy6TdT2GFFZXQSyTOMXlKt220ujlzxHpnb4Nfy6VhoJaDLVynU+oyOrHccVEv 2sswy+kycmOD5Xw2tsNXgnUDHJmRqOADCGsyEVGDS1G6AmfsykdriOjGP2DCh1SUoHXYAtO8NTK 3qt5kTKdnkHj1MkqcrmmpMXSWUnEcOQFtFwBk9I1nd0UU02Rhbkg1o5phBJ7X+oMJSrucfq0oG8 TinR2buJIyJ1tSFGMCWbphv0njd6Ze X-Received: by 2002:a05:600c:1c20:b0:480:7162:fa48 with SMTP id 5b1f17b1804b1-48398a549ccmr139543985e9.13.1771574913565; Fri, 20 Feb 2026 00:08:33 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a31c048bsm59429125e9.7.2026.02.20.00.08.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 00:08:33 -0800 (PST) Date: Fri, 20 Feb 2026 11:08:29 +0300 From: Dan Carpenter To: Hardik Phalet Cc: Johan Hovold , Alex Elder , Greg Kroah-Hartman , Vaibhav Agarwal , Mark Greer , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: greybus: audio: fix NULL dereference in gb_audio_manager_get_module() Message-ID: References: <20260220062741.399677-1-hardik.phalet@pm.me> <20260220062741.399677-2-hardik.phalet@pm.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260220062741.399677-2-hardik.phalet@pm.me> On Fri, Feb 20, 2026 at 06:30:10AM +0000, Hardik Phalet wrote: > gb_audio_manager_get_module() calls gb_audio_manager_get_locked(), which > can return NULL when the requested id does not exist. The returned > pointer is dereferenced unconditionally via kobject_get(), leading to a > NULL pointer dereference. > > Only take a kobject reference when the module is found. > > Signed-off-by: Hardik Phalet > --- > drivers/staging/greybus/audio_manager.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c > index 27ca5f796c5f..1da8804e61ca 100644 > --- a/drivers/staging/greybus/audio_manager.c > +++ b/drivers/staging/greybus/audio_manager.c > @@ -111,7 +111,8 @@ struct gb_audio_manager_module *gb_audio_manager_get_module(int id) I don't think this gb_audio_manager_get_module() function is ever called. If it is then we need a Fixes tag. regards, dan carpenter