From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E939C311940 for ; Fri, 20 Feb 2026 09:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771579356; cv=none; b=Upm0uTaoh3YCOGQ2aCD4ePkcqEGcRytReCmnXCyn9KjjLaohlvkU6oustJyLbPSNVCQf41woinTiIJcifj8oGg2NnWGtaTwAXn4+L/KNBf9njvwVlo/il2c6Ty0iBubDMHth6bzKTN+943zcPt6rwSSd1lw1m+FjreC0X8GHHVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771579356; c=relaxed/simple; bh=cbH0jdHmo2DcpQSbLZTn2saaw2S9yA80pf3VFhqCKdc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uQfX7sY51FOFg81cgSHLb2wZTJ6SxKIMPL7UgiUj8BOQu/2pdxEo1uMkDZzjKW6fn5YG1faIqybNc1cfZZpif6FdkqTygmyGug+QDX6iMeUgwu1HEKi/2yHaauyw36T6UK8RD7NaKVZXXwtma/B/vum5yTs40I6bGtBFqivpsdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KJqGkoD+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KGQrVIW8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KJqGkoD+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KGQrVIW8" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61K5RpSk2552574 for ; Fri, 20 Feb 2026 09:22:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fcsW1LF/JcPb806BA6vk9bWg/mVbQYnz26kHqfxsAS0=; b=KJqGkoD+X8OIYIic O6Qp/lY5uSsUpLQKovlfWs+VruGEkhqVmqrAC8q7hTCbmKHB4XXFJIGPEjm1xaF0 AtuYRU64N5DDtjxErQUEBvsZdaSgS3dKR/nISHwqGc55TtNVEvLay77ruq7BqPeI /X0yKShf36dd5VjoFOy3NNnHR20/Apc1MLUpwK0PnbbQecJ3Y5XXfmj5U44T/ViU ijatTQbNwprKDJSYn1spzXoob1XCbj4gtwPh5tZ70TFCZM1I6/kLA1pvj29mU+42 tAjcEuYpxlwn6oHPWOrI3hrAnpDUfY+ikdLG3C/r6NajMHj2I4og3T67v+/3TUCD FEPwvw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ceh7t0jej-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 20 Feb 2026 09:22:34 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3588daf06b2so957254a91.0 for ; Fri, 20 Feb 2026 01:22:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771579354; x=1772184154; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=fcsW1LF/JcPb806BA6vk9bWg/mVbQYnz26kHqfxsAS0=; b=KGQrVIW868AK0QMZjiMDC76q7MVksE0bl+r9L4XmOviAEFHvz0C6LB8z6+b85Z1mb7 PEJN/c+PzjCSyTYEmq+uPPIGEaAnnT9Bc69m6uEkmvR7pZJd2TyWMmWg+kNAuEy+fFh5 EG4Jekk4lrUSS1MavRafix+g7bgSZ4KKCXNl+/vAnj56LiTQbpCfjXXhSCPz2g1jJc8M GPbhXfqFyvzZBlt9XuCHm/pRY2sZSY3qi38aOBUbRiLTlzcLhWdXVEHg2CdWG2W48GVk X9cEh/ZuvG9brdv/NsYFlU1E6ryqjh8nlJsBDeEFalBrvQ3+o14gGXnI423wklgkIKbk bLiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771579354; x=1772184154; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fcsW1LF/JcPb806BA6vk9bWg/mVbQYnz26kHqfxsAS0=; b=j07q9iBERl0bElm2KxXp1Xt5c8FQK0zWaCN4TAX+BeHQC3qetLuuW6BLAy341ojiIC XK0owXfRIRBlCfQwQqA2rb+F7SxRkfjUc4YabqtvgPDkNmQm2lhY+5Y+TBbRIKc5ol+d FgPCDTYBXnhP/eod/Vpc/Yu1MvCrZXDrP7mO6qfh/T3o8OiCjHQSgAAOU4yeuvMUeSSp P046d4Cf/2n9JFjNWCYovKRfZiUbHPudUMjt+3Khj36PlgWat+HNXNicNCo1IJKr+Caa LvR1WvMQnDFx9E9dXFLXiN9ECZWOm2JMwOgJt9ydsxBgv0pNd4K/S6s7OUBL7C+81HFG Vi4Q== X-Forwarded-Encrypted: i=1; AJvYcCX0Kyw2p/CexLivJZalJYpcGg83quZ+VRPuKvjITVF9eUCaFVaMfidRN/sRpMLdP/B4gARkyCBAgHrHGh8=@vger.kernel.org X-Gm-Message-State: AOJu0YyayfYB1mxgCUummSrdJbFJ/a+HYv9zmT21xuNvJ85OmfX2sVh6 jWMQiPvkYRWGT7ZqCM97YdU4HUa8FItMtqtzjPhBbmFGyzxF5k349WWXs5QN8k4WvLJX3LSywFG zpz5ZR3Ed3GzcY8DivVSL4piEh09XPtAEP9aLMoQ03NA9+3KUJXUgNnQ+collAVVxZKY= X-Gm-Gg: AZuq6aJXx1nK6hY8zzmp2Lay1D5qDglsnczTSEM1FyMqxXHYQ2tHb/eVOrRE1yA4/mE mSv1SViXawucSPVBOqNo/a1OUIG8q/RH/NBdWq1jQHS/W3EkmgxE7DzeFuCbD2Mg+rfInGr1wIa jTfvNmau0As7S3kJpsnxJx+ml/2SUvPq2HNkTxGmOqSUB+JEWNHPGITAJyiYFI0nid3XDdWxB9D wMkTzlBh9di5SpJl2BEi3uvBtQjJhZAfdJ6PHa8MtVlpYYvlLPYZ+tsK+uaatR6yvD/fsJuoYbF agwVt6AKaSi49uOODishJzMee7dbToV495NapYFjED6J27RVXqn72/BESwN3SwRASKVGxrndBCH lIVHtmDWmKgQUj1UIoSrNrAM5a3Jbx28wFlpXE6cie84nB5TN8avToMrrQywwNMTKdPG31Oelwl yW3ho3iso/eZNn4bl+X5llt1DAPemf/kCW6GHEubO1IQ== X-Received: by 2002:a17:90b:50d0:b0:354:7b96:1304 with SMTP id 98e67ed59e1d1-356a6e3dcacmr15691179a91.0.1771579354217; Fri, 20 Feb 2026 01:22:34 -0800 (PST) X-Received: by 2002:a17:90b:50d0:b0:354:7b96:1304 with SMTP id 98e67ed59e1d1-356a6e3dcacmr15691156a91.0.1771579353789; Fri, 20 Feb 2026 01:22:33 -0800 (PST) Received: from hu-vishsain-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3589d811aeasm3253607a91.6.2026.02.20.01.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 01:22:33 -0800 (PST) Date: Fri, 20 Feb 2026 14:52:25 +0530 From: Vishnu Saini To: Markus Elfring Cc: Prahlad Valluru , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Andrzej Hajda , Conor Dooley , David Airlie , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Rob Herring , Robert Foss , Simona Vetter , syyang@lontium.com, Thomas Zimmermann , Prahlad Valluru , LKML Subject: Re: [PATCH v3 2/2] drm/bridge: add support for lontium lt8713sx bridge driver Message-ID: References: <20251228-lt8713sx-bridge-driver-v3-2-9169fbef0e5b@oss.qualcomm.com> <91290a53-8f59-4138-9899-4523d25e1cff@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <91290a53-8f59-4138-9899-4523d25e1cff@web.de> X-Proofpoint-GUID: K4qSsB5I5HdzDnRq5m75nDRHRveuEuZZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIwMDA4MCBTYWx0ZWRfX2vV8eEucgj3b jPR8Dja8hlxyZdJ/WZdT16pwzm/qQwaae2K3BWqIgWO+9GB5Z1C0uE/7UFBGUxrHpbqIHc7cSxU y7cNJYdLtZ7Jx4PHRobQ79Qikk4ROsWjxCrbPs+fxOHuXJFYgrWBmeEVGd5X627E3a/FuJ9L2yo MWVGU2yYMr4hquakrQZBfZix9AySJWGnbiGYukui9JkUSIFVKDeEyZiPUKs0fOOFuONRDaUwtWj x90do1Lfl2Cp/wfq/St9pX8I9jXx5PfmE/rm7ppoFeRFhKS8VMuAQxzsX8b50S3RB1uHI8UdRY8 /SjZeLRkdfnGdzoaxyArYM8zbCyrpS6lAwFLFLINimrcm79sn4JgHA4aFVJmnwGPKiRlTTbMU7Q q3cM2fRSIdwQDNRJrhdd7IqQiwilYhAatIGKgKrUooQViZ2306l7yWL+ND4EQCwX+fLLecOz038 /tuSexrdrVnk1qiiYsg== X-Authority-Analysis: v=2.4 cv=PcTyRyhd c=1 sm=1 tr=0 ts=699827da cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=P-IC7800AAAA:8 a=my0msLyqr9YCKrkcl6IA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: K4qSsB5I5HdzDnRq5m75nDRHRveuEuZZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-20_01,2026-02-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602200080 On Mon, Dec 29, 2025 at 01:40:10PM +0100, Markus Elfring wrote: > … > > +++ b/drivers/gpu/drm/bridge/lontium-lt8713sx.c > > @@ -0,0 +1,682 @@ > … > > +static int lt8713sx_firmware_update(struct lt8713sx *lt8713sx) > > +{ > > + int ret = 0; > > + > > + mutex_lock(<8713sx->ocm_lock); > > + lt8713sx_i2c_enable(lt8713sx); > … > > + mutex_unlock(<8713sx->ocm_lock); > > + > > + return ret; > > +} > … > > Under which circumstances would you become interested to apply a statement > like “guard(mutex)(<8713sx->ocm_lock);”? > https://elixir.bootlin.com/linux/v6.19-rc2/source/include/linux/mutex.h#L253 This function holds ocm_lock across the entire firmware update sequence and has multiple error exits. It is therefore a good candidate for guard(mutex) to simplify error handling and guarantee unlock on all paths. I will convert it to scoped locking using guard(mutex). > Regards, > Markus