From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Neel Bullywon <neelb2403@gmail.com>
Cc: apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com,
lukas.bulwahn@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] checkpatch: mention fsleep() in MSLEEP and USLEEP_RANGE warnings
Date: Sun, 22 Feb 2026 13:11:19 +0200 [thread overview]
Message-ID: <aZrkVzozG_lp3R3o@smile.fi.intel.com> (raw)
In-Reply-To: <20260220230555.56255-1-neelb2403@gmail.com>
On Fri, Feb 20, 2026 at 06:05:55PM -0500, Neel Bullywon wrote:
> Expand the MSLEEP warning to also reference fsleep() alongside
> msleep(), and expand the USLEEP_RANGE check to reference fsleep()
> alongside usleep_range() and udelay(). fsleep() autoselects the
> best sleep mechanism based on duration, making it a useful
> alternative for developers to consider.
...
> - "usleep_range is preferred over udelay; see function description of usleep_range() and udelay().\n" . $herecurr);
> + "usleep_range is preferred over udelay; see function description of usleep_range(), udelay(), and fsleep().\n" . $herecurr);
"fsleep() is preferred over others; usleep_range() is preferred over udelay(); see function descriptions of usleep_range(), udelay(), and fsleep().\n"
...
> - "msleep < 20ms can sleep for up to 20ms; see function description of msleep().\n" . $herecurr);
> + "msleep < 20ms can sleep for up to 20ms; see function description of msleep() and fsleep().\n" . $herecurr);
"msleep < 20ms can sleep for up to 20ms; consider using fsleep(); see function description of msleep() and fsleep().\n"
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-02-22 11:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 23:05 Neel Bullywon
2026-02-22 11:11 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZrkVzozG_lp3R3o@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=neelb2403@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®