From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C47373EBF0F for ; Mon, 23 Feb 2026 07:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771830580; cv=none; b=UAm051uaxTkpqu0TdNUr5VobgZMYK9HEwP6e4qx0A30P5quMCp3BzWdfH1G+gtmT64hazYpHZTMwGjDWyIr4D9NzuGU5rqgu4tY2pMnjVghzoFNSi31l7iKxBsSSnvx+ej4nWLekljyqQKoiFx5ILdjALFNW8D5LseBT6shnDbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771830580; c=relaxed/simple; bh=Iqtz2g3HzJhL00/YHzVQ3GOD3dwKrWISarTZCm7g9wY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ur0ebX1bhMpgCRzgSQgTBUx6H+ARv7U9US66OMxqhlmwH0oEKgusYglIp/i1e4CpiQjTUvMGldJzHEt18CkrhMrunqnK+AJWRdXZZPm2cub9PTIty25XUWHN0sWFBODU5aW+3WcptdPx4zb4qs27SPU5M2VK2gyuIfDVEXmPCS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Vh/5bGF6; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vh/5bGF6" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-436356740e6so4213008f8f.2 for ; Sun, 22 Feb 2026 23:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771830577; x=1772435377; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H1wsuPiTOwW7PjkIjhH7GAbpoYbf9yyFH8CBGPXDy/Y=; b=Vh/5bGF68ljhj3Vxm4p+kgVTVU8NBSzSrnuYgpqqNgYTM6FEo+KLSCUIgzevgIdIHl j8V0crId48FMX0iTVB59TG/Ff80YXoh+nlN3N8Uka6WqAlWxL8+QDrmpd52rlebB0XN7 E3Lgd/hH5ksmT41nvkJTyzkjvr+n8Y02QmsHOVgggRbQSUPwYFPUTQ/Var15oM5nHNfA QNCsg2mJ9n5/PJrQF11+y758Jgtf3ujCIH116Pb5tBKqC7p/7PG80BvyeBjtBKWW7QLq BPR14LK6ROScCWUu+pIuU5earCsD62f0WoAUwy/82Xt8utUZeAwFFVRm5/X9ZhG1fMZ/ LiWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771830577; x=1772435377; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H1wsuPiTOwW7PjkIjhH7GAbpoYbf9yyFH8CBGPXDy/Y=; b=C8YWfjmzG94oJYhkDjvNWIXMKZgmO0sl8JtZQYHO7drpWmxfQihp+o/9md2zrlnkgi U+P2jOkGSVqmWbwm1H0ivOx34bZ1889+EzC8PKNoZgf7tZER51/c+HuzmLDQfoxsXKch SAtTMMgY1ctdKsigyO6+W93jEbJa1ypPFRN879HDM7V0+7xoqB/ynktfKlYiMFNcgpzh 5qhinMGgP1isARByMiIaTeqzJSdIEIVOTPFEJ5J0W2FbbIFQBtE94LCU8d/G8/TJm/zr x2flGfWB7vr/v2wj52vWds9tIW3QnReLgwiy1hr2p2VBryTuqWyw3g1nX10V3ybOl5q6 q3Lg== X-Forwarded-Encrypted: i=1; AJvYcCUgYA5ZoE7l/CsMDQVvTBoB1q8YwmqUKMEDqF46qFVol4MED+S0qY3wqzL6gZ3B9Un06Cd57L3TE61/HFo=@vger.kernel.org X-Gm-Message-State: AOJu0YzpvfFOWcPh09XGRRnvuUpg3D7V6mi16+CfOTMxuplvezsC6IVv lYZxGPyDcNbqkxcmye8ZsCh5boWFJWPvG6pGzVyBeOHzN7SUOkoa4Jl0S5vEGtNtDYM= X-Gm-Gg: AZuq6aKO/VNr5up3wnD6fFSHdbNRBmbBkQTNEjVScEd/AfGWEOtkII65Wl90dgFIzDS apKq8HWOG/BPU4x15N1CXMLUC+bptHI0d5eS407ekBq/L6LAxF8eTIOSqewp0rFbtnGLPalB0qr /yA8ZZBYvJER/mPn9yS9uuLLnYM+NPHuiYEgQsdDZSnAgW2+qLp+9F10cOD05d074386hQu/kCM atVOlngPNMCgZFp2Q/nbw/gwBb7xdwZRLCGhRMBoRsYgZJ65D2SQsnI3rp+Mmcz0U6dIVcK/RGZ 4wYtljSFx3m5jxr0LLzNk4nL5rWnJazer0KWGrsp0Gcz6HmUgImgEwm41JujXcmKz5tPRtCqMfA GNOmfguEbaIAccnz63phrqasEPKSExZ7P9+Y/pmnwT4Dqj6vo3EMt2zFMBiVYqQ== X-Received: by 2002:a5d:5c84:0:b0:437:6d8c:c08b with SMTP id ffacd0b85a97d-4396f17fc6fmr12479096f8f.49.1771830575135; Sun, 22 Feb 2026 23:09:35 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970c00db8sm16849488f8f.12.2026.02.22.23.09.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 23:09:34 -0800 (PST) Date: Mon, 23 Feb 2026 10:09:31 +0300 From: Dan Carpenter To: Vivek BalachandharTN Cc: Priit Laes , Greg Kroah-Hartman , Archit Anant , Minu Jin , Andy Shevchenko , Thomas Gleixner , Yuvraj Singh Chauhan , JJ Strnad , Julia Lawall , William Hansen-Baird , Randy Dunlap , Abraham Samuel Adekunle , Rodrigo Gobbi , Navaneeth K , Artur Stupa , Michael Straube , Hans de Goede , Ethan Tidmore , Zhuoheng Li , Michael Huang , Nino Zhang , Ingo Molnar , =?iso-8859-1?Q?Rog=E9rio?= Fernandes Pereira , Diksha Kumari , yingche , Khushal Chitturi , Karthikey D Kadati , Akiyoshi Kurita , Erick Karanja , SeungJu Cheon , Sun Jian , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/11] staging: stl8723bs: Use common round_up macro Message-ID: References: <20260221190628.50273-1-plaes@plaes.org> <20260221190628.50273-2-plaes@plaes.org> <517df668-cc9d-4a9a-92cb-04aa80069a56@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <517df668-cc9d-4a9a-92cb-04aa80069a56@gmail.com> On Sat, Feb 21, 2026 at 03:41:27PM -0400, Vivek BalachandharTN wrote: > Subject has a typo. Please correct it. > > How did you test this? The driver code appears largely AI-generated unless > it has been validated on actual hardware, such as Pine64 Wi-Fi module or > another board compatible with rtl8723bs considering these changes are not > just indentation based. > The patch doesn't introduce any bugs. #define _RND(sz, r) ((((sz)+((r)-1))/(r))*(r)) This is the canonical way to implement a round up macro. It's how roundup() is implemented in the kernel. The patch uses round_up() instead which is a faster version but it only works for power of 2 rounds. psdio->block_transfer_len is 512 so it's fine. I probably would prefer to use roundup() for that even though round_up() works as well. We maybe should create a static checker rule to warn about using round_up() for non-power of 2 values: KTODO: create a Smatch rule to use roundup() instead of round_up() for user supplied values, or non-power of 2. regards, dan carpenter