From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE75733342E for ; Mon, 23 Feb 2026 17:45:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771868761; cv=none; b=Gsb280YyOZF7wRxGfNADn4SZKuIN+lrLPkNmoEYFMIhE5MtFMrMNYtJUQsDyP0QGFBxo2u+D7bs1JqJECiJf0Kcp5WMC3c5l0b5ZAaRzwT1LgAemsNKKOmvJoPNRudulWs2d+NH2/F82RVt3GFpJQUToDxEe2i1c3jW9QmiLm5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771868761; c=relaxed/simple; bh=Mr4dG+bzOuF16thFEQnsIOy91AByP119yZcwcBivwY4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KOIc2eTDDsDpSeblIPsJEaGEMBMOaID7n9pJ0uHyPTEzkZRkHb4anerUZqp+Nb0CYZC4xXI3xniNatMSZjpgGrqY8XRvFO21rBXukDOhWNWRoYMGoCSFZ3RMCYu7/AfqROJpcvNgiAoz7nZX9PARqOeXbYHXq8GpRtqlBiUMKvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=T7wsU5+H; arc=none smtp.client-ip=209.85.222.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="T7wsU5+H" Received: by mail-qk1-f194.google.com with SMTP id af79cd13be357-8cb420f7500so464118085a.2 for ; Mon, 23 Feb 2026 09:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1771868758; x=1772473558; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yPvGJuHAbjpU9QDADIGmFWRlHKf6KaDUt58YXXRLtsc=; b=T7wsU5+H8yrtdKQTgbMZLZbJPG+0sFxsXygXzl3W2kbqHtFYXzGdeNDfnOgFPX3n8V uFR58PyrRZNVYDR5mKzNNDzUs9RSNF4hBi2Zx/5TKH4wgcOAPpcNM4hxdtNc31tsOcwK oNZ9kYCU6idrNzEBSUyKGFA04hO5+WKsKDhtgGuFR0Hgu+htlYZIpFqMocQ9iHu6zKoN QAQzOFkrN4fyFEriTcgsY5zjE7O7EePvu5DmR/vqdCCxaCXvHqq6/zsbkB5BuAyTwvjQ 7EiSrCy3mcLB3m8vO7VAkxOZpv2vAoHRJVvJoIrCnBS2MJdDjiuwDcl0kjH1Z7g/E/nQ HFCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771868758; x=1772473558; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yPvGJuHAbjpU9QDADIGmFWRlHKf6KaDUt58YXXRLtsc=; b=FnFlj4tuetpuqG3bMHXDr4rIv15gQ9ZLgJXbDVKUbFZ1L9lIghxnocOWimPcH5b8ie nlSeLz1KIrkJOGbe62n3f5HMfjlO2oZT6Azgdmc37hnQT4qgFrIWu+urgqD2Q6b+f0cg MJXfbLqicmPdDjK54dhShVpEmgvahKDC6dcWxds2jDVppabQOcjqmkD8mFYPDMWVYkR3 iY8w3bt4D1tiy9NbP5yvXaCQKzGcv0sNq67vXkmxiGEyJmHbNbXkuSJfelzKBvhDOZiz jgrZ0fx/Mpq6m2mU865Es0U217R3YlX8wi0ufKzxdcw6sQvhuhRoh5PerNVFtTcF69A/ tAfQ== X-Forwarded-Encrypted: i=1; AJvYcCX6o5iKeg7hoyJsS/iPDchWu42qlv1oPvNPkFxa9dgFFdWb9zYQikFhDR/qulduhtN08hRexj+78Rp6Msc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4If4gmvJ9m7u8X5Pg4L8X9MujQm2fHwCvrQ1x/TJ7QZqHpFpx UtJjzmgn4PiGyqbeOFtETSoNybBtgitbauehmEHymwtnlXcIMeR1JFuUr8Ysju7p5fg= X-Gm-Gg: AZuq6aJJ7Ew/htsFKEQVRzY4Q6eHRtaQNcbNYmzAOw+sEFxykQiB4MRxWxAGfOtA2nH 5FTKWHRsz26ntI2NglrGFGrINdY0SHiakEjuXFERdstMyWIpuh0CE/kZSsZLEpZ+kXTrxwoLTqy UWWZQZoTnp40VNGehryyP7UaUHzc1RCNmeOD76EX7lvFz1YYr9dWhgmhr6RrTEevju+uLmxeEJ4 EDPVekm8qrGV1wQFtTwzai8xfQ3L7OCJxj7pxUetxktCLVeO6hhaZV8JLSn6MuFN0vJL3pYLv6u CIGLB4U6mVKHmrcIFvePl/5vzBtho61YKtoRAgTYzJ9Hs/mYLfzcohOBMa3G4Q3rwieFQ3fWPlg UGQKzjMKlmKKksq/qg6uQ0fc+9kKIr2E71Yrp9yEGqH0Vlo0f8vAaeSQMFWn+bUMR7Qs2ly2mjd mcpMNCbJU3IoSPOTFyDR7/9ilbxM7pyRIrjctvQsW+6cLAaMBrY6E+ljIXFoj2SVA1fKH2B60UM smhZQ+86A== X-Received: by 2002:a05:620a:480a:b0:8ca:3c67:8924 with SMTP id af79cd13be357-8cb8ca71e02mr1276284985a.42.1771868757602; Mon, 23 Feb 2026 09:45:57 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cb8d0461dbsm854265185a.3.2026.02.23.09.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 09:45:57 -0800 (PST) Date: Mon, 23 Feb 2026 12:45:55 -0500 From: Gregory Price To: "Cheatham, Benjamin" Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com Subject: Re: [PATCH] cxl/core: fix test_bit misuse with CXL_DECODER_F_ bitmask flags Message-ID: References: <20260221021810.1390342-1-gourry@gourry.net> <85d7abf8-3b3c-4199-a680-1453f77b3fd5@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85d7abf8-3b3c-4199-a680-1453f77b3fd5@amd.com> On Mon, Feb 23, 2026 at 11:33:13AM -0600, Cheatham, Benjamin wrote: > On 2/20/2026 8:18 PM, Gregory Price wrote: > > CXL_DECODER_F_LOCK (BIT(4) = 16) and CXL_DECODER_F_NORMALIZED_ADDRESSING > > (BIT(6) = 64) are bit masks, but three call sites pass them to test_bit() > > which expects a bit number. > > > > Replace test_bit() with direct bitmask tests, consistent with every other > > use of these flags. > > > > Fixes: 2230c4bdc412 ("cxl: Add handling of locked CXL decoder") > > Signed-off-by: Gregory Price > > Alison sent out a patch [1] two weeks ago for this. I suspect you found this bug > independently, so I figured I should point it out. Otherwise, I would add a Reported-by (or some > other tag) with her name. > > Thanks, > Ben > > [1]: https://lore.kernel.org/linux-cxl/20260206181404.1025991-1-alison.schofield@intel.com/ Ah, yeah, missed this, and did find independently when testing unbinds. Wasn't on cxl/next so I thought it hadn't been found yet. Cool, thanks! ~Gregory