From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7CB3165F16 for ; Mon, 23 Feb 2026 22:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884890; cv=fail; b=Op4DIZAwZQ+TBnoiD7pUoUuh06BtSXbh8jVGHOUUvur9WMSUa8WbjiEaPcNo4as1uixA+sIIRpd7+xNsQnxevEsaDiWU1ZIsHBrXVV8hVTNzmfatDcqNxtaNZ4R2kEFSyNDz72Iw5j+bxUIO3UCafpFq/41V6W85hPgBrRB6jAs= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771884890; c=relaxed/simple; bh=e6yHwFf6rew2PPDDkwKeOKe5CN/0BEy2nVJeOkp9dFc=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=Ok7GNT9CJ6DDbezJydFLHDtNGloLX39EE5XCJDTnk06P8pDUxyrw+XCf2JSs9IxHgiXPBGdEM1vpp2RNnGxpNoSjkJZpEcrkK9MGOlHFuKP/meOppN/6L32UO7f+xfVPUCMf3gA1tZ9JOyRXFu9TLxxjFoqNtOhyEIwlVWb+CCo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GIjB4v7b; arc=fail smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GIjB4v7b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771884889; x=1803420889; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=e6yHwFf6rew2PPDDkwKeOKe5CN/0BEy2nVJeOkp9dFc=; b=GIjB4v7b0x7OJdBoeLNC/XptNZsbxLqXDLk7wYnXAbMfpYw2uQDQ4QEo PlHw15XgBYMNt5sy+jtyIFHs+eHjWc9jXlSFe27g+wjnnx1llOxpxaHAg Xu81PPD2SNUeg1KNjtyT/L0e19rKUbGBh1qGsFrT9+84Fo00wbfhLUohf BwTeCr/LVCvoIXIEsQ9aKHSZ5V7rzruH/0ThS9iCsJyos10afGR70ykZG zfwjxyC2BcfwocDKC21htugMHOxRhr31GUSHUd9rvw4BgqJve1jgTmaIz ks/i9r/BhxBKNUimQnto3I3FkBZGgZfD7kgrq0fc+t+Tr+Rm1hMEsYyoq A==; X-CSE-ConnectionGUID: s22W3FjDQNWwvX8sFpI1CQ== X-CSE-MsgGUID: kLBP+wqOSQyBz5v7mnW/ZA== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="84255168" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="84255168" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 14:14:48 -0800 X-CSE-ConnectionGUID: Efu/4fc6RHacoTIR1KYYuw== X-CSE-MsgGUID: aGzYWtgUSlKJ+UZ/7fBdBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="246288261" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 14:14:48 -0800 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Mon, 23 Feb 2026 14:14:47 -0800 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35 via Frontend Transport; Mon, 23 Feb 2026 14:14:47 -0800 Received: from SJ2PR03CU001.outbound.protection.outlook.com (52.101.43.37) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Mon, 23 Feb 2026 14:14:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XUDpUWtfhPMyIf8uaLyGnhz+98yvl1NEMKFASenDQYrw/+gqerCqkYLReGvip3uuET9rGUuSIwAwK2JmwzrRnd3jcfVWeNznx8SXfOeqXn2F4t18I4Q+xmindmW/cPGYoOoB7c7n7KHFoXK/bO7somK88SC9aXKzpSQ39q5wyVoZn0NCLwaEjKnK5xLbkkV5eIDLnIPMWWPsh5o6KSQ+TApm1PnnRPYVHNXJ0jouVM5sZH/v7fkU4/TZmdXapNPu7MIKdH6pm6H8kzBIqSTLnVKHPIB2HxBc/Ny6nVS5nhhpNjqM+LHPgUT+9FrH9FnmMuU9km8Gvl0B/akG/cUHRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZK6jIxCDZhda4M17joSXqz8TKWrpERZDN3z1ZxMPVTc=; b=RPgEDxr3Sy6IyFSNtYYGJwNe9TV13Fvv66cnQ0GEyof9ybWBf6kX8oVhu9BkRAesKvwI1AdgnNL5/amlIWnZ36R9WH/bSaTr8FH9tALBmiM5w2H68L+CDbbi791IsyYa0MBAJX4TtbZoT+SUMd3192bwIP/ycDXV01NcwSnJcXURK3qqn2IkUGMAXHcmSjBYIeoanNz9hpIy8h2seZ3jOSAtKCWDPINDy/CMXH+dzQnHKhtQHEL5kzrI0KzyesofRI74fUeTI5kUDsf7xKYesHXcfzwqzC/+ukmNPT/w7TiZ/PBlfuifUB5WJ1LGTWlIY6p0+zcxILM44TmPzeviaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) by CH0PR11MB5249.namprd11.prod.outlook.com (2603:10b6:610:e0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Mon, 23 Feb 2026 22:14:44 +0000 Received: from PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::e0c5:6cd8:6e67:dc0c]) by PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::e0c5:6cd8:6e67:dc0c%6]) with mapi id 15.20.9632.017; Mon, 23 Feb 2026 22:14:44 +0000 Date: Mon, 23 Feb 2026 14:14:41 -0800 From: Matthew Brost To: Bart Van Assche CC: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , , Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , "Nathan Chancellor" , Kees Cook , Jann Horn , Bart Van Assche , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Thomas =?iso-8859-1?Q?Hellstr=F6m?= Subject: Re: [PATCH 11/62] drm/pagemap: Unlock cache->lock before freeing it Message-ID: References: <20260223220102.2158611-1-bart.vanassche@linux.dev> <20260223220102.2158611-12-bart.vanassche@linux.dev> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260223220102.2158611-12-bart.vanassche@linux.dev> X-ClientProxiedBy: MW4PR04CA0193.namprd04.prod.outlook.com (2603:10b6:303:86::18) To PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6522:EE_|CH0PR11MB5249:EE_ X-MS-Office365-Filtering-Correlation-Id: fe7b7b01-4b56-44a4-5158-08de7328f2de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?Jc7aZTX4ah8ep4KIIesHC2XCxmikinG3GPyoDGrWgiOxuJVs3sgTNXBcoY?= =?iso-8859-1?Q?0mxZyouFbH6lcZFckvNw7Cyjc5KB5TmZ6tb6+EkFcM2D2xpcxqsLfB/ZEh?= =?iso-8859-1?Q?CYxsg4jOJa4J0+jP3grFyj/ww+oIJ8NsKRynhQVmeT2VYRoT+ORojDYA0Q?= =?iso-8859-1?Q?ZsusPBBRufDisXg3jxAEXZORGwEarWhITQgByz+f+sg2dJuo5xoLtRcqzk?= =?iso-8859-1?Q?PW1NhWvZ29c5VXwiEEUhfwA8X3FSzPr9Loko0Pkzgx/i7Wy8hf1q0xEvXa?= =?iso-8859-1?Q?bGeC7XDxa8UoVrkJi6vOwf44H0nlXEDKSjKKqrMD55OtunmsGd0RMiRZKW?= =?iso-8859-1?Q?7LEqRVVKPGj1tv98k9fU82DPOZ65toqHDWX+7ovVDTqR785p8zO8x9YnS5?= =?iso-8859-1?Q?JE9TPlGPevI1BbL0Itsj/9fnx+VAMqlME18l16/2l7L3sM6IXMniCD9MXq?= =?iso-8859-1?Q?TBuOU9Z/F/99ldB1ZJYlHbWtTvFmK/Vnl26cNTXOY65o4e3kKo3W3KR/8T?= =?iso-8859-1?Q?Ae2KPVHTaDt3ErtGcLzxrGR4sGZJMSSYNslijyVIj7kG3bulAojdYA0Htx?= =?iso-8859-1?Q?XkXL7q9mBkmfoSD8x9M4ZOL6frHNcHHYpBT4tJH2K1LmQB9xIFG3gepcR/?= =?iso-8859-1?Q?q7WNo+Grj/cqkPIEoBwcji6ZGFK/wdUeVskHdxinH/PPx6qMrDp2a92ucj?= =?iso-8859-1?Q?daEltj/CZVabV7BkZGw2QFb3TzfX/j1IXQBKmIG1MD4ciyzTsSS/Ud2vnm?= =?iso-8859-1?Q?jDbfzbSn22Ve/236DkRKcFhVW77EqGAr3DV0JPJ038aZBhr/jfPqXOWDae?= =?iso-8859-1?Q?AnTjwpAyPONsR1awGEeRR4PpitGJkndFOwgM+E3OHbjGLVwTAhyuukpYEw?= =?iso-8859-1?Q?kkUdp7F9mmngCzz8MJq2eHLBOUk+8U2sNrOc5fAh12JvG284u/5UykVxWk?= =?iso-8859-1?Q?Y0j5As6jq39iH+j/zemXQt3X1ehOjLi8gqMr8PfQcumCmY+AYsPmVSsbQr?= =?iso-8859-1?Q?uwZLZz+1QSSWsMr/LXL8B1VbP+4NQLHo/GANSMoyCdlO7gwoI2aqRgfi8m?= =?iso-8859-1?Q?UCkuuKUgywfLksJ4h5ybWm2Jgn1tIAD/aRPL5S0l2xbDfL2lKBNuQN44AB?= =?iso-8859-1?Q?7dhSQZLfEBZve3U5yE2nH3B6FXke9Xg61dRTZ40rZY+0QnoMgrPWsCpA1S?= =?iso-8859-1?Q?6RRjtK5GPyCAnJX6qYFZbVnkVkgX/QqFJ90nN/B/PxT/KPXdkr4NVtLAn3?= =?iso-8859-1?Q?B75EYeHm82R+qTlj6Z30awAflwU+B4ss70/9VXmEoMtkjMEKUnZ7LWj7Yj?= =?iso-8859-1?Q?EC0kgXXMH9LE1INcAE7gO+KIFxZc2a9yduIxL9x3mhFcyWGyCY8DOVB4UB?= =?iso-8859-1?Q?v1KGtMBM0Nt8RFoI2IApJFt2FX2q9r3YBGfeArtaqIyM0vHFbVu54qQiKT?= =?iso-8859-1?Q?5O/REgWbxzS26DQC4D5XJE0CUYjKbsb1Nlf6WJNa4kaofi7z6M57eYbUeW?= =?iso-8859-1?Q?GpjzUV50A40WyoVTh1hX+4Gidz1tNFT/7lh9kmLFdXcAqcVusLpKipIlx0?= =?iso-8859-1?Q?terdYp1+0AhNJNx1T/WI0OmDZ9nqMeHw5dl9fl1heOc99VKKszgMFYQLwI?= =?iso-8859-1?Q?owZmO9/jXHqe4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6522.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?vTRIioodY1jyozjpcKEZW+oo8kgliCpTSwvnG8g285REyoMXtgl2PAD8U9?= =?iso-8859-1?Q?FEoEToidEsObeGpC8q1v4FEuqHyF2KhjapAzObMYYPj6yGlOsfjxKE4jqR?= =?iso-8859-1?Q?+difaG+pXqFmU3urdn8EvISSQzKFrNBVVcPwBetkkVeWxcGV80/PM9LSQT?= =?iso-8859-1?Q?tgghRcfA8gqB29JpzNtU+21tgRg24vNnH5x3L8EBuF0PVlA4+ixAlQB/mx?= =?iso-8859-1?Q?KiLb+g0jJUyyUPsI8poh1Sdtkc3Gs/LwzWNNLPicprtdqPpY9UDX7Bzc9Q?= =?iso-8859-1?Q?Ct4LXNFH+PJ1CxJEfL7SYAxUstiSffUQNAbnlNTlD7V6ik9mO1D4CR9p5Y?= =?iso-8859-1?Q?GAwWK5oplsvPdpcaTRiX7lHBxDbrZNK2lWuzZb3/BLh1E/CohMK+KrXhFK?= =?iso-8859-1?Q?uNRGq2+z1jj/nOGdxBofVYxirBPz7e558/UX6HxIlmFICHS/dLPFKD/3Bu?= =?iso-8859-1?Q?yc+vKikWb8cH0s0Q8rIdI1dwZAPPlb2QBBJDb8fSQiVESvBFnhi/vq/EuT?= =?iso-8859-1?Q?VC8a9mYA195BBnEAtfHkeNuKJhVqr/C8CViyX5cHASNknty7jsW+3Gj52M?= =?iso-8859-1?Q?ykM238osm+zIG3eFl5xQtm2afN90vydcjHtjQYRHSgJ7rIwHPl7N6aR38d?= =?iso-8859-1?Q?kYrCYK+IhMKteFwJRtRGM5zvOzqAeSWIbuiQ+g2bMAZZmDVZsZLT/sAPtR?= =?iso-8859-1?Q?qhuLAG7ACXhDmzhfd36SwR8fEwgX01Sx96YKxsxBa9Mcwt+n0cU4H1kaXX?= =?iso-8859-1?Q?Dl/AUAZ+Fsq23k9PcWodyrcp1l6Ds98zWd6AvZkTDBAxcETCTzLQ6tYUDr?= =?iso-8859-1?Q?VE6yeuBiOOGJGDrx0aa1UPdWYGh8IyvvrbJ6yw622KedjFbk274u5ix7R4?= =?iso-8859-1?Q?kiPIJ9dIdxg1jxlb0q8DidEnHQ5IoEvj818gLu1Aswi3nWqhjuJiZrDW2J?= =?iso-8859-1?Q?3KVJmvpkhMjwQc1kxx2C4T18gi5PFXeCSckIhVKFIoThM6q/19pikIQMCL?= =?iso-8859-1?Q?bXWCWXywp6Ckfge7D4gWNn2Pd7o2JdqcyLj/h1kLVLYPrhLzzta69WYRHZ?= =?iso-8859-1?Q?cNUnwfNr9Pu2kRDM3aLGfNdtvZsoPqyiZZ1k9kmXvjNkN+eqppjh7h5Kb4?= =?iso-8859-1?Q?IC5cxVx9xgRthTrIVFUq4eQefUHSvX6/WClFzgkB/D8D3ZyuSPYUsjqe5H?= =?iso-8859-1?Q?s8YUC94a/r8qzZjIQ6T2y/a6TjYnYlDAeL1WEx1aCYDmRA10XjeaJaD0qZ?= =?iso-8859-1?Q?He10EeI1pa6hbcuDV0OLfPxjTi5/qVMewDqgEaqCsay9LWhkOd5bf6NL7M?= =?iso-8859-1?Q?5g7WMm/E1by4Pzb0yOxNUaZC5fwKJOlkTJvV5Xgl8D55QCnMguEjGAVA+4?= =?iso-8859-1?Q?qtKTsVLApKOOb0HPndgQt2vSjECvBkolXwzJvvUO6MJ1WaKV5EdogyOmRm?= =?iso-8859-1?Q?+sjwr9SSvpiuVyck7tCzzH9aEYp806SM5ZFHUnEmhYfwUMvT3Cui0BhvXU?= =?iso-8859-1?Q?W638BgZ+365wdOFvddULmKtOXQAWy8PC0ny3KwNn6VHt+OXPjUeXSR7Oij?= =?iso-8859-1?Q?s3PB4vLTsOyDpZyqEjuv83OdQXJ2h9j45hHm2QLHgRoLjg7fa9JHU2JUwF?= =?iso-8859-1?Q?urox0qUP46FXoYV6wymnGSc/4X0OJfx5NgVN356ya0Xi7h25PAJtRrTU18?= =?iso-8859-1?Q?idQHq3g9cA8ElMXva6SKi/eZs38/oa4ooJi2W+PnHDwf+x2A8SRAKT6F8m?= =?iso-8859-1?Q?lUVcKoehPiME6923OFIGh9lcKaYA48zZBgsQjnaweprY83DNd4TodBO9rh?= =?iso-8859-1?Q?HqJ4D/IDQIWhaKH95nk9KTUFE87dAPU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fe7b7b01-4b56-44a4-5158-08de7328f2de X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6522.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2026 22:14:44.4573 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HVZMqi4ihilOfecXNHNoj//ApSxTvygb6NX9e0DYq/mg73q+v/4bBNKKhwVwsuem1KDo68fzvx0rXXIWZWSc8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5249 X-OriginatorOrg: intel.com On Mon, Feb 23, 2026 at 02:00:11PM -0800, Bart Van Assche wrote: > From: Bart Van Assche > > Although freeing a spinlock without unlocking it is fine, this confuses Fine, but pretty bad practice. > static analyzers. Hence this patch. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: Thomas Hellström > Cc: Matthew Brost With that: Reviewed-by: Matthew Brost We can apply this to the DRM branches and propagate this up to Linus during 7.0 cycle if that works for you? Or if you have other plans to merge, let us know. Matt > Signed-off-by: Bart Van Assche > --- > drivers/gpu/drm/drm_pagemap_util.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_pagemap_util.c b/drivers/gpu/drm/drm_pagemap_util.c > index 14ddb948a32e..50cb5f9cdac5 100644 > --- a/drivers/gpu/drm/drm_pagemap_util.c > +++ b/drivers/gpu/drm/drm_pagemap_util.c > @@ -74,6 +74,8 @@ static void drm_pagemap_cache_fini(void *arg) > cache->dpagemap = NULL; > spin_unlock(&cache->lock); > drm_pagemap_destroy(dpagemap, false); > + } else { > + spin_unlock(&cache->lock); > } > > out: