From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a3-smtp.messagingengine.com (fhigh-a3-smtp.messagingengine.com [103.168.172.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C57022425B for ; Thu, 25 Jun 2026 05:41:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.154 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782366070; cv=none; b=c/MOFgUMsb93QxQLbv0nqOx/EDp2+xWaUlqf8TZ9Yh9/o6PPbN07Pbqj2r/+mb2PKaUwUBi1RbS84g60QkSP6LhrHdLCqALDvVPQ30Rh4fXykXjRdkH4fX/qfNotn0CulYCyxvU1M8+q/z8dxZDJW+geeXaWwc4JM06m5ElkLcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782366070; c=relaxed/simple; bh=FIKnXSRtPu6iqvN9bpBkjt1X91k1wLYtPLQovD5Z7+U=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=s2LOmbhimyVgnhcKxzvFjYP/0dXlrJgWcQ2Rbil/Ltubgt5SW6o7m+LTR+AvW7FKRgpze6AWS7xIEBrS8B92Xk2VTo0GZdXxo4q32k2gsAYaAhCGuCAxqaq7dTSGV318JANerCi5Hkhte17HA7cUg7IAdxqj5KzPlmZEYJx1FBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=pHSbKihF; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Vv7NAptV; arc=none smtp.client-ip=103.168.172.154 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="pHSbKihF"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Vv7NAptV" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 54969140018B; Thu, 25 Jun 2026 01:41:07 -0400 (EDT) Received: from phl-imap-05 ([10.202.2.95]) by phl-compute-04.internal (MEProxy); Thu, 25 Jun 2026 01:41:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1782366067; x=1782452467; bh=FIKnXSRtPu6iqvN9bpBkjt1X91k1wLYtPLQovD5Z7+U=; b= pHSbKihF7F6IkGVyK2JiCR9G52ONHT0kG1H0Qmh0Kw3kdfgjqF15sIlhx9fwfqQ3 HbybIiliZ/3Kc3d+Gc8JHPqSQ9lXEbSMoK90CqRF+qCtCwXqWxRhtTsjBjX5+U6M qAE80VDppuXCvslOY0muxbZ46kYl76KmL7G5FphHIpak//QRwLB3g3fQahoWkFZX Xy1MWCSAJqiqBXspCcDPkJtYyGpAD3SsZvIrVP+lnrUgIleNhdjMeDB/IztRlksO imfLniftlNuzkd0LIeOE3GgSwTrm6EEA74CzQbP+oi01lgXb0n9ey2pHt6OtoWyQ jEsWnnsEwj788qU1JsE4Xg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1782366067; x= 1782452467; bh=FIKnXSRtPu6iqvN9bpBkjt1X91k1wLYtPLQovD5Z7+U=; b=V v7NAptVKnN1liHM1xDylXiaHKF57wIwKMVggmOV9UXSm+o0EgxUZ+hWkG5PWyiSk ucSe3xfx6jkdChHsrflpoUWxGj/FB2dxWdmqXT8gxGLOA2Nv81fVaIFgLKbrvHlB RzYPSaGqz/pW3euOtyrm9ykppDEtukSvadmGIPBrGaqcK0bqlHZ53aHIutSTCNm1 nWfP4l/NuxGSIg/6cQ5mNs1dsPH5VCpbfIzkskdOsCwcFgdf4gaCfK70geXKm1Cu 4SCifF8ilB2LyyXZFKr7xKqxkMnPWzBj5CyKake51etFs3krpCYpUh9ZhnScunRm RgCjaknDfsYyNvP52c7zQ== X-ME-Sender: X-ME-Proxy-Cause: dmFkZTEQ4x9V5vJPAGsqMFEbv6gKl30n1OslvNrmzKaqF6QGeVIZTp4vIOpZHzPAD7LFpE ASHxvoo+kNc04hxfAmFmF3fLKBBZMuPmfSt1oR3TNvbflYnCjvRuBbCW0PWcQ8SRcFoVIu OhIjRuNLdKEVG6i7qMajPzgO9xfT88laZqOOmxN3iRya/jDqeZKvQ5wNlFqYHtcgPhDvXW eVeYjTBH0h4jqv6IKBsaryPNoV/eZFDblB68Ib1/M5LVXw5AP5bCqTVxSirHj8O1SpF/lW 37QTu70uHoqkYjVCSuEeX4AhIdTn/wHxljFBpQhYvM55DdjBJ9gWBaQu7m9vwz43b0CMK/ xgJ4M2qkqCOAZac4TLDe2sEqI9uAxAo0PKR9hZpALPF1222yGptejSAjUGxUhOMEsD/0u0 O+75C2vZXx0JCt+t/uhoiexRnisLVfl7jvn4RzKp5+bdgtl0QJtAug8XUraL4+qLKKOja6 /mexFJbAOalIozoZ4u0XtXUMwcXlAjKYXf4N3HnjCLKp+EcW5cZc9j/uAyve9hLoMJv8PO aKvggVmzDT773aZgSv7Lwt+yqTjz1L27RbkmNJTDk3wReasLPI+QTpw8hjldV8d/ntvsXj cq+t1CEouG9RW6cjEnp+BdCg/FaLOtpULwaYPI5V4j+w/1f6RfJLEE+kUKTw X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 0A4C6182007E; Thu, 25 Jun 2026 01:41:07 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AWHVdjpP6erc Date: Thu, 25 Jun 2026 07:40:46 +0200 From: "Arnd Bergmann" To: "Yousef Alhouseen" , "Alexander Graf" Cc: "The AWS Nitro Enclaves Team" , "Greg Kroah-Hartman" , linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20260624173501.4094-1-alhouseenyousef@gmail.com> References: <20260624173501.4094-1-alhouseenyousef@gmail.com> Subject: Re: [PATCH] virtio: nsm: fix raw ioctl copy error path Content-Type: text/plain Content-Transfer-Encoding: 7bit On Wed, Jun 24, 2026, at 19:35, Yousef Alhouseen wrote: > nsm_dev_ioctl() uses a common exit path which unlocks nsm->lock. > > A failed copy_from_user() reaches that path before the mutex is locked. > > Return -EFAULT directly for that pre-lock failure. > > Signed-off-by: Yousef Alhouseen > --- Reviewed-by: Arnd Bergmann