From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B5C3C433F5 for ; Wed, 9 Feb 2022 19:29:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235012AbiBIT3M (ORCPT ); Wed, 9 Feb 2022 14:29:12 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:46708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236113AbiBIT2F (ORCPT ); Wed, 9 Feb 2022 14:28:05 -0500 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F01AE00ED68 for ; Wed, 9 Feb 2022 11:26:42 -0800 (PST) Received: by mail-io1-xd2b.google.com with SMTP id r144so4520709iod.9 for ; Wed, 09 Feb 2022 11:26:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=uJdZ7oqw+QQlIzr17qqdwzwfregbqFYC9sj7YzP1HYY=; b=fYz8PGQMd29UOajQhZT2X83HUOpYoErPoGjRcNCM4yVnITAfRZgeDe7UMSvRLFe4oS 1k0WRleLPHEuUfcf6Ia64xTw2nV6RRaWj+2NboS6Cc4j+5N0sOvshg1GvERuJ5jICtiI eslZtJUanhs7SqaFUnbPEbDHd79D+9p9fHxms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uJdZ7oqw+QQlIzr17qqdwzwfregbqFYC9sj7YzP1HYY=; b=Y7qS7KoOPt1G2hQlNd+39+uSDQgo2ViwCkGU+EySQVDiqo4LGZ8V3s4UfhkjspsXHf pVpYVIqXeX8EX7yB9ngu3OQO6yy/Pqeyv419HPjnpthXn5jkVhxcC2FgVHbaTen84DzR Ri/TigtqS47cI0y01xyyLSGRYXu9PrSgbAcvIezFGyk3NoKc67WV2h0UQMjrlRljFrcr dp1V8Tn2IXWxXZme+4FkzHiBpwaUcLwNnv2eUnZKlBl12draIJANAUXU9QQLpwlXrG7e egzCDd3v5KC7WCJtaAzbCbKZlpfCDlrMTAkKbn3Hq8VG3/S7UrqD7eYGK6+LpVS4u5aU u9ww== X-Gm-Message-State: AOAM532VNzp/HGn4eenv6arJgma6UaiC6B9XvbfYEaPIqOw2EftiZl5k L+Z+17z5TfYjwvMr3SpNlhAJsQ== X-Google-Smtp-Source: ABdhPJw5MU53uJwqzrLtiF140G+vIQQ1qVQ9YiU1UrUUC9dzqLmlqHS4jlfDiPOVYXjgDYKvgAj0iA== X-Received: by 2002:a6b:6f09:: with SMTP id k9mr1864423ioc.61.1644434801604; Wed, 09 Feb 2022 11:26:41 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id o22sm9992022iow.37.2022.02.09.11.26.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Feb 2022 11:26:41 -0800 (PST) Subject: Re: [PATCH] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT To: Krzysztof Kozlowski , Steven Rostedt , Ingo Molnar , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, joseph.salisbury@canonical.com, Shuah Khan References: <20220209162430.286578-1-krzysztof.kozlowski@canonical.com> From: Shuah Khan Message-ID: Date: Wed, 9 Feb 2022 12:26:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220209162430.286578-1-krzysztof.kozlowski@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/9/22 9:24 AM, Krzysztof Kozlowski wrote: > The PREEMPT_RT patchset does not use soft IRQs thus trying to filter for > do_softirq fails for such kernel: > > echo do_softirq > ftracetest: 81: echo: echo: I/O error > > Choose some other externally visible function for the test. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I understand that the failure does not exist on mainline kernel (only > with PREEMPT_RT patchset) but the change does not harm it. > > If it is not suitable alone, please consider it for RT patchset. > --- > .../selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc > index e96e279e0533..1d0c7601865f 100644 > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc > @@ -19,7 +19,7 @@ fail() { # mesg > > FILTER=set_ftrace_filter > FUNC1="schedule" > -FUNC2="do_softirq" > +FUNC2="_printk" > > ALL_FUNCS="#### all functions enabled ####" > > Change looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah