From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 910B43EDAB0 for ; Tue, 5 May 2026 13:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777987713; cv=none; b=V7Radqbo5eQRI5YFtdhUfqFGTtUkaJzGQc8p7u/udw2tZDdilY9PJS5rHanEsSRjjg3B6OJhkstZ78/hHPPzwSoXXdNq3oBFyHVCMpb0xQA2fizNph5mAf7Pyb6WlRcr339urLGpwhLibz72n8DdfERDsYFiJBci6VjK+5fr00o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777987713; c=relaxed/simple; bh=x5TgU5SBySfoeXKBw0QL6h3y9dq2clju9sczVk0IMPQ=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=GxHus7MuTy7VBwmBUfgnPa7NtxW3gEvvqnufRrx4s1ZRJAXubTRjz0Np18g7l1sEXJno4XGWTMOt4lgCFeKOLWmkRyzo30kpJNX3GwKnZ0a4FdRHAoaVggO2EnGP3vrhmt5RlwCtiroDkLBuvNvtEpkQQ98ACO9S1OJqISliuZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ovn.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.218.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ovn.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f68.google.com with SMTP id a640c23a62f3a-b936331786dso623410766b.3 for ; Tue, 05 May 2026 06:28:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777987710; x=1778592510; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:cc:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DCXgMseI2sOZrSwXLdW2jyT6y6fLj2BxLcRv5Mj/3pc=; b=T9dzh1XYGEgIV+1tgbBmDNhLBzOIaIoH1rxWfUQSiFidSsc57jjZYOa/yn+89UgcbD AZ1qe7EvQk+VM0gnUQRN3yhCSdtXfdkVb/hCl5RhNLARHVugqDz1giaQ7aqGofAz72Yn ZimY9Cy0JcxvjaDK8kmXEoMTXuTTrkf2A3ga6GP+GXaDdAAm7bCAZCCyzWBumm8o0pZ/ 00SZ/WScVtBEjuyVKHlha9DVjlxEusT1+J43Ywga/IrrUPRhIX98jjCKx4BmNSaYt98E UxFfwn3fVHH8ioFEDPcuXrEs8wIfPOgloSJPt0slRxsHYx5DONWUJsBiopzo91DHaAF3 nrBQ== X-Forwarded-Encrypted: i=1; AFNElJ8CLoPzxxZP0RTbNYsKsWXLntQQcZ7/3VZtjY3LJczFFnOobXiPNnnTXE1GUuHSrv9y36w9RzE5S+GZQD0=@vger.kernel.org X-Gm-Message-State: AOJu0YwLYKGns0GolUan76ZBhuO8/OAaMgftrCpww6gVKEKet/n+qpo9 M+OMr3XrikxS8WtxEbXyrKzu6JG7K7yM1RNcEQu3Z7nnU2A0baLSFV4f X-Gm-Gg: AeBDiesBH6TzH7VMsZFwFkNxVp9ky80gm/ZZC39XALM5yOWTiQQg+tZ9FP73/bLhovB itygeNYNDtoA/07Gf8Qu6ckn59iP3yMVqjETknbXY/WMO73ZRCvjmAMJlYBgPARGF2eJz+ujXq3 SxqtnyeiQQaXPALBEErCQh8RaUb2hswHnjAU5hRtJSw0qUcaq82JPC9Hn3fkj9UxdZFn9iXC562 n4NWVXQaRRoh9kHfjwuItxbbJO2qx0xkJzUEmwLBnVt9jmyWAQ321cbLu3caGC4VAGx2/XkF8Kk cQN6NKUzXyXOoV4DgbZTqvMmlCvMmHBTEvMDs7F8Z5rR7PF8ABFGkqwGkoPSFvkocPbpOMZYqt6 qc5Y1jux1G/04dnGA2WjSdOVaj2ZEGoYbzv6jFD10wc2JtKzkoBAIo5ePns0UCkXjx32TmMb/mO ggl4SeBa8QC3G15V7rCUXdR9n2Zptxpz8VVZJV6dkG7YW/4yQ2c7zcLn05t30LMlqBUA== X-Received: by 2002:a17:906:eec1:b0:ba8:28de:697 with SMTP id a640c23a62f3a-bbff8ed484fmr782134566b.9.1777987709601; Tue, 05 May 2026 06:28:29 -0700 (PDT) Received: from [192.168.88.241] (37-48-40-237.nat.epc.tmcz.cz. [37.48.40.237]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bc17f1eea7asm263903966b.58.2026.05.05.06.28.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 06:28:29 -0700 (PDT) Message-ID: Date: Tue, 5 May 2026 15:28:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: i.maximets@ovn.org, Aaron Conole , Eelco Chaudron , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Shuah Khan , Yuan Tan , Yang Yang , dev@openvswitch.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net v2 2/2] selftests: openvswitch: add tests for tunnel vport refcounting To: Paolo Abeni , netdev@vger.kernel.org References: <20260430233848.440994-1-i.maximets@ovn.org> <20260430233848.440994-3-i.maximets@ovn.org> <0f5da49c-7ed6-4547-9f89-bb3c3d62c3c3@redhat.com> Content-Language: en-US From: Ilya Maximets Autocrypt: addr=i.maximets@ovn.org; keydata= xsFNBF77bOMBEADVZQ4iajIECGfH3hpQMQjhIQlyKX4hIB3OccKl5XvB/JqVPJWuZQRuqNQG /B70MP6km95KnWLZ4H1/5YOJK2l7VN7nO+tyF+I+srcKq8Ai6S3vyiP9zPCrZkYvhqChNOCF pNqdWBEmTvLZeVPmfdrjmzCLXVLi5De9HpIZQFg/Ztgj1AZENNQjYjtDdObMHuJQNJ6ubPIW cvOOn4WBr8NsP4a2OuHSTdVyAJwcDhu+WrS/Bj3KlQXIdPv3Zm5x9u/56NmCn1tSkLrEgi0i /nJNeH5QhPdYGtNzPixKgPmCKz54/LDxU61AmBvyRve+U80ukS+5vWk8zvnCGvL0ms7kx5sA tETpbKEV3d7CB3sQEym8B8gl0Ux9KzGp5lbhxxO995KWzZWWokVUcevGBKsAx4a/C0wTVOpP FbQsq6xEpTKBZwlCpxyJi3/PbZQJ95T8Uw6tlJkPmNx8CasiqNy2872gD1nN/WOP8m+cIQNu o6NOiz6VzNcowhEihE8Nkw9V+zfCxC8SzSBuYCiVX6FpgKzY/Tx+v2uO4f/8FoZj2trzXdLk BaIiyqnE0mtmTQE8jRa29qdh+s5DNArYAchJdeKuLQYnxy+9U1SMMzJoNUX5uRy6/3KrMoC/ 7zhn44x77gSoe7XVM6mr/mK+ViVB7v9JfqlZuiHDkJnS3yxKPwARAQABzSJJbHlhIE1heGlt ZXRzIDxpLm1heGltZXRzQG92bi5vcmc+wsGUBBMBCAA+AhsDBQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAFiEEh+ma1RKWrHCY821auffsd8gpv5YFAmfB9JAFCQyI7q0ACgkQuffsd8gpv5YQ og/8DXt1UOznvjdXRHVydbU6Ws+1iUrxlwnFH4WckoFgH4jAabt25yTa1Z4YX8Vz0mbRhTPX M/j1uORyObLem3of4YCd4ymh7nSu++KdKnNsZVHxMcoiic9ILPIaWYa8kTvyIDT2AEVfn9M+ vskM0yDbKa6TAHgr/0jCxbS+mvN0ZzDuR/LHTgy3e58097SWJohj0h3Dpu+XfuNiZCLCZ1/G AbBCPMw+r7baH/0evkX33RCBZwvh6tKu+rCatVGk72qRYNLCwF0YcGuNBsJiN9Aa/7ipkrA7 Xp7YvY3Y1OrKnQfdjp3mSXmknqPtwqnWzXvdfkWkZKShu0xSk+AjdFWCV3NOzQaH3CJ67NXm aPjJCIykoTOoQ7eEP6+m3WcgpRVkn9bGK9ng03MLSymTPmdINhC5pjOqBP7hLqYi89GN0MIT Ly2zD4m/8T8wPV9yo7GRk4kkwD0yN05PV2IzJECdOXSSStsf5JWObTwzhKyXJxQE+Kb67Wwa LYJgltFjpByF5GEO4Xe7iYTjwEoSSOfaR0kokUVM9pxIkZlzG1mwiytPadBt+VcmPQWcO5pi WxUI7biRYt4aLriuKeRpk94ai9+52KAk7Lz3KUWoyRwdZINqkI/aDZL6meWmcrOJWCUMW73e 4cMqK5XFnGqolhK4RQu+8IHkSXtmWui7LUeEvO/OwU0EXvts4wEQANCXyDOic0j2QKeyj/ga OD1oKl44JQfOgcyLVDZGYyEnyl6b/tV1mNb57y/YQYr33fwMS1hMj9eqY6tlMTNz+ciGZZWV YkPNHA+aFuPTzCLrapLiz829M5LctB2448bsgxFq0TPrr5KYx6AkuWzOVq/X5wYEM6djbWLc VWgJ3o0QBOI4/uB89xTf7mgcIcbwEf6yb/86Cs+jaHcUtJcLsVuzW5RVMVf9F+Sf/b98Lzrr 2/mIB7clOXZJSgtV79Alxym4H0cEZabwiXnigjjsLsp4ojhGgakgCwftLkhAnQT3oBLH/6ix 87ahawG3qlyIB8ZZKHsvTxbWte6c6xE5dmmLIDN44SajAdmjt1i7SbAwFIFjuFJGpsnfdQv1 OiIVzJ44kdRJG8kQWPPua/k+AtwJt/gjCxv5p8sKVXTNtIP/sd3EMs2xwbF8McebLE9JCDQ1 RXVHceAmPWVCq3WrFuX9dSlgf3RWTqNiWZC0a8Hn6fNDp26TzLbdo9mnxbU4I/3BbcAJZI9p 9ELaE9rw3LU8esKqRIfaZqPtrdm1C+e5gZa2gkmEzG+WEsS0MKtJyOFnuglGl1ZBxR1uFvbU VXhewCNoviXxkkPk/DanIgYB1nUtkPC+BHkJJYCyf9Kfl33s/bai34aaxkGXqpKv+CInARg3 fCikcHzYYWKaXS6HABEBAAHCwXwEGAEIACYCGwwWIQSH6ZrVEpascJjzbVq59+x3yCm/lgUC Z8H0qQUJDIjuxgAKCRC59+x3yCm/loAdD/wJCOhPp9711J18B9c4f+eNAk5vrC9Cj3RyOusH Hebb9HtSFm155Zz3xiizw70MSyOVikjbTocFAJo5VhkyuN0QJIP678SWzriwym+EG0B5P97h FSLBlRsTi4KD8f1Ll3OT03lD3o/5Qt37zFgD4mCD6OxAShPxhI3gkVHBuA0GxF01MadJEjMu jWgZoj75rCLG9sC6L4r28GEGqUFlTKjseYehLw0s3iR53LxS7HfJVHcFBX3rUcKFJBhuO6Ha /GggRvTbn3PXxR5UIgiBMjUlqxzYH4fe7pYR7z1m4nQcaFWW+JhY/BYHJyMGLfnqTn1FsIwP dbhEjYbFnJE9Vzvf+RJcRQVyLDn/TfWbETf0bLGHeF2GUPvNXYEu7oKddvnUvJK5U/BuwQXy TRFbae4Ie96QMcPBL9ZLX8M2K4XUydZBeHw+9lP1J6NJrQiX7MzexpkKNy4ukDzPrRE/ruui yWOKeCw9bCZX4a/uFw77TZMEq3upjeq21oi6NMTwvvWWMYuEKNi0340yZRrBdcDhbXkl9x/o skB2IbnvSB8iikbPng1ihCTXpA2yxioUQ96Akb+WEGopPWzlxTTK+T03G2ljOtspjZXKuywV Wu/eHyqHMyTu8UVcMRR44ki8wam0LMs+fH4dRxw5ck69AkV+JsYQVfI7tdOu7+r465LUfg== In-Reply-To: <0f5da49c-7ed6-4547-9f89-bb3c3d62c3c3@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/5/26 3:25 PM, Paolo Abeni wrote: > On 5/1/26 1:38 AM, Ilya Maximets wrote: >> @@ -830,6 +831,42 @@ test_tunnel_metadata() { >> return 0 >> } >> >> +test_tunnel_refcount() { >> + sbxname="test_tunnel_refcount" >> + sbx_add "${sbxname}" || return 1 >> + >> + ovs_sbx "${sbxname}" ip netns add trefns || return 1 >> + on_exit "ovs_sbx ${sbxname} ip netns del trefns" >> + >> + for tun_type in gre vxlan geneve; do >> + info "testing ${tun_type} tunnel vport refcount" >> + >> + ovs_sbx "${sbxname}" ip netns exec trefns \ >> + python3 $ovs_base/ovs-dpctl.py \ >> + add-dp dp-${tun_type} || return 1 >> + >> + ovs_sbx "${sbxname}" ip netns exec trefns \ >> + python3 $ovs_base/ovs-dpctl.py \ >> + add-if --no-lwt -t ${tun_type} \ >> + dp-${tun_type} ovs-${tun_type}0 || return 1 >> + >> + ovs_wait ip -netns trefns link show \ >> + ovs-${tun_type}0 >/dev/null 2>&1 || return 1 >> + >> + info "deleting dp - may hang if reference counting is broken" >> + ovs_sbx "${sbxname}" ip netns exec trefns \ >> + python3 $ovs_base/ovs-dpctl.py \ >> + del-dp dp-${tun_type} & >> + >> + dev_removed() { >> + ! ip -netns trefns link show "$1" >/dev/null 2>&1 >> + } >> + ovs_wait dev_removed dp-${tun_type} || return 1 >> + ovs_wait dev_removed ovs-${tun_type}0 || return 1 > > FTR, here sashiko laments that if the reference counting is broken and > the del-dp process hangs, this could leave the background del-dp python > process running indefinitely. > > I guess that if reference counting is broken inside the kernel, very > likely an host/VM reboot is needed, and the above does not matter. Yes, I have a note about that in the cover letter.