mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Gary Guo <gary@garyguo.net>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	linux-pm@vger.kernel.org, rust-for-linux@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rust: cpufreq: fix clippy::double_parens warning in Policy doctest
Date: Wed, 4 Mar 2026 12:34:17 -0800	[thread overview]
Message-ID: <aa0ab485-3289-4238-b730-5ea2d6d5a06e@nvidia.com> (raw)
In-Reply-To: <DGUA6UMYDGG9.1AA0FD146PS3K@garyguo.net>

On 3/4/26 12:30 PM, Gary Guo wrote:
> On Wed Mar 4, 2026 at 7:53 PM GMT, John Hubbard wrote:
>> Clippy reports:
>>     warning: consider removing unnecessary double parentheses
>>       --> rust/kernel/cpufreq.rs:410:60
>>        |
>>    410 |     pr_info!("The policy details are: {:?}\n", (policy.cpu(), policy.cur()));
>>        |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
> 
> This looks like a Clippy bug that's fixed in latest Clippy:
> 
> https://github.com/rust-lang/rust-clippy/pull/15939
> 

Looks like it, yes. I'm using the 1.78 toolchain because it is
the oldest and we are supposed to verify that builds work with
the oldest:

<blueforge> linux-github (fix-clippy-double-parens-v2)$ clippy-driver --version
clippy 0.1.78 (9b00956 2024-04-29)

<blueforge> linux-github (fix-clippy-double-parens-v2)$ rustup which clippy-driver
/home/jhubbard/.rustup/toolchains/1.78.0-x86_64-unknown-linux-gnu/bin/clippy-driver

I'm not sure if this means we should workaround the problem or not.

thanks,
-- 
John Hubbard


      reply	other threads:[~2026-03-04 20:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 19:53 John Hubbard
2026-03-04 20:06 ` Gary Guo
2026-03-04 20:07   ` John Hubbard
2026-03-04 20:28     ` Gary Guo
2026-03-04 20:32       ` John Hubbard
2026-03-04 20:39       ` Gary Guo
2026-03-04 21:13         ` John Hubbard
2026-03-05 12:31           ` Gary Guo
2026-03-06 12:36             ` Miguel Ojeda
2026-03-07 17:09               ` [RFC PATCH] rust: kbuild: support global per-version flags Miguel Ojeda
2026-03-15 21:21                 ` Miguel Ojeda
2026-03-15 21:22                   ` Miguel Ojeda
2026-03-16  0:04                   ` Mark Brown
2026-03-16  4:49                     ` Miguel Ojeda
2026-03-16 12:50                       ` Mark Brown
2026-03-16 12:31                         ` Danilo Krummrich
2026-03-16 13:42                         ` Miguel Ojeda
2026-03-04 20:30 ` [PATCH] rust: cpufreq: fix clippy::double_parens warning in Policy doctest Gary Guo
2026-03-04 20:34   ` John Hubbard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa0ab485-3289-4238-b730-5ea2d6d5a06e@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome