From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753592AbdHVTWm (ORCPT ); Tue, 22 Aug 2017 15:22:42 -0400 Received: from gateway24.websitewelcome.com ([192.185.50.84]:48180 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752875AbdHVTWk (ORCPT ); Tue, 22 Aug 2017 15:22:40 -0400 Subject: Re: [PATCH v2] venus: fix copy/paste error in return_buf_error To: Stanimir Varbanov , Stanimir Varbanov , Hans Verkuil , Mauro Carvalho Chehab References: <20170818160719.GA4899@embeddedgus> Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Message-ID: Date: Tue, 22 Aug 2017 14:22:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.158.27 X-Exim-ID: 1dkEl6-002XmN-5i X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.70]) [189.152.158.27]:46648 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 13 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/21/2017 04:14 AM, Stanimir Varbanov wrote: > Thanks Gustavo! > Glad to help. :) > On 08/18/2017 07:07 PM, Gustavo A. R. Silva wrote: >> Call function v4l2_m2m_dst_buf_remove_by_buf() instead of >> v4l2_m2m_src_buf_remove_by_buf() >> >> Addresses-Coverity-ID: 1415317 >> Cc: Stanimir Varbanov >> Cc: Hans Verkuil >> Signed-off-by: Gustavo A. R. Silva >> --- >> Changes in v2: >> Stanimir Varbanov confirmed this is a bug. The correct fix is to call >> function v4l2_m2m_dst_buf_remove_by_buf instead of function >> v4l2_m2m_src_buf_remove_by_buf in the _else_ branch. >> >> drivers/media/platform/qcom/venus/helpers.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Stanimir Varbanov > >> >> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c >> index 5f4434c..2d61879 100644 >> --- a/drivers/media/platform/qcom/venus/helpers.c >> +++ b/drivers/media/platform/qcom/venus/helpers.c >> @@ -243,7 +243,7 @@ static void return_buf_error(struct venus_inst *inst, >> if (vbuf->vb2_buf.type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) >> v4l2_m2m_src_buf_remove_by_buf(m2m_ctx, vbuf); >> else >> - v4l2_m2m_src_buf_remove_by_buf(m2m_ctx, vbuf); >> + v4l2_m2m_dst_buf_remove_by_buf(m2m_ctx, vbuf); >> >> v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_ERROR); >> } >> > -- Gustavo A. R. Silva