From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9638C433C1 for ; Tue, 30 Mar 2021 18:49:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A76B6192C for ; Tue, 30 Mar 2021 18:49:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232916AbhC3Ssq (ORCPT ); Tue, 30 Mar 2021 14:48:46 -0400 Received: from smtprelay0076.hostedemail.com ([216.40.44.76]:39256 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232901AbhC3Ssi (ORCPT ); Tue, 30 Mar 2021 14:48:38 -0400 Received: from omf18.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 1A328181D337B; Tue, 30 Mar 2021 18:48:37 +0000 (UTC) Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA id 0B1202EBFA0; Tue, 30 Mar 2021 18:48:35 +0000 (UTC) Message-ID: Subject: [PATCH] checkpatch: Warn when missing newline in return sysfs_emit() formats From: Joe Perches To: Andrew Morton , Andy Whitcroft Cc: Tomas Winkler , Greg KH , LKML Date: Tue, 30 Mar 2021 11:48:34 -0700 Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: gtk9ypfu7oa15o3ox1on1zkwumj79y3y X-Rspamd-Server: rspamout05 X-Rspamd-Queue-Id: 0B1202EBFA0 X-HE-Tag: 1617130115-666885 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org return sysfs_emit() uses should include a newline. Suggest adding a newline when one is missing. Add one using --fix too. Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d67146d0b33c..4dbda85fd7e5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -7198,6 +7198,17 @@ sub process { "Using $1 should generally have parentheses around the comparison\n" . $herecurr); } +# return sysfs_emit(foo, fmt, ...) fmt without newline + if ($line =~ /\breturn\s+sysfs_emit\s*\(\s*$FuncArg\s*,\s*($String)/ && + substr($rawline, $-[6], $+[6] - $-[6]) !~ /\\n"$/) { + my $offset = $+[6] - 1; + if (WARN("SYSFS_EMIT", + "return sysfs_emit(...) formats should include a terminating newline\n" . $herecurr) && + $fix) { + substr($fixed[$fixlinenr], $offset, 0) = '\\n'; + } + } + # nested likely/unlikely calls if ($line =~ /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) { WARN("LIKELY_MISUSE",