From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Christian Loehle <christian.loehle@arm.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
"Mario Limonciello" <mario.limonciello@amd.com>
Cc: "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
Perry Yuan <perry.yuan@amd.com>, Huang Rui <ray.huang@amd.com>,
Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] cpufreq/amd-pstate register write fixes
Date: Fri, 30 Oct 2026 08:41:18 +0530 [thread overview]
Message-ID: <aa198417-036a-4531-b8e8-6cb9c4809d2d@amd.com> (raw)
In-Reply-To: <20261029121945.854675-1-christian.loehle@arm.com>
Hello Chris,
On 10/29/2026 5:49 PM, Christian Loehle wrote:
> Two issues that popped up when trying to integrate an AMD machine into
> my testing for acpi-cppc, in particular for this (otherwise
> unrelated) patch:
> https://lore.kernel.org/lkml/20261020121846.691218-2-sumitg@nvidia.com/
>
> The first is rather straightforward, I think the case was just not
> considered during the refactor of the Fixes commit.
> The second is part of the resume handling and was introduced when
> that restored the register values (DESIRED derived from policy->cur).
> My platform seems to handle it well, but it's still strange
> behaviour, so why not fix it.
> (Also of course the resume value will generally be overwritten and
> therefore 'fixed' anyway.)
Thank you for catching them. For the whole series, feel free to include:
Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>
Tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
--
Thanks and Regards,
Prateek
prev parent reply other threads:[~2026-10-30 3:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 12:19 Christian Loehle
2026-10-29 12:19 ` [PATCH 1/2] cpufreq/amd-pstate: Keep minimum requests within policy limits Christian Loehle
2026-10-29 12:19 ` [PATCH 2/2] cpufreq/amd-pstate: Clamp desired perf on resume Christian Loehle
2026-10-29 19:35 ` [PATCH 0/2] cpufreq/amd-pstate register write fixes Mario Limonciello
2026-10-30 3:11 ` K Prateek Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa198417-036a-4531-b8e8-6cb9c4809d2d@amd.com \
--to=kprateek.nayak@amd.com \
--cc=Dhananjay.Ugwekar@amd.com \
--cc=christian.loehle@arm.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perry.yuan@amd.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®