From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E99C3033F5 for ; Tue, 28 Apr 2026 16:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395248; cv=none; b=EeyDLs2BMY8TD9J1VtxZFTNEPOnTk9baItKHC+cFIswffrq3VKLKDRJGit3/sCI1420FvysjgRfkNLQbtmreTT+RkgtlmvLbMYeKcFbdVRXotKGs5N+Dyy4tlMp2UHVqeSzAaRbgbxildoHVbWbx76hPWTpj1HLzegekg40JGrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395248; c=relaxed/simple; bh=rzWf/oQSHbkLcV8GwzpmrSWI0KfR0fCQpV3xi0rt5Og=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iWre81z6qo4OID1DImEoELcsN/Ug5D1uR3PDep8q1JP5er20aUI176ASRCbH50WLQ2gwiAcBw99iioMD6x+3+VLOAQMgtGaOF0eG37Kl+QfnEyTSvQh4Z8K7F54OCHKf/eQzw2JN4ivNHHVInlFhPwBPwEUCFd4OexYbJNYfnVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ieee.org; spf=pass smtp.mailfrom=ieee.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b=gVFY5SGd; arc=none smtp.client-ip=209.85.161.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ieee.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ieee.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b="gVFY5SGd" Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-6948da50eb5so14648eaf.1 for ; Tue, 28 Apr 2026 09:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1777395244; x=1778000044; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m3Z9r4IpEjJMUHPOqoRO6rW4qYst7QOqGLcntOF/K5A=; b=gVFY5SGdeZ2JrpdQhfBOXtmU5OBrbNQbhEkaFelzzC8oIWbT3S+tNOJrkfLM9fewnq Oh9d14toNjEhcJm8pUr4qhRqyuMFBdQBuJLymgs//dxzGjLfe2/k7B/8mJIT7/lci9eY lJMTxKnO9jwE194fEOlgT0QYHkmt9cDMVFPYQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777395244; x=1778000044; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m3Z9r4IpEjJMUHPOqoRO6rW4qYst7QOqGLcntOF/K5A=; b=Z61uHwdMMuP23XBc3d/eKr7Yo8CHXvYyAaAKv6ZqvvQSfF9dAJNASa8GSZfrP5GFcw cSch1o4pNT7aqOSp2necGI8cHuNZ6IylnFd9xTUO6NtRCCbyBwg4q1ROxC7+NgmStzFP gwBYz1nvXZNcjhH6JFmlI4T9Mboz3/gOW2/Id8PZ2Rqt/Q5AvQZ/XGU95kwjgXbQEoih N4KiIJOf58dmys5r2r9aC4Hs/gSxPyE06e/dgxpNd9P5i0CRnUn5NVGf6w5s+mSgcmtr nEtkhryNKsBpIBrz/F84n1bWSjkxA7s576cO1lYjoBcDt2ONatmrpfsuWKnGlaPIduio VTJg== X-Forwarded-Encrypted: i=1; AFNElJ+fXT5zZ7FodvDuuUlqxwsy5VFHBLgmyo4rSH6p5kSjNhCW8/FQf0634vmX6+PoF4IZKP4LbOfWlKKZGN0=@vger.kernel.org X-Gm-Message-State: AOJu0YxZmeddcuoSHPHJNMIlBtnm9ohjLfXF5nr2I5fhrd3elaQaBeQ2 Rdpwkobf89Vr9TM90hHinh2W/BXPS4JbgmqgCK/yuhZKUw8M00yT/8MLhFmvXIb8ew== X-Gm-Gg: AeBDievdGIR+iGlYwC3tAVY4n01VO6lLfrfYem5nD/VTgInYSV8NpkbUzTdRXXLyWF0 0v/OC311IQjIZdTr4vhcr6p/RGwQAMDYWqJeulJgOAGUq77XQzHz2lDoIdyLM5hdcFkigaxsFea wRMLJg7tRnF31lNQfjmP3axFPAXk4a7lwlGHrpDQxCDG+h1iqMpuUyHUsVt2Bs79MO9ni4nhjPD cTeL3962H9QF3KqDJzIFXR415xh07VMzQSMHRL4uqDOz/ppBr6pmzRvQl/x0PlY1btZtWNxR1yK Cwfcjzwgo2HYYXyqW70g2xQ5+WsYGD+6ilDQWkHb2k9+09nWMQM/pONvrpxYV/l+ulQhjS8tNZ+ sKbtFUp2PUt6JY34DUgaARorBx4zPzVbVz2OEClqczRHUyj5fTM8R9HlbywxzeLBMYn3brM2mQY LENWBq5hHWQNt4q7+r44pzVjMVSD5QCIcIiZ5q6oGHAgeLqajvZEl9w7DPYC5o5ljOcQrp07D+7 RRynKs= X-Received: by 2002:a05:6820:4b05:b0:696:13e9:6863 with SMTP id 006d021491bc7-6965c5ee294mr1871158eaf.2.1777395244239; Tue, 28 Apr 2026 09:54:04 -0700 (PDT) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-433effdc79bsm2240677fac.18.2026.04.28.09.54.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 09:54:03 -0700 (PDT) Message-ID: Date: Tue, 28 Apr 2026 11:54:00 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/15] net: ipa: Switch to generic PAS TZ APIs To: Sumit Garg , andersson@kernel.org, konradybcio@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg References: <20260427095603.1157963-1-sumit.garg@kernel.org> <20260427095603.1157963-13-sumit.garg@kernel.org> Content-Language: en-US From: Alex Elder In-Reply-To: <20260427095603.1157963-13-sumit.garg@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/27/26 4:56 AM, Sumit Garg wrote: > From: Sumit Garg > > Switch ipa client driver over to generic PAS TZ APIs. Generic PAS TZ > service allows to support multiple TZ implementation backends like QTEE > based SCM PAS service, OP-TEE based PAS service and any further future TZ > backend service. > > Signed-off-by: Sumit Garg Looks good to me. Reviewed-by: Alex Elder > --- > drivers/net/ipa/Kconfig | 2 +- > drivers/net/ipa/ipa_main.c | 13 ++++++++----- > 2 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig > index 01d219d3760c..a9aff1b7977d 100644 > --- a/drivers/net/ipa/Kconfig > +++ b/drivers/net/ipa/Kconfig > @@ -6,7 +6,7 @@ config QCOM_IPA > depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) > depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n > select QCOM_MDT_LOADER > - select QCOM_SCM > + select QCOM_PAS > select QCOM_QMI_HELPERS > help > Choose Y or M here to include support for the Qualcomm > diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c > index 788dd99af2a4..3cd9e44680e9 100644 > --- a/drivers/net/ipa/ipa_main.c > +++ b/drivers/net/ipa/ipa_main.c > @@ -14,7 +14,7 @@ > #include > #include > > -#include > +#include > #include > > #include "ipa.h" > @@ -624,10 +624,13 @@ static int ipa_firmware_load(struct device *dev) > } > > ret = qcom_mdt_load(dev, fw, path, IPA_PAS_ID, virt, phys, size, NULL); > - if (ret) > + if (ret) { > dev_err(dev, "error %d loading \"%s\"\n", ret, path); > - else if ((ret = qcom_scm_pas_auth_and_reset(IPA_PAS_ID))) > - dev_err(dev, "error %d authenticating \"%s\"\n", ret, path); > + } else { > + ret = qcom_pas_auth_and_reset(IPA_PAS_ID); > + if (ret) > + dev_err(dev, "error %d authenticating \"%s\"\n", ret, path); > + } > > memunmap(virt); > out_release_firmware: > @@ -758,7 +761,7 @@ static enum ipa_firmware_loader ipa_firmware_loader(struct device *dev) > return IPA_LOADER_INVALID; > out_self: > /* We need Trust Zone to load firmware; make sure it's available */ > - if (qcom_scm_is_available()) > + if (qcom_pas_is_available()) > return IPA_LOADER_SELF; > > return IPA_LOADER_DEFER;