From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752295AbeDIIkP (ORCPT ); Mon, 9 Apr 2018 04:40:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46680 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbeDIIkN (ORCPT ); Mon, 9 Apr 2018 04:40:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8EF3960540 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tdas@codeaurora.org Subject: Re: [PATCH 2/3] clk: qcom: gdsc: Add support to poll for higher timeout value To: Stephen Boyd , Michael Turquette , Stephen Boyd Cc: Andy Gross , David Brown , Rajendra Nayak , Odelu Kukatla , Amit Nischal , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <1522665945-28147-1-git-send-email-tdas@codeaurora.org> <1522665945-28147-3-git-send-email-tdas@codeaurora.org> <152297065260.143116.4250583205921081457@swboyd.mtv.corp.google.com> From: Taniya Das Message-ID: Date: Mon, 9 Apr 2018 14:10:06 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <152297065260.143116.4250583205921081457@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Stephen, Thanks for the review comments. On 4/6/2018 4:54 AM, Stephen Boyd wrote: > Quoting Taniya Das (2018-04-02 03:45:44) >> From: Amit Nischal >> >> For some gdscs, it might take longer time up to 500us for >> updating their status. So add support for the same by >> defining a new flag 'GDS_TIMEOUT' to mark such gdsc in >> order to poll their status for longer timeout value. >> >> Signed-off-by: Amit Nischal >> Signed-off-by: Taniya Das >> --- > > Let's just increase the timeout to 500 if it's required? This is a > timeout, so we're not really expecting to hit it anyway so optimizing > the uncommon case is not useful. > -- Will fix this in the next series. > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation. --