From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 660F83F870E for ; Thu, 28 May 2026 18:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779992525; cv=none; b=kiFA0fME/oxLzgQV9YnaVWT1SPfEHb7PGzf0jwTnXjxsTLl4W3YnWDXLM8SIcTAdMBXUmLQAbBECkduejaUF6YfvqkbhBYummKLXtFc7IaH0OPgus+lF63w4T8oAhZFkt0RuLMLSgg8svINhgE0h7p18nTa4h6moC1ecHuS2dyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779992525; c=relaxed/simple; bh=MJ5qF671dc/eeaBWYfH5arIf631VPhhnj+1/wPlE+T0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=NbFhB1VQrG/LQQI5PvdTNB2TlQv2I8zgOUlnusAelgDZal0N20XAV2ccSAZX+V1mdgMYvmqqWFZuZjNQtbgmQxWWhDgEC6OoSNF3kfktiQOXb5o7oUUA4KXDMMcVwsnTU1Z2hcohxWR2e25zbqADAhw83QqfBHXKZTP1I+0HMpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iNm4Xosb; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Pv1vmzz+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iNm4Xosb"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Pv1vmzz+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779992522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MJ5qF671dc/eeaBWYfH5arIf631VPhhnj+1/wPlE+T0=; b=iNm4Xosb38PWn0kGpymw1MRX+VNye5mzT5Y+UHP45EBA0U2rD3Byr8u92z1chf6PC7VtNA MJSJ2xVNr/55fPZZTgOfbY6HrP1lExzGvImL5V6LLiq0C3iXgG+yyps/9CzLkx0+lYwuLO 0hZ8XqPGroyZWtS/OVfSZRjineaZ2PQ= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-0Z2Al3cLNMSWpYJFaQQqYg-1; Thu, 28 May 2026 14:22:00 -0400 X-MC-Unique: 0Z2Al3cLNMSWpYJFaQQqYg-1 X-Mimecast-MFC-AGG-ID: 0Z2Al3cLNMSWpYJFaQQqYg_1779992520 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-914b616c670so816090885a.2 for ; Thu, 28 May 2026 11:22:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779992520; x=1780597320; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=MJ5qF671dc/eeaBWYfH5arIf631VPhhnj+1/wPlE+T0=; b=Pv1vmzz+vRriwnPczK+y8uv1wnsiqTP/62ETVpEHqSHzzRXeKsZ42PGt84jnVvL0XB KYtFgVCpdkKCmnYp8P4j9We5C+QBiwQPLtWmBtTpEIJKAgasWxxtsLcWR9lGxOapUIxp XEtOrFHUyL3+Ap4NW0DaWJKQZVkfEjqSbNACsRwva7nkM2mYkh4ZBMDuNsqilpj/Gaw5 aQ6IlcPVx1tyqWVnyCRinKmxMxPITyHBq0bB4wu1h/jqQ/qonpKsSmmh1VH0sGFmpK6z mTLWG8CsQ9cUq3LA90jpk+ZcctCgeq3blYvBf1FECvKROpVbynD/oIM67uoQOq7z54RY RF9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779992520; x=1780597320; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MJ5qF671dc/eeaBWYfH5arIf631VPhhnj+1/wPlE+T0=; b=pIMSQ/xPUPjYaMNtxuTeVLuPHVwTdPw7Ab3vb+Ij+t471crwCCYlc7JqoeMjHABoFd g2jlduxwW++4jEdsazxKoqsG6i4URJu2g4Jdk+fx3UWOGSkb2IIfOocjaN1tqxGwz0of 1REk0qfrRdEe7NLf44oxfsNFvICB9WZYj+fchvcteZIIRy9imrYHkrOQAHeuAZ5S4Gda P+1xwV7SUQoA0yH+r+Q01b2TsjU3pM9MLOdRgN6H72uynFdaKdpw98Ps6QlJminxDxE7 Cnu3CZvr/+23TuPQuxC4pnsS6x5qwmfeK7iTN0LF7wzh/t6Qiixx5/o31Sd2iTcrLlnJ u6hw== X-Forwarded-Encrypted: i=1; AFNElJ/nZYDxvmN+eZvaHPhVlo5SfTa6dnpPCCI+gYIs+qNeCfwTrQGTKm7ebVcsubjwJ+DupZ3Nvn270/ec6to=@vger.kernel.org X-Gm-Message-State: AOJu0YyDU6tMVD4nvOCpP1zWJ3WRcXvCtWDcvy1eTvWPwEQXWVexVmUH 7L1HrTvaAf2VrFPN7CeQeFqdYZRPTiZ+jhz5CQd+y4ulsYnUYm5V9pJonk5txETuBR339XKwLwp Aigx4+wKod4LkA/Semm76JZKYgfm6xTsdXIEZ4R34flYM7hBLk6yugOkieuyzlTuRHw== X-Gm-Gg: Acq92OFH1z/kG2c5DO8q9x5kmzECdk0y4BGjF/8PmEuDGXwDUQzIuFPKAq5/p2efSSh 6857qwvLwfgo/tHOxz6CQ6ecnmNY6zS6eLJR/y8teHmcsu6ckeJqADYQf5o3huCelZSEyz8PcAY BoiuXtor+AJDZAq02jebsmvi4YdrphuIYES/uTJbqGhEY7QkuJVJ1sQ+H7R5Ijw/luHOXttRLy3 QqLaZ2xg8G/DsEPE85Mz8UesiRyq7PeY8B3zGMq6evN2baseMZNm41FrH5rBoQ4B22kJSm89OsO 7G+Xhso0ck5/mO1cTnCAUB/DdiWlFwKg1L5jaCrqMWUgFyQ7kLALQ7fJ06b+pNXHyJqO/+ADZhf LLdOmSVc+mm4vzFNcKnx+ni9BFKsW X-Received: by 2002:a05:620a:40c6:b0:912:671b:d094 with SMTP id af79cd13be357-9152cef1054mr21224385a.31.1779992520039; Thu, 28 May 2026 11:22:00 -0700 (PDT) X-Received: by 2002:a05:620a:40c6:b0:912:671b:d094 with SMTP id af79cd13be357-9152cef1054mr21217285a.31.1779992519378; Thu, 28 May 2026 11:21:59 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f87d1cc0sm962062085a.26.2026.05.28.11.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 11:21:58 -0700 (PDT) Message-ID: Subject: Re: [PATCH 0/5] nouveau/gsp: Cleanup IS_ERR_OR_NULL() usage From: lyude@redhat.com To: Danilo Krummrich Cc: Hongling Zeng , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, airlied@redhat.com, ttabi@nvidia.com, bskeggs@nvidia.com, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhongling0719@126.com Date: Thu, 28 May 2026 14:21:57 -0400 In-Reply-To: References: <20260528062451.54107-1-zenghongling@kylinos.cn> <794dbd35fd81f03478cdd3238d3d506d0d800187.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Oh dear, thank you for catching this. Would you mind sending a revert and I can give an R-B and push it? On Thu, 2026-05-28 at 19:56 +0200, Danilo Krummrich wrote: > On Thu May 28, 2026 at 6:41 PM CEST, lyude wrote: > > Will push them to drm-misc in just a moment >=20 > [...] >=20 > > > =C2=A0 nouveau/gsp/rm: cleanup remaining IS_ERR_OR_NULL usage >=20 > I think at least this patch has to be reverted, it causes the > following oops > probing nouveau on my machine. >=20 > I can't currently look into this, but I think Sashiko [1] has a valid > point on > this one. >=20 > [1] > https://sashiko.dev/#/patchset/20260528062451.54107-1-zenghongling%40kyli= nos.cn >=20 > May 28 19:49:27 cassiopeiae kernel: BUG: kernel NULL pointer > dereference, address: 000000000000002c > May 28 19:49:27 cassiopeiae kernel: #PF: supervisor read access in > kernel mode > May 28 19:49:27 cassiopeiae kernel: #PF: error_code(0x0000) - not- > present page > May 28 19:49:27 cassiopeiae kernel: PGD 0 P4D 0 > May 28 19:49:27 cassiopeiae kernel: Oops: Oops: 0000 [#1] SMP NOPTI > May 28 19:49:27 cassiopeiae kernel: CPU: 12 UID: 0 PID: 475 Comm: > (udev-worker) Not tainted 7.1.0-rc5+ #14 PREEMPT(lazy) > May 28 19:49:27 cassiopeiae kernel: Hardware name: ASUS System > Product Name/TUF GAMING B850-E WIFI, BIOS 1627 02/05/2026 > May 28 19:49:27 cassiopeiae kernel: RIP: > 0010:r535_gsp_rpc_rm_ctrl_push+0x60/0x110 [nouveau] > May 28 19:49:27 cassiopeiae kernel: Code: 4c 8b 58 08 4c 89 f7 ba 02 > 00 00 00 89 e9 2e 2e 2e 41 ff d3 48 89 c6 48 3d 01 f0 ff ff 72 0b 48 > c7 03 00 00 00 00 89> > May 28 19:49:27 cassiopeiae kernel: RSP: 0018:ffffd3b38178f250 > EFLAGS: 00010213 > May 28 19:49:27 cassiopeiae kernel: RAX: 0000000000000020 RBX: > ffffd3b38178f2a0 RCX: 0000000000000000 > May 28 19:49:27 cassiopeiae kernel: RDX: 0000000000000038 RSI: > 0000000000000020 RDI: ffff8aa9db3339d8 > May 28 19:49:27 cassiopeiae kernel: RBP: 0000000000000000 R08: > ffffffffbe380560 R09: ffffffffc04c9300 > May 28 19:49:27 cassiopeiae kernel: R10: 0000000000000100 R11: > ffffffffbd66c070 R12: 0000000090f10000 > May 28 19:49:27 cassiopeiae kernel: R13: 0000000000000000 R14: > ffff8aa9db333000 R15: ffff8aa9e1c2d600 > May 28 19:49:27 cassiopeiae kernel: FS:=C2=A0 00007fb0623dc1c0(0000) > GS:ffff8ab15f8b9000(0000) knlGS:0000000000000000 > May 28 19:49:27 cassiopeiae kernel: CS:=C2=A0 0010 DS: 0000 ES: 0000 CR0: > 0000000080050033 > May 28 19:49:27 cassiopeiae kernel: CR2: 000000000000002c CR3: > 000000011efcc000 CR4: 0000000000f50ef0 > May 28 19:49:27 cassiopeiae kernel: PKRU: 55555554 > May 28 19:49:27 cassiopeiae kernel: Call Trace: > May 28 19:49:27 cassiopeiae kernel:=C2=A0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 r535_mmu_vaspace_new+0x1f8/0x52= 0 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 nvkm_uvmm_new+0x1b7/0x210 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 nvkm_ioctl_new+0x22d/0x340 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? nvkm_uvmm_search+0x30/0x30 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 nvkm_ioctl+0xf7/0x1f0 [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 nvif_object_ctor+0x134/0x2b0 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? nvkm_uvmm_search+0x30/0x30 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? __kmalloc_noprof+0x205/0x550 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? nvif_vmm_ctor+0x65/0x280 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 nvif_vmm_ctor+0xe5/0x280 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 nouveau_vmm_init+0x3b/0x50 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 nouveau_cli_init+0x25f/0x450 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 > nouveau_drm_device_init+0x69/0x840 [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? > pci_bus_read_config_word+0x4b/0x80 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 nouveau_drm_probe+0xc7/0x190 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 pci_device_probe+0x1f9/0x300 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 really_probe+0x1b8/0x480 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 __driver_probe_device+0x9d/0x13= 0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 driver_probe_device+0x1e/0x100 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 __driver_attach+0xab/0x210 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? driver_attach+0x20/0x20 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 bus_for_each_dev+0x10b/0x150 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 bus_add_driver+0x184/0x2d0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 driver_register+0x61/0xf0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 init_module+0x1bd/0x1000 > [nouveau] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? cleanup_module+0x2e0/0x2e0 > [video] > May 28 19:49:27 cassiopeiae kernel:=C2=A0 do_one_initcall+0x12e/0x350 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? > security_kernfs_init_security+0x58/0x130 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? __kernfs_new_node+0x1be/0x270 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? > security_kernfs_init_security+0x58/0x130 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? __add_to_free_list+0x98/0x170 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? __free_one_page+0x34c/0x450 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? free_pcppages_bulk+0x19d/0x27= 0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? > free_frozen_page_commit+0xaa/0x4b0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? > __free_frozen_pages+0x29e/0x670 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? load_module+0x1354/0x14e0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? > __kmalloc_cache_noprof+0x189/0x420 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 do_init_module+0x82/0x270 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 > __se_sys_finit_module+0x26a/0x3d0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 do_syscall_64+0x12a/0x3b0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? vfs_read+0x14d/0x300 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? __x64_sys_pread64+0x70/0xc0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? do_syscall_64+0x165/0x3b0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? do_sys_openat2+0x93/0xd0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? __x64_sys_openat+0x80/0xa0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? do_syscall_64+0x165/0x3b0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? __x64_sys_pread64+0x70/0xc0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? do_syscall_64+0x165/0x3b0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? do_user_addr_fault+0x273/0x6a= 0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? irqentry_exit+0x3f/0x630 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 ? do_syscall_64+0xe9/0x3b0 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 > entry_SYSCALL_64_after_hwframe+0x67/0x6f > May 28 19:49:27 cassiopeiae kernel: RIP: 0033:0x7fb062bb26bd > May 28 19:49:27 cassiopeiae kernel: Code: ff c3 66 2e 0f 1f 84 00 00 > 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 > 4d 89 c8 4c 8b 4c 24> > May 28 19:49:27 cassiopeiae kernel: RSP: 002b:00007ffe2bae4d58 > EFLAGS: 00000246 ORIG_RAX: 0000000000000139 > May 28 19:49:27 cassiopeiae kernel: RAX: ffffffffffffffda RBX: > 000055b4032b23e0 RCX: 00007fb062bb26bd > May 28 19:49:27 cassiopeiae kernel: RDX: 0000000000000000 RSI: > 000055b403434900 RDI: 0000000000000043 > May 28 19:49:27 cassiopeiae kernel: RBP: 00007ffe2bae4df0 R08: > 0000000000000000 R09: 0000000000000000 > May 28 19:49:27 cassiopeiae kernel: R10: 0000000000000000 R11: > 0000000000000246 R12: 000055b403434900 > May 28 19:49:27 cassiopeiae kernel: R13: 000055b40340c570 R14: > 0000000000020000 R15: 000055b403437260 > May 28 19:49:27 cassiopeiae kernel:=C2=A0 > May 28 19:49:27 cassiopeiae kernel: Modules linked in: nouveau(+) > drm_display_helper cec gpu_sched drm_gpuvm drm_exec drm_ttm_helper > ttm nvme nvme_core nvme_k> > May 28 19:49:27 cassiopeiae kernel: CR2: 000000000000002c > May 28 19:49:27 cassiopeiae kernel: ---[ end trace 0000000000000000 > ]--- > May 28 19:49:27 cassiopeiae kernel: RIP: > 0010:r535_gsp_rpc_rm_ctrl_push+0x60/0x110 [nouveau] > May 28 19:49:27 cassiopeiae kernel: Code: 4c 8b 58 08 4c 89 f7 ba 02 > 00 00 00 89 e9 2e 2e 2e 41 ff d3 48 89 c6 48 3d 01 f0 ff ff 72 0b 48 > c7 03 00 00 00 00 89> > May 28 19:49:27 cassiopeiae kernel: RSP: 0018:ffffd3b38178f250 > EFLAGS: 00010213 > May 28 19:49:27 cassiopeiae kernel: RAX: 0000000000000020 RBX: > ffffd3b38178f2a0 RCX: 0000000000000000 > May 28 19:49:27 cassiopeiae kernel: RDX: 0000000000000038 RSI: > 0000000000000020 RDI: ffff8aa9db3339d8 > May 28 19:49:27 cassiopeiae kernel: RBP: 0000000000000000 R08: > ffffffffbe380560 R09: ffffffffc04c9300 > May 28 19:49:27 cassiopeiae kernel: R10: 0000000000000100 R11: > ffffffffbd66c070 R12: 0000000090f10000 > May 28 19:49:27 cassiopeiae kernel: R13: 0000000000000000 R14: > ffff8aa9db333000 R15: ffff8aa9e1c2d600 > May 28 19:49:27 cassiopeiae kernel: FS:=C2=A0 00007fb0623dc1c0(0000) > GS:ffff8ab15f8b9000(0000) knlGS:0000000000000000 > May 28 19:49:27 cassiopeiae kernel: CS:=C2=A0 0010 DS: 0000 ES: 0000 CR0: > 0000000080050033 > May 28 19:49:27 cassiopeiae kernel: CR2: 000000000000002c CR3: > 000000011efcc000 CR4: 0000000000f50ef0 > May 28 19:49:27 cassiopeiae kernel: PKRU: 55555554