From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C789367B8D for ; Mon, 1 Jun 2026 08:55:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780304128; cv=none; b=F+jSSfD3PDU903HIfvihtVlcTbxEjPqWex0EfDRt6slcQD4q+rgmfn6TpXJu/at5J/avefvN+d2h/ABM6HXnH7ZZFwzwAud7/zVg6eaKSDXEa8cho/lNd+MDbu3SHYsyNoMrJrdW6U5rInzUM4lVl/mdYUPGS6tRqy2R2ORDY5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780304128; c=relaxed/simple; bh=RdY42p/wifndKo7H6IvgYAEM6T3/yfdMFrK3fgm+JxA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aF8sLpKjDMirC/wFSBa8TfRaz+mAtQA6nnU1h5CDLQc0pVyPrzTzBfDTRo6Z679WY2goBjRNjni7omJH1wTzHomgPYccTxsK7FsSxBGVs/q4G9B0BRyMf0fmHT/ojBuBahvA9VQDnvdjJB/Fp7soljKiGitufuzd7fhVfx3dKkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Wbx6ih8I; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=BBYDAffU; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Wbx6ih8I"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="BBYDAffU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780304126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yjzh0NtHlyLrWYA9pbw4B3H4HjCFbZjoPTHNDaaKotI=; b=Wbx6ih8Is72zlSkCTPYWE4E+RycUPwvxzkvGKgxIIWa4diOLImI+mzWJnjktVh6Kc4jugA 4CJusfkIbO7hTai0mUsQpAv8S4ui+Jp6g8z2P0lmkLz94p1ED4L5UTilXFbtK8/DAVxHcG BAR+9rUqyHfZPjqJntfBCGqwJ+P2qYk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-14-gK1-mu_TN1eXv5u2Nsw4QQ-1; Mon, 01 Jun 2026 04:55:22 -0400 X-MC-Unique: gK1-mu_TN1eXv5u2Nsw4QQ-1 X-Mimecast-MFC-AGG-ID: gK1-mu_TN1eXv5u2Nsw4QQ_1780304122 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-460163035e3so81164f8f.2 for ; Mon, 01 Jun 2026 01:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780304121; x=1780908921; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Yjzh0NtHlyLrWYA9pbw4B3H4HjCFbZjoPTHNDaaKotI=; b=BBYDAffUagFkMzouft61yauRJW8fNYIy2N7jvjcmc237bVwdww4n+h+wMvqvFWxQmf rBDPtDXV5B3TXtDflIVgLs5nsc5Ma0wXWgllW/SLzupmt16q5FOeBlUfVWnwoCzPySk0 0FWgmDtERMFXxIeU+kVs5mK/yJBbSr9uxTgnaAoJ8A6efal5PZQDJBiJrTfUGpB7QjuN HMqgYIKkkU6wssZ3nbcycK6TRV2eMUau5iu8KmYt8jyu/SVLbWz+x8/N55pUG1I38pGF i2tNZbIrbZESqn7Fq5z+D7p4nGISbns/ESXeXvWvM5JzTRerLw7u+oA35Jiy//K075os h3Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780304121; x=1780908921; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yjzh0NtHlyLrWYA9pbw4B3H4HjCFbZjoPTHNDaaKotI=; b=n7w3/EjZa2UPnhqXPLiFX7cavSDYS9ts4p7aDK4f9AEABHHulHlnibnhB1wV07IrjF mZjbkPQBR7u07azAKLpieetkgtEV5OJcy41O2y/NCaa0ZMQ4I/LKwzIqFx9gTbIjGUtQ jC7G78OtkYdl8fAbetqmIXPNo/psA5empvGt1ZDYUsPXm/FcE15mfYAQcion7rTt2d+v JGLeTy5bHp40hytH0YsaaJlQLiJedvdwMs/upnjQwY6YV9MpW+QCgywDLQSp2kJJhLtL K2O0y51rUE+ktc1j/i9eShGCZQFnz4+uaUXpl50ADNUkkqK4g5oAipj988fflu3Cxuby RuMA== X-Forwarded-Encrypted: i=1; AFNElJ+70wL3w7tEeicYBPK3b/lnelF9RgB4PXRV2L2yuSOA+f8N2Bud1AGWV9KjAeEkW4thW2UlFH/TjclHcmM=@vger.kernel.org X-Gm-Message-State: AOJu0YyL7gsTDBSNx5Mr9pvQkqNf/HcgXvtAbivTQuiJN7kKOcy7cUMa EUS5joHJNRSwuJAwsglfqkTwki12ujtudSRTS9K64vBZrTUqmTSIvmBcvLB7h+/fGOYOiOyNhI6 EjmbdlA5WBOVlumAq5zaYLCWeGFnzaZsRCbMTQVc9Hri02c9pGP/74jo5o3tx9AKr5Q== X-Gm-Gg: Acq92OFwIUzeGLlLRuh7gmeMaoXz8bM5aCg2uMEFq4xQANiqLHaZWY7vvMHVxuYOtzO 9oryiXZnUZyOMDTKCTqXtWpJLeM6sXg3EsVGYU9S2LDNBzQ0P+rVVOUrvYY0aIXnK5ZlIOVlxI8 u8Ml4DShi4O3iD0SIC07JNzkBfu/falO7ejtOayYmLJ2H76Wp0kUMB93CgVQwCHXTZt7EQuey50 3tvtqzpKJ/iXqnKe3RSxfXM+Phu8fFn5gfP3hHF973btLs4r/bi7ieCHhShRbQsrCb+KRx5/ud5 HDhJUR2g0/sPSU5h842739RsfWbLkgcbpv5bwqmipArpbLJF3jI8BT42s9o32HY/Y21vPlh+OLt OUc8WHTIoyjdq9Q3hTNJE22QQAbAXbem+6ivS76yMZ3zBq0aN9bB42q3HRbrvb6fgYcWe X-Received: by 2002:adf:e510:0:b0:45e:ef4a:819a with SMTP id ffacd0b85a97d-45ef6b1fb03mr15886983f8f.17.1780304121581; Mon, 01 Jun 2026 01:55:21 -0700 (PDT) X-Received: by 2002:adf:e510:0:b0:45e:ef4a:819a with SMTP id ffacd0b85a97d-45ef6b1fb03mr15886931f8f.17.1780304121110; Mon, 01 Jun 2026 01:55:21 -0700 (PDT) Received: from [192.168.88.32] ([169.155.232.197]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef3563cb9sm24854431f8f.29.2026.06.01.01.55.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2026 01:55:20 -0700 (PDT) Message-ID: Date: Mon, 1 Jun 2026 10:55:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 5/9] net: dsa: microchip: implement .support_eee() only if needed To: "Bastien Curutchet (Schneider Electric)" , Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Russell King Cc: Pascal Eberhard , =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , Thomas Petazzoni , Tristram Ha , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260526-clean-ksz-3rd-v1-0-5b63e732149a@bootlin.com> <20260526-clean-ksz-3rd-v1-5-5b63e732149a@bootlin.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260526-clean-ksz-3rd-v1-5-5b63e732149a@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/26/26 11:47 AM, Bastien Curutchet (Schneider Electric) wrote: > diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c > index a39541d29ad5..e0b3724a7558 100644 > --- a/drivers/net/dsa/microchip/ksz9477.c > +++ b/drivers/net/dsa/microchip/ksz9477.c > @@ -1909,6 +1909,54 @@ void ksz9477_phylink_mac_link_up(struct phylink_config *config, > ksz9477_duplex_flowctrl(dev, port, duplex, tx_pause, rx_pause); > } > > +/** > + * ksz9477_support_eee - Determine Energy Efficient Ethernet (EEE) support for a > + * port > + * @ds: Pointer to the DSA switch structure > + * @port: Port number to check > + * > + * This function also documents devices where EEE was initially advertised but > + * later withdrawn due to reliability issues, as described in official errata > + * documents. These devices are explicitly listed to record known limitations, > + * even if there is no technical necessity for runtime checks. > + * > + * Returns: true if the internal PHY on the given port supports fully > + * operational EEE, false otherwise. > + */ > +static bool ksz9477_support_eee(struct dsa_switch *ds, int port) > +{ > + struct ksz_device *dev = ds->priv; > + > + if (!dev->info->internal_phy[port]) > + return false; > + > + switch (dev->chip_id) { > + case KSZ8563_CHIP_ID: > + case KSZ9563_CHIP_ID: > + case KSZ9893_CHIP_ID: > + return true; > + default: > + /* KSZ8567R Errata DS80000752C Module 4 */ > + /* KSZ9477S Errata DS80000754A Module 4 */ > + /* KSZ9567S Errata DS80000756A Module 4 */ > + /* KSZ9896C Errata DS80000757A Module 3 */ > + /* KSZ9897R Errata DS80000758C Module 4 */ Sashiko noted that errata: /* KSZ879x/KSZ877x/KSZ876x Errata DS80000687C Module 2 */ has been lost above. > diff --git a/drivers/net/dsa/microchip/lan937x_main.c b/drivers/net/dsa/microchip/lan937x_main.c > index f8f220242f7a..4cbbcf7993c9 100644 > --- a/drivers/net/dsa/microchip/lan937x_main.c > +++ b/drivers/net/dsa/microchip/lan937x_main.c > @@ -915,7 +915,6 @@ const struct dsa_switch_ops lan937x_switch_ops = { > .port_txtstamp = ksz_port_txtstamp, > .port_rxtstamp = ksz_port_rxtstamp, > .port_setup_tc = ksz_setup_tc, > - .support_eee = ksz_support_eee, > .set_mac_eee = ksz_set_mac_eee, Sashiko noted that `set_mac_eee` usage is gated by `support_eee` presence, you may want to remove even the set callback. /P