From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02EBF2D3A86 for ; Thu, 25 Dec 2025 05:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766642209; cv=none; b=RdRZxNhhemIdL0Zt8jR1D0PFi6VPcr9KEpS763kEpomMh+RWRspJ2eb1OfMB1n7IWKgG8UDtN0KdqXYxvfXeO8JxPj2wQ1xudCpCOI10f8HMTPAqmdcdXyy67sPm1j2nTBYTmm6eonAr1vToyqNt/8u3FnQguMHuz15YhPOo23U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766642209; c=relaxed/simple; bh=hzCvYAE5TeK3hWD00vyN6iYg4TpQY+xHKkrkvbW/iU4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ItFPy4knkBmrNeInD1AykVbXGMkqShOimlfKUNVL4xaW/43nUXr83AZ+DVogsRtYW5BWHK2gVSieBA7NYMmv5ul2avW+lQKCYDeS3OiLpOJHGn6BXjww6g7xXe+J0Z+i23IZggnouh7qsTDr2Av9nF8WolRSwjJLau20rSWxw+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=auOw+fTV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JQRE6vX+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="auOw+fTV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JQRE6vX+" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BONOfwO301099 for ; Thu, 25 Dec 2025 05:56:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BfuB7eoTY30N8EW1JW7i3nY4wQW0+TIT2sa3QpXTDuc=; b=auOw+fTVvkEoNTdG Fl/cx6fON9zhqMMb4KKVsXuRMJIZgKQPFF2S/Rg0ROgfRpIzMzXxqQL7LNiPflnl qAczousgYRljsS08/9xVfKe+aOqUcalsEH+RtiG73jYxo9P1iRJfksVaIbpdsun7 iNy2rwze3VecmRjOWGG2VjrvQFHDyYZknjaE/XBZdVaPI/ItlKkdBYyY8vvB/4hm pKbq4lfEK4myDDkP+zElLWn0GbKUvWLs9QvH8U0iaS+0tvAth6nhmSg1IxsYz+rF Wec7Q4K+Vk+KZY9f6qai/5DSl8Sw+mjW82o+1smJYbqeEAdbkiNYWS0szS7aZU7f G7R5Eg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b827r3pr5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Dec 2025 05:56:45 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-29f13989cd3so194340475ad.1 for ; Wed, 24 Dec 2025 21:56:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766642205; x=1767247005; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BfuB7eoTY30N8EW1JW7i3nY4wQW0+TIT2sa3QpXTDuc=; b=JQRE6vX+hN8ON6TbKXE4sPjFh4qQdRh4yYTjY6Hf+zlFDiASWpOlE9qOzCV4fxhDS5 DuOVLlLWPp+LMLKiPd8UAZZcdz77/TusEMqlDANrfl2t8ch3hbCfwt2ZHyyGb4TlJ6BS G7r9rbfFW2JLjG0Fpdkl8OO/SkY9sn4xReRlC9DtCO/2WU/1lnkWruUVE+X3OBH/J9mC HxHplNtg2RQhmp/fY9xzQlP/aJXxRBWqLbgULbwLfQiwtrS7E/lHbNgy+6IlGJwQ76IE G3a4eR6eadB/xaG1STWYlW5IgGk8DpikPuZWuu77CXvxdraVSgh8uefcs9A0qDErTzv9 nh7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766642205; x=1767247005; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BfuB7eoTY30N8EW1JW7i3nY4wQW0+TIT2sa3QpXTDuc=; b=tOfx6lJ6ozgpD1MSbVBEiJX8+oV4i3aP1msp8ytP6Ix3Q5XAl60loYTLHipduBgxzR aZWPDfa053CnAJPXJ6CVeSt9/+zlPvx+CI1lt1eLdNkUZ48xj7kr0z7v5Glzhm12oZob xX9YL7uNNhH6Z/xKKO8JcXMVUpYpQ63FOdbB5pW8CgUFQvfYhq/pNUXmnGMT1YUMvITu 13UPFqSFjaQYVNmyOsSU2Ns3Gm/xmk42YdMrPjH+BbnPAep1KDkGKojvOpnTFFFRtz3N kM+5P3kUUdvEV1rZtwWlzYeLL5MvNnjK+gvDSR11Kq9z48TH4cpPteUZzjUTrLFMYgf1 hVOg== X-Gm-Message-State: AOJu0YzVIBYGX4bpPqB8edTkuuQ5bXGWimj6aVaPR0mI+ie8T5Saziiw 1lwpV1VJq3TdNRRxs2k+QwQnMKWZPEi341WybAoSwtlidot/RGIxGXDcd6IcPTJtc9cjGIt0Sh6 ofCrWfCmWbFcxbMizWX9cp7veN7H523WmI8rHeD5Z/l6cExGIFeTG3pk3KAUJ0ZzDKNo= X-Gm-Gg: AY/fxX4EFvIVZHKtc9IvKKIuMMJrqwthhPZmRpBWT92usqh+soxW8xt3c82OIkrS2/h 6OTc2ByKjGBD737hnx8LVmhAs7EFRzB0cC87cgk0QLd+1hrwVTFnmHFoU9gSXzEOV14khX4PkcA rF5G/Dk/9HbfWYa5qbIIc5Ujn4i9LUxEoJa92SgCz4MdHKTHfIowCOylHLWZk3D1sGqqM09liMA g03seYrgztXaohBLvrjCYpB1LHu5QINv//lJBFd9joEn5ROGN+C7IHECOBdQBCFPhYNSfD0hyUm ty67Kz7mFZuK51ye15ol4z5TbcNv2ec2bdQgCpgflXlI2HYF8DuwE2wS98Toju+Jpa5Ru9+dmzY v35GqnntvOJZVtuNaC1a4oEj0j2FEdRgwOdgOY9zim8XlwI5vN8Y2xYBW5Dilsep2m+jPYmy/AN 8= X-Received: by 2002:a17:902:ec90:b0:297:e59c:63cc with SMTP id d9443c01a7336-2a2f2737be9mr202743205ad.35.1766642204675; Wed, 24 Dec 2025 21:56:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOpd3ErX7V5aJYRRI5TL4DpQGZJpZBgxbrQWzYR4JqWoT65p5BJeiqgHuYn/z8G3K4or7vgw== X-Received: by 2002:a17:902:ec90:b0:297:e59c:63cc with SMTP id d9443c01a7336-2a2f2737be9mr202743005ad.35.1766642204191; Wed, 24 Dec 2025 21:56:44 -0800 (PST) Received: from [10.133.33.250] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34e70dccd14sm20085890a91.16.2025.12.24.21.56.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Dec 2025 21:56:43 -0800 (PST) Message-ID: Date: Thu, 25 Dec 2025 13:56:37 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 7/7] qcom-tgu: Add reset node to initialize To: Songwei Chai , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20251219065902.2296896-1-songwei.chai@oss.qualcomm.com> <20251219065902.2296896-8-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20251219065902.2296896-8-songwei.chai@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: TuEdP1-WLnh9z4iBiZAcy5U0Nh9TGimC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI1MDA1NSBTYWx0ZWRfX3NW42T7/VGnq 5N1uMR8fbGU5ITVEzX8HwQEiUEQLGzbMekW11lolO5fA0g1aBdkEvTNOtkdR4zZ/kXTsz0F/nij hhZMaStoDuMz6RiIqnQpgJE+H4ln1zrCRbmE4kSvAxPJrZPmsOYjP70LY8gXBKa6VufSr3WeqyH HlMmOC3zqiY97zLVEuCf4vMAM30BFwk5uGIIrxaryE5UC/BtubTuKFLFQRSv4tdTyVlCk/F0tFl priSXQ03UWBxK7I6A8TcTJJEoGIrRC8kv4DTf0YjITUghQPJ23ub/1HH77Y8nvafO/BaenyXamM bq4Un07/f8y30dGS+bgPMPvQBUiV9PBqb+OuJBCneqHbZ3q52kL0at3ewJpOq5NwUL7jS2hOVUt Db84G3Y56G9wXINb4jCl5H4v8gebW+E+ciYcqjk1G+jes6eDb+fnpgZOxvFg/pfhKG6uICjy45n gQwc+6CgSoTERtpcuOQ== X-Proofpoint-GUID: TuEdP1-WLnh9z4iBiZAcy5U0Nh9TGimC X-Authority-Analysis: v=2.4 cv=RbSdyltv c=1 sm=1 tr=0 ts=694cd21d cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=JNGEfTUsO65A5MKw78gA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_04,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512250055 On 12/19/2025 2:59 PM, Songwei Chai wrote: > Add reset node to initialize the value of > priority/condition_decode/condition_select/timer/counter nodes. > > Signed-off-by: Songwei Chai > --- > .../ABI/testing/sysfs-bus-amba-devices-tgu | 7 ++ > drivers/hwtracing/qcom/tgu.c | 74 +++++++++++++++++++ > 2 files changed, 81 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > index 010eade0a1c5..0733b3e07b45 100644 > --- a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > @@ -42,3 +42,10 @@ KernelVersion 6.19 > Contact: Jinlong Mao , Songwei Chai > Description: > (RW) Set/Get the counter value with specific step for TGU. > + > +What: /sys/bus/amba/devices//reset_tgu > +Date: December 2025 > +KernelVersion 6.19 > +Contact: Jinlong Mao , Songwei Chai > +Description: > + (Write) Write 1 to reset the dataset for TGU. > diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c > index d4210869556e..5a8c6af9b719 100644 > --- a/drivers/hwtracing/qcom/tgu.c > +++ b/drivers/hwtracing/qcom/tgu.c > @@ -425,8 +425,82 @@ static ssize_t enable_tgu_store(struct device *dev, > } > static DEVICE_ATTR_RW(enable_tgu); > > +/* reset_tgu_store - Reset Trace and Gating Unit (TGU) configuration. */ > +static ssize_t reset_tgu_store(struct device *dev, > + struct device_attribute *attr, const char *buf, > + size_t size) > +{ > + unsigned long value; > + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); > + int i, j, ret; > + > + if (kstrtoul(buf, 0, &value) || value == 0) > + return -EINVAL; > + > + if (!drvdata->enable) { > + ret = pm_runtime_get_sync(drvdata->dev); > + if (ret < 0) { > + pm_runtime_put(drvdata->dev); > + return ret; > + } > + } > + > + guard(spinlock)(&drvdata->lock); > + TGU_UNLOCK(drvdata->base); > + > + writel(0, drvdata->base + TGU_CONTROL); Better move TGU_LOCK(drvdata->base) here Thanks, Jie > + > + if (drvdata->value_table->priority) > + memset(drvdata->value_table->priority, 0, > + MAX_PRIORITY * drvdata->max_step * > + drvdata->max_reg * sizeof(unsigned int)); > + > + if (drvdata->value_table->condition_decode) > + memset(drvdata->value_table->condition_decode, 0, > + drvdata->max_condition_decode * drvdata->max_step * > + sizeof(unsigned int)); > + > + /* Initialize all condition registers to NOT(value=0x1000000) */ > + for (i = 0; i < drvdata->max_step; i++) { > + for (j = 0; j < drvdata->max_condition_decode; j++) { > + drvdata->value_table > + ->condition_decode[calculate_array_location( > + drvdata, i, TGU_CONDITION_DECODE, j)] = > + 0x1000000; > + } > + } > + > + if (drvdata->value_table->condition_select) > + memset(drvdata->value_table->condition_select, 0, > + drvdata->max_condition_select * drvdata->max_step * > + sizeof(unsigned int)); > + > + if (drvdata->value_table->timer) > + memset(drvdata->value_table->timer, 0, > + (drvdata->max_step) * > + (drvdata->max_timer) * > + sizeof(unsigned int)); > + > + if (drvdata->value_table->counter) > + memset(drvdata->value_table->counter, 0, > + (drvdata->max_step) * > + (drvdata->max_counter) * > + sizeof(unsigned int)); > + > + dev_dbg(dev, "Coresight-TGU reset complete\n"); > + > + TGU_LOCK(drvdata->base); > + > + drvdata->enable = false; > + pm_runtime_put(drvdata->dev); > + > + return size; > +} > +static DEVICE_ATTR_WO(reset_tgu); > + > static struct attribute *tgu_common_attrs[] = { > &dev_attr_enable_tgu.attr, > + &dev_attr_reset_tgu.attr, > NULL, > }; >