From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Diego Viola <diego.viola@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net
Subject: Re: [PATCH] ata: libata-core: fix "it's" typos
Date: Thu, 24 Mar 2022 13:14:47 +0900 [thread overview]
Message-ID: <aa410785-b9db-cb97-2fea-f24336472f98@opensource.wdc.com> (raw)
In-Reply-To: <CA+ToGPGVdwXgWTZFa24PDMkpXrVrpM48WAxR4U6d4D9t-k=nJQ@mail.gmail.com>
On 3/23/22 17:44, Diego Viola wrote:
> On Wed, Mar 23, 2022 at 5:17 AM Damien Le Moal
> <damien.lemoal@opensource.wdc.com> wrote:
>>
>> On 3/23/22 16:24, Diego Viola wrote:
>>> On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal
>>> <damien.lemoal@opensource.wdc.com> wrote:
>>>>
>>>> On 3/23/22 14:52, Diego Viola wrote:
>>>>> On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal
>>>>> <damien.lemoal@opensource.wdc.com> wrote:
>>>>>>
>>>>>> On 3/23/22 14:40, Diego Viola wrote:
>>>>>>> Use the contraction "it's" instead of the possessive form "its".
>>>>>>
>>>>>> Well, while at it, let's use proper formal written English, so:
>>>>>> s/it's/it is
>>>>>> s/isn't/is not
>>>>>
>>>>> Fine with me, do you want me to send you another patch with those changes?
>>>>
>>>> Yes please.
>>>
>>> I sent a v2 patch changing those things you pointed out, however, the
>>> whole comment[0] looks informal "But wait.. there's more" and I don't
>>> think replacing "it's" with "it is" achieves a lot in this case.
>>
>> :)
>>
>> Indeed. Do you want it in or can I drop it ?
>
> Given that the language is mostly informal, I'd rather see the first
> patch applied (if that is OK with you). However, I agree with you that
> it would be nice to see formal language used, I just don't think I'm
> the right person to change all the comments in that file. :(
OK. I will look at it.
>
> Thanks,
> Diego
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-03-24 4:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 5:40 Diego Viola
2022-03-23 5:45 ` Damien Le Moal
2022-03-23 5:52 ` Diego Viola
2022-03-23 5:53 ` Damien Le Moal
2022-03-23 7:24 ` Diego Viola
2022-03-23 8:17 ` Damien Le Moal
2022-03-23 8:44 ` Diego Viola
2022-03-24 4:14 ` Damien Le Moal [this message]
2022-03-24 6:21 ` Diego Viola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa410785-b9db-cb97-2fea-f24336472f98@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=corbet@lwn.net \
--cc=diego.viola@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®