From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1DB43F7865 for ; Tue, 9 Jun 2026 09:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780997032; cv=fail; b=pju+jfNkl0wFQZ11qRFyUbh8TNbWiYnhT3KYta18VBEcCt8kRs8o4z8etymIowprXzQTlvJVxNfKzc4TK0Nub3+i3KELjfcXdyRO4g75WKVrHPnXiolLv8+Q2epEZvTrhyDcLBVF2pT9KQneDbGvVxtdYn9SisJAbgdg2Pfw+jg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780997032; c=relaxed/simple; bh=a5rFN0RYAPnuLGsV85NLmVW2hG+ptmQFVaL+h9+v0tw=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=MvT//57qHzEnen1+qI/03NlS5Bf0D9Gp6k6PVcNDEGALwyM3eDYmrSc6RBggSqoVM5F96qqEgqV428w8fgfmkhFcKV4Ndw3QkuwEsBf5Ewrf/q/Dqlpy8qpyCiJvvGzWSaLnNmhkWWQRjL1hmMzBEfCQSLkzfTleVvRZy1lQ5DU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Qwtcvt7/; arc=fail smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Qwtcvt7/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780997030; x=1812533030; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=a5rFN0RYAPnuLGsV85NLmVW2hG+ptmQFVaL+h9+v0tw=; b=Qwtcvt7/4UO2Z63JYKroyAkYBpLTz/5Fx/HdsAFslkyKcIC+/+9oODhY boMt+l9q0hShJm5gnDPNYuYzAx0qrUAzcfUkny56VQZ4mA/calQ+t0cVQ msKb1S2lPXoNDWseLjLxm8rpHzk8Bxln12TAoiGc1hvLXnVeAMhJ1dHfK aZPqY+H5Zw2k2FyL/nmQdMBiL011GZwMB0I8BhIt7l1882BtmLn7LN688 ebzRI1rD/01ayKN4AvIzXucxD3BpgTiG6q4VvVsvDVKklx8PxhvAWZAon u7WvE8BynRvOXybyIoWsF0/Am/xfZEN0vp9UCgZA1JSP7UOf9fqoDyQxj A==; X-CSE-ConnectionGUID: oxd5ukQtTi64MzNltBM0gw== X-CSE-MsgGUID: EeypAmUZRCC2/FD3k9E0zw== X-IronPort-AV: E=McAfee;i="6800,10657,11811"; a="81604350" X-IronPort-AV: E=Sophos;i="6.24,195,1774335600"; d="scan'208";a="81604350" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2026 02:23:50 -0700 X-CSE-ConnectionGUID: Lx7h1BrDTA6G9vj2P9nuMg== X-CSE-MsgGUID: tSNklWlWTUKoU71FO5mhiw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,195,1774335600"; d="scan'208";a="244651903" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2026 02:23:49 -0700 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 9 Jun 2026 02:23:48 -0700 Received: from fmsedg903.ED.cps.intel.com (10.1.192.145) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 9 Jun 2026 02:23:48 -0700 Received: from DM1PR04CU001.outbound.protection.outlook.com (52.101.61.23) by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 9 Jun 2026 02:23:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cV8NTUZxrEWm9mpP4azTWn1wXFcDIVVAi45Oaw37+Cg52LikNHkTavVNvFZktDoTVKOIVRxlnUbeFu6kXKcL3blsLz5HXiiQQxaGW3Auwj+LfaCV2S8GX/jcxgVx3qtozQFfJITCdZ5DlUgTcD7pDxiaN53h+NAcSvlSmT4g6cEqfgvClsTiFDDnBWuVSyopIsS/gcPDHWTern+dycOq4iCYzqsK0xF9g0zHHWNm5t10Rm2V60CGogkLai3Kk4hrfKLbPahXO6wgQ6fvOIM6AF9J0OGuedHms+zHiiM3QwEJy64UoukIh6gaX2RxIoM9Fn9MV+U0Br1YhpGU2CC4gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e0GSZAe5KJLrFFmmaRtk5qBm7XSDdH8CrUaAyvVNLys=; b=w0kaN8HMqHUwQ3U0D3R7r1CALmCNxH2CHvHQIG0PQ3FF1xuXzrksHFdIMubijB7xyARD6GrIEGsNafeI6Vy1XbQ3L4W9QRRhpB0fm4I+Oz9poGdiarE8V+D6qU3xe7ub66umkz9YwoCcTnxr5LttaLiCHXHJoctewadhx2ZrJaTGQ/G1YEx9RXJVjq4xONvkkRbjhrQxnjRxgMEZ0HiSsk9HY01vr0OUrnZo4qg3I6rY9q6ZEe7md9xC9rP/1i+LZ+iwcYuhcZoa5K6K8kGpZ6BUfQkV1Dj5LuX2NrcIp8oc7XGNJ7xIDLNnwW4MNnn2Gh4B+QtswFIaMq/aTe362g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from IA1PR11MB7198.namprd11.prod.outlook.com (2603:10b6:208:419::15) by SA0PR11MB4624.namprd11.prod.outlook.com (2603:10b6:806:98::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.12; Tue, 9 Jun 2026 09:23:41 +0000 Received: from IA1PR11MB7198.namprd11.prod.outlook.com ([fe80::2c4e:e92a:4fa:a456]) by IA1PR11MB7198.namprd11.prod.outlook.com ([fe80::2c4e:e92a:4fa:a456%3]) with mapi id 15.21.0092.011; Tue, 9 Jun 2026 09:23:41 +0000 Message-ID: Date: Tue, 9 Jun 2026 12:23:36 +0300 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 7/7] i3c: master: Reconcile dynamic addresses after DAA To: Frank Li CC: , , , References: <20260608075801.16111-1-adrian.hunter@intel.com> <20260608075801.16111-8-adrian.hunter@intel.com> Content-Language: en-US From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU7P194CA0027.EURP194.PROD.OUTLOOK.COM (2603:10a6:10:553::7) To IA1PR11MB7198.namprd11.prod.outlook.com (2603:10b6:208:419::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR11MB7198:EE_|SA0PR11MB4624:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f46e978-7491-4e12-da33-08dec608cb5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|56012099006|4143699003|22082099003|11063799006|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: AWsaLrlzgkIhbHlsL4OSII5U5C6L09lpgzZQFtE2lAaCcmIE3wdBIf8ebHGKFrgkYKaLayb90sTHzBJtamFQLI1Zi35S1FOHUnhQkypCrQM5lDGRo1666LfsS+G82Te4F8nxgs4tT2e8xtVD9LWnKFqx/RDHL93q8BfvLd25Q9xRjURIm44pFrC8wXadKtqY5Te81gIbiMM2k8aFl6mJNciy+2fxS1/32B1z3roVrK7F2MVIzg8f0+8ZYLpI/caGJG1AAm9hWaAY8nY9RS3P5dFqw3puVYHaXYm2z9aY60vEEE1RCziKqBESvmmPOlG9xfv24O4/fZhiKDaQJ62N7tS0TZlNu8PQypO05wpoxLYcjz3mOzWbHUJfFGwfKnjC41VwbHRe5P4hRmhJUuMNoSSX7d25piIR5xcUsnzZskwTRwU+cXwsWMMuRMO7crxIfWegvodcKprfibRX7ad/4/+FUO8kMnUYYR0t19rpCu3DCU0+DMuq0CFh6N01/d2jpK+Df+R/rTOPMDSqjgx2xaA/BYbGuuJcm7inH/ZakbfV0WeFAwwmqsLkE5gizFXtBVR3XrItigXsxBXtOa5vnF+Zra5aNLKwEuSfEl6s79NgxoLqp7b2dX1mvfVzdt/DmSfzQ6rfokR4qd2T+307lKBk8QSjIjlHSiFATxgx0fcSa2oHTQyvyzs5fIY5+N/5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB7198.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(56012099006)(4143699003)(22082099003)(11063799006)(18002099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGYxUFhQSnlBcU9EMUxGb1hydTkvcE10L09UZzJoeUlNRlNaYVQ4U2YzM0k1?= =?utf-8?B?VkZQU3FjNDZkYUZqMkF5NFdVbXg2NnlZNWU3Nkg1QU1ZTVJqSnRTSCtVOGh3?= =?utf-8?B?cWNTdnhXVGkxWCtQanN5UldYNmJiY0ZRL2xtQnJERHE3Lzk0ZmVEc0NqemRB?= =?utf-8?B?dk10dm9BUEloOFRMd1MrNXk0Mm45N2pKSksvcWdVRVpRTVQ4TEZxekVmbEFq?= =?utf-8?B?QzZmNk9MSjBKalYzWklqRWdRc2RrM0xXd2pDSEpDSWdCQklFSFpFcGdka1la?= =?utf-8?B?S0l2eC95ckhlMmtISkQxNXlWV3NueERoWWZjSkFCaGE0VjFERjRDZ1lTNEJM?= =?utf-8?B?UGgwSzVKc09LQmtHL25HeHoyWEZRUlNlY0lpM2dsRmdKTnZuY0w3Nk9lbjNP?= =?utf-8?B?S3BqVDBSdUZJVGlEY1VYRTFWMHkxUlBTWVozU2FKa01GODFDeUVSbjdOUW10?= =?utf-8?B?bTFDWkdaZG5xdDBYaEJKTWVvUHNzdlZVU21nZWtyNDEyU1FWa2c2M0dBQnZi?= =?utf-8?B?bWw3V09BeDZ0MVZnNVBOOEx1aDBDMjk1Qk56ZlAzWWwxenVEQjJ4ajZJWTFk?= =?utf-8?B?QTcrVnRBS2xSU1JPQTNYRnQyZ3llaUZ0UW5ubWZ6NEZyWFE0cHNwbTN4OWZ0?= =?utf-8?B?S09aa2VLY1J3Rk9BczFkbTNESWV4V2lEeVFSV0djOEpTcE9IZFhyZlNzTWVO?= =?utf-8?B?WVhSbDhwSnhvT2dWWHlaVU9wTzJGdVZyVnAyT1JNYWlXNU1aOWVReVJhamhY?= =?utf-8?B?VGlvOWMvQnZEZHVURDVVSWZ2dG83VTBqSXhuMjNEMWRRUWxKVXRMTGY4QUM0?= =?utf-8?B?RDVucE1BSkowNjlPRVg4Y2RibkNPNitrd0JkTEJNVTVMRDBVNzJLNDJCOTJi?= =?utf-8?B?T0tVc3I5ZmwrbEdGUGtmdUw5R1dMQTJQZVFWUG4wSVZHVk1XdTRPOThoTnQ2?= =?utf-8?B?UmgwWUdGZ1p3ZUEwcTBSY3UwOXFzZjFkR2kzVy9XMEpEWUVwTzlidk1vQjQy?= =?utf-8?B?a0ZxblZ6dEtjbHR0Lzc5ek5WMi83RS9QZ2ZSSnM4ODZvZTNhdlBoMitwdXNZ?= =?utf-8?B?ZVVKN3dUR29yNVFITWZEOUJwNk9rcXJZdFp3SzFkQmdrRHE4TGZWcXNyWGxs?= =?utf-8?B?V1ZXQWFBSm1DaktnY0dYdTR3YTQ0MGFYTjIxZ1dzb0tLMjFEYUJvdjBWaVB0?= =?utf-8?B?aXlvUmc3V09aUjVzTDI0UTFSYjBNWlFIUnpkM2xQR1N3T1JuMkd3enR1T1cx?= =?utf-8?B?WUM4bFc2MHZaTWJ1Um13cG5mcnp3d2tUcWZoSXk3Z1U1QUoxZ0MwcGJXN2JI?= =?utf-8?B?QWxXOEhrLzMyL3V5UXVlUDFVdDlrSXc5dit3d3VlTVJDOWRUakQwVnUrRnNB?= =?utf-8?B?ME8wRXpsVVpvRFR4QS9rdllwUkhHOHkwSks0c2Nkc00zamdhWFA1Mmcyejlr?= =?utf-8?B?SnF5S0l5dFBLbU50SnI1d250b1hpMmZPMGdrMkVKdmVrN3JPWi9uQ2xMcGtu?= =?utf-8?B?M0YrWThSUFI0R1dJcWhhUnRiZ0E3RWVROU1IcU5VODE1cXpyM2RZZTJ1Uitz?= =?utf-8?B?ektHTzczckY0ZE1KRUo2ZVh4NlVuMFE1VXN0VGRyUDBYMVlvSWc3YitLVUMw?= =?utf-8?B?ZktDbncxOGd1RTRQRFNtMnU3Q29JMWlzamVESkV4a2xQcmlRMy9mb3RWMmw0?= =?utf-8?B?R3NRb1QzSW84RzdnN1o0elQyMmJXOG1WL083M2JmU1ZTbmRDR2duZUloaVZl?= =?utf-8?B?QnBUQlNKY3JyMHczUnpvSnltQjQ3NEhJZU1aRkE1dVlvV21VaGNVRjQwTkNE?= =?utf-8?B?bmt2NlU1ZHJJMEV1SUVGOElZdkVKSHVxa1RhdDRBdkJrdUo1enJTckhuRFhW?= =?utf-8?B?RjRsSk0xZGEvSDBpWTg0ZTFBZnBjSTlqRkx3RlRqRGtuL2hJT3NuNjNsK2ls?= =?utf-8?B?NFdCNGNaNjJDMGtjNHBFaE9nN2NEcEwwNjN0cW1JdzVuVGppdmtwRUZHNFla?= =?utf-8?B?OHlVamJ3L2FVV0VBLzhVTUduYk9tekFKN2tZcFRldGhkY1JkUG05WVdsVWJH?= =?utf-8?B?WkIrRkNOVWJpa2sxVWVhV3diTjZHV2ZTU0pvczRIS2RFcWw3Y2w0czJlbzhy?= =?utf-8?B?aThSWE5odVZ4elFEN1FoUlNQZ3BOUkQ2eFR1MEhiSHdNdWc2ZDlHaWh6Rm1J?= =?utf-8?B?bzRYcFJBWEJvYXd4eXdNemxxd3ZMQ055L1h2Unh5djdtUWZCeFpTOG00UUJP?= =?utf-8?B?ZzQ5dEw2L3pVTm5HSlZqdmdJbjZBeFd6WXJ2UEVnTEJ4bXpvckU0TmhkSThF?= =?utf-8?B?eWRIN25ZMFE2bDBsV3QyeGdEdjl5TFRNeVA0ZERSdE91cjdwYzJ5cnMrOGdH?= =?utf-8?Q?Fck+34SbkcbJ8fgc=3D?= X-Exchange-RoutingPolicyChecked: Aguc+UWwILR9uTlQYbRRiJHNb1EPcbpNcSNkQKE2kSkn39WtCWt0waMxajf2p0YDK1dspOc7DRAXN+jNR24CUiKNroeSsVk3rTOohs3g/x51xjyN4GOaIEZzE14n+vYu5EG6LplC/KjWXuIJzf/O7bha8+T8lK3+p2xUvRxP8JPRNd2Ult1uZ2wbPoEixydiONgHcTL8Inaxc9cJWez4wM848GJuD4ZAexSb9YQCR2cXKsWicuMqbMHRLZXvaCC9EnMV6FneIjBwXf/xNtvWnGi1JufWQA45sjuQPJTNsRG2a2i+pSv3VT2LmvW/73GTyfvW7cPJY/TBv6xa0ox0kA== X-MS-Exchange-CrossTenant-Network-Message-Id: 2f46e978-7491-4e12-da33-08dec608cb5c X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7198.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2026 09:23:40.9663 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: INV38rzYWonDUNak+b/+hbItd8SumKFTdBKIr8aSmbZHKW2QxUAVW/9EdXocRoND7SK7GolLDmP1v7lktML4AA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4624 X-OriginatorOrg: intel.com On 08/06/2026 21:06, Frank Li wrote: > On Mon, Jun 08, 2026 at 10:58:00AM +0300, Adrian Hunter wrote: >> After Dynamic Address Assignment (DAA), there may be cases where >> devices have been assigned dynamic addresses on the bus, but are not >> successfully registered in the device model. This can happen, for >> example, if errors occur during device addition, leaving the bus state >> and software state inconsistent. >> >> Introduce a reconciliation step to resolve such inconsistencies. >> >> Scan all address slots marked as I3C devices by the bus, and compare >> them against the set of devices currently registered. For any dynamic >> address that is marked occupied but has no corresponding i3c_dev_desc, >> probe for device presence using a GETSTATUS CCC. >> >> Retry the probe (with exponential backoff delay) to handle transient NACK >> conditions. If a device responds, register it via >> i3c_master_add_i3c_dev_locked(). Otherwise, free the address >> slot so it may be reused in future DAA operations. >> >> Note, i3c_master_add_i3c_dev_locked() may fail (again), in which case the >> dynamic address remains marked as occupied. A future DAA will try again. >> >> This also handles a corner case where a device is assigned a dynamic >> address but not successfully added, and subsequently loses that address >> (e.g. due to power management). If DAA is run again, the device may >> receive a new dynamic address while the old one remains marked as >> occupied. Repeated occurrences of this scenario could eventually >> exhaust the dynamic address space. The reconciliation step ensures that >> stale addresses are detected and freed, preventing address leakage. >> >> Signed-off-by: Adrian Hunter >> --- >> >> >> Changes in V2: >> >> Add bitmap.h include for bitmap_zero() etc. >> Re-base due to changes in previous patches. >> >> >> drivers/i3c/master.c | 115 ++++++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 113 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c >> index 5021d25b718a..6656c8591fab 100644 >> --- a/drivers/i3c/master.c >> +++ b/drivers/i3c/master.c >> @@ -6,7 +6,9 @@ >> */ >> >> #include >> +#include >> #include >> +#include >> #include >> #include >> #include >> @@ -1613,6 +1615,56 @@ static int i3c_master_retrieve_dev_info(struct i3c_dev_desc *dev) >> return 0; >> } >> >> +static int i3c_master_getstatus_locked(struct i3c_master_controller *master, >> + u8 addr, u16 *status) >> +{ >> + struct i3c_ccc_getstatus *getstatus; >> + struct i3c_ccc_cmd_dest dest; >> + struct i3c_ccc_cmd cmd; >> + int ret; >> + >> + getstatus = i3c_ccc_cmd_dest_init(&dest, addr, sizeof(*getstatus)); >> + if (!getstatus) >> + return -ENOMEM; >> + >> + i3c_ccc_cmd_init(&cmd, true, I3C_CCC_GETSTATUS, &dest, 1); >> + ret = i3c_master_send_ccc_cmd_locked(master, &cmd); >> + if (ret) >> + goto out; >> + >> + if (dest.payload.len != sizeof(*getstatus)) { >> + ret = -EIO; >> + goto out; >> + } >> + >> + if (status) >> + *status = be16_to_cpu(getstatus->status); >> +out: >> + i3c_ccc_cmd_dest_cleanup(&dest); >> + >> + return ret; >> +} >> + >> +#define I3C_DEV_PROBE_INITIAL_DELAY_US 20 >> +#define I3C_DEV_PROBE_DELAY_FACTOR 2 >> +#define I3C_DEV_PROBE_CNT 5 They are somewhat arbitrary, but should give a device enough opportunity to respond. > > what's these value coming from? from i3c spec? > >> + >> +static bool i3c_master_i3c_dev_present(struct i3c_master_controller *master, unsigned int addr) >> +{ >> + int delay = I3C_DEV_PROBE_INITIAL_DELAY_US; >> + >> + for (int i = 0; i < I3C_DEV_PROBE_CNT; i++) { >> + if (i) { >> + fsleep(delay); >> + delay *= I3C_DEV_PROBE_DELAY_FACTOR; >> + } >> + if (!i3c_master_getstatus_locked(master, addr, NULL)) >> + return true; >> + } >> + >> + return false; >> +} >> + > ... >> >> +static void i3c_master_reconcile_dyn_addrs(struct i3c_master_controller *master) >> +{ >> + DECLARE_BITMAP(dev_dyn_addrs, I2C_MAX_ADDR + 1); >> + enum i3c_addr_slot_status status; >> + struct i3c_dev_desc *desc; >> + >> + /* Mark all devices' dynamic addresses in the bitmap */ >> + bitmap_zero(dev_dyn_addrs, I2C_MAX_ADDR + 1); >> + i3c_bus_for_each_i3cdev(&master->bus, desc) >> + __set_bit(desc->info.dyn_addr, dev_dyn_addrs); This misses static addresses. I will add: if (desc->info.static_addr) __set_bit(desc->info.static_addr, dev_dyn_addrs); >> + /* Reconcile the bitmap with the bus address slot status */ >> + for (unsigned int addr = 0; addr <= I2C_MAX_ADDR; addr++) { >> + status = i3c_bus_get_addr_slot_status(&master->bus, addr); >> + if (status != I3C_ADDR_SLOT_I3C_DEV || test_bit(addr, dev_dyn_addrs)) >> + continue; >> + i3c_bus_set_addr_slot_status(&master->bus, addr, I3C_ADDR_SLOT_FREE); >> + /* Try to add the device, but probe to see if it is really present */ >> + __i3c_master_add_i3c_dev_locked(master, addr, true); > > If dev add success for addr, but you free addr at previous line, any > issue? Currently, addr is always I3C_ADDR_SLOT_FREE on all paths that call __i3c_master_add_i3c_dev_locked(), so this is consistent. There is no i3c_dev_desc for this addr since that was checked just above. Then a success path will use i3c_master_attach_i3c_dev() which sets I3C_ADDR_SLOT_I3C_DEV via i3c_master_get_i3c_addrs() > > Frank >> + } >> +} >> + >> /** >> * i3c_master_do_daa_ext() - Dynamic Address Assignment (extended version) >> * @master: controller >> @@ -2445,6 +2551,11 @@ int i3c_master_do_daa_ext(struct i3c_master_controller *master, bool rstdaa) >> if (rstdaa) >> rstret = i3c_master_rstdaa_locked(master, I3C_BROADCAST_ADDR); >> ret = master->ops->do_daa(master); >> + /* >> + * Handle cases where a dynamic address was assigned but the >> + * device was not successfully added. >> + */ >> + i3c_master_reconcile_dyn_addrs(master); >> } >> >> i3c_bus_maintenance_unlock(&master->bus); >> -- >> 2.51.0 >>