From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3161E12B8B; Mon, 19 Aug 2024 00:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724028412; cv=none; b=kIizhhkB+NQscqMbl3QIEZlZ7ebwQDp2gmwp37/+b/9uMwFHRtaqrvq5MMyaKVCg9HdWNIn/m+cllMRSnikqfFRunSR0EuWCw+BQIvWZgoo3iOojYKxDkix0xDoPpQMVm3lJozrxGkN/Z6g18fd7UpXtI0ngMkKpUs+vg7GzdcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724028412; c=relaxed/simple; bh=jrPlZbE7LoOXj9mQ/5B3ZcNxT0IT0z22GvomMwFyG3s=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Ic1Qv7yeoIsMomx9Xu2f7eBZ8wIPXGK96e16UUUwRxv6Ilyc4+6UyfDU7M2dfeHTXyQ8ju+rUWmFJ51x7yYiGHUsijLO1lp9FVagn6Mf/GqZATDVh+0ZqASqOouHQZ8jI1MeWAxd2EhLmhtBj0BmFE5yKfqhdy6BLgM3WTGpJ/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=d6FSQom6; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="d6FSQom6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1724028409; bh=bGQ/6crBzg1SbZu2JoYzHaThvgd+RzBseuDcIcIe2/c=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=d6FSQom6vPscKpKyn+aa9H1ffN0cbZnR+trtLKlJP5NDfPyXrBiZQKZHvEEEW85t6 YFAQQUpeLSJOlDDeUIPSTY/thcWl/Afekd5eOmH3A1abvnSzvZGkwVVE8rIKVEqvOg Jh69GK+5eFcvKtqIzjzpfIPRo349wiljHq4PwcK00STHCyFKA7XWIxHw2JDhIUJeBt W7NV3CVCBOtnwrP1J/EolVj9wSUAKqwcaRIoLgjmWqdxXtJPH0MPP/fwx5gl1P/20X KqfQsR0gvSqdGd8jP3edagqSwQz1ovZ3UFm8/41GJwfVrKc9g18SwD9jCTxyd0c13U Xm/18aoskkNrQ== Received: from [192.168.68.112] (ppp118-210-94-119.adl-adc-lon-bras32.tpg.internode.on.net [118.210.94.119]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 2CC2A64BE9; Mon, 19 Aug 2024 08:46:48 +0800 (AWST) Message-ID: Subject: Re: [PATCH v12 18/28] ARM: dts: aspeed: yosemite4: add mctp config for NIC From: Andrew Jeffery To: Delphine CC Chiu , patrick@stwcx.xyz, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Mon, 19 Aug 2024 10:16:47 +0930 In-Reply-To: <20240816092417.3651434-19-Delphine_CC_Chiu@wiwynn.com> References: <20240816092417.3651434-1-Delphine_CC_Chiu@wiwynn.com> <20240816092417.3651434-19-Delphine_CC_Chiu@wiwynn.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2024-08-16 at 17:24 +0800, Delphine CC Chiu wrote: > add mctp config for NIC >=20 > Signed-off-by: Delphine CC Chiu > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b= /arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index b46a0b9940e2..7b8a2384d99d 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -1281,40 +1281,64 @@ imux24: i2c@0 { > #address-cells =3D <1>; > #size-cells =3D <0>; > reg =3D <0>; > + mctp-controller; > temperature-sensor@1f { > compatible =3D "ti,tmp421"; > reg =3D <0x1f>; > }; > + > + temperature-sensor@3c { > + compatible =3D "smsc,emc1403"; > + reg =3D <0x3c>; > + }; These nodes are unrelated to MCTP? Given we're assembling the puzzle via the jigsaw pieces in the rest of the series, please split the addition of these nodes out to a separate patch. Further, the EMC1403 compatible is undocumented as of v6.11-rc1, and a brief search didn't turn up anything on the lists. Please send a patch adding it to the trivial-devices binding document. Andrew