From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FFF41E511 for ; Mon, 16 Mar 2026 14:35:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671747; cv=none; b=sWqs1rx8E4UOfgoAnbRkE2YGwT8A1e2LVnbobOfICHh40cf+WneuWpSoZ1/Xxhqn540HEsNdRwDE7Lvs5AgX8GTyaXYzQO2kHqfACZQ5axBFaWvLXhw2w34pzKL3ioG92CdhBWmy9OO0vNxmNC/aTbCaNuYffg8u4obZPQAKBEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671747; c=relaxed/simple; bh=d70bjVF6vDRM6k13qSofdJz0KNPkIJwSal2aUccH4E4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h/olVY8QQf7UJoFoZ5JBUAOW95BosHRQPabdwMR2UReRAB2KivBQypq0Ggu0Eqlc9bi/arHtU/RqriEoXrQ/0joEZTb9d1WqbgZ80gjZS9JnwBbhNoidI0f6yE5PAXuUF1X1j6L2FmWYJj0bdHlRqO60alP5S9bCMLyV4a/+SdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B9IiSBZK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=STW4bfnZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B9IiSBZK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="STW4bfnZ" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GDC2nW041567 for ; Mon, 16 Mar 2026 14:35:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Zo9jN8o+ApUVYkkh7NcPiTaOjGo6lkPT4XgMvJP/4w8=; b=B9IiSBZKXxo1eq4o YDY7yiknkqQm1pygXIzsW7C4nGjlu4lbdBpzli0yxzvxy+QXv3ZHV1ZlBJss0ApK FOLYR5Ag+rp+euWUiQJHoFNc1eR3P0zJdBrshXgBO30de32GIRVsl/v/8S9pBjBM 2TV7Xher5fOKBfnO0Zn0Bo3L0h+WDChBfUB6JMZhOhe03HN8NT/Kf3aDBqVOKYyq ZS5HhWq6MfTpb/C3rGpgbFnAZFUMTpgXS099OfBhQ+TPzIkugPEqz1ipr8gKjeXD 3CZdPH18jM0eJQiMzGEA/ti6NWjY0CDzrAeGakYVRBThGAaGwrsk9LsCVVgKQwTV W+ssfQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxdt81jkm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 14:35:45 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb50dfd542so323265885a.0 for ; Mon, 16 Mar 2026 07:35:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773671745; x=1774276545; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Zo9jN8o+ApUVYkkh7NcPiTaOjGo6lkPT4XgMvJP/4w8=; b=STW4bfnZNSMVO33Nus1wwxVYiDy++wpVbB93IPlOXcPmmoqiY9JcN5nreXDEEcGnKP D5qpTJj2XcQd8/ssl2lKaramH/7Yi1rSpaI6D5D7jq7eGGdcX//Kn6qbAhQqRocsQ3CV QikLgoKTgW99fGbkg5Xyno3LNDfLV7dsKdW8bp/CckefIOx0xAVWDetbP2TJZnnM6Jt0 TH2yvzvlKF1oXcyvJxdPpM84cLrThz1XYfE3EHIL+LaVOAJcuW05ToDQRsaXwExR51WX drzBGTmm69MD55OpgkevH7uJPShQRiJJgVG0EUk6mkvuCoYMQs3wyAgH7TRY+M18CA5s ad5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773671745; x=1774276545; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Zo9jN8o+ApUVYkkh7NcPiTaOjGo6lkPT4XgMvJP/4w8=; b=KRTwNqGfd3HSWramniQMnicMdDsgzd60zwcCbBldp6TAeVDiPKeNUwd5zYpIWw1G21 ukl8Up/H1OShhjo+QttEvmoCVJHsDBA4sUxANOpuQ+98IOImyQ6O2tW/r/t/cRTT7IHm laACq2TSWAOJoqpurr68FBhdIFDnSHJISbdFRcRB444Jj9BkFlNJwJnkWI5MpL9SZVRd mXHW/4lFZjpniuByySPXtIlw6kYgiVVBYyiw2xgP+NowD4H0tVmvvw7fWsu2PCkScP2W UtyKpwAV/9dd5SEDgeZAlmCqFUF9wkPnHuRRovhC2w51sWPUzBM8grrjiiMDBL1feVJ9 NArA== X-Forwarded-Encrypted: i=1; AJvYcCXJxLWch3xTOHMd4HGQYa3/W+2wwn4RutyxFwnhYiyMs0MSdoJyx2CHnL1giOEqF5kQEt/ddz9r+NO4izc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4oPlHtEDZ4Z2qX5VDHeUo6F9rbXZDvX2DaPbkh8nLjLwWTfz/ km3+ujJxNTQ2p9Oz72bXgc3M6H3zWYYE396VV/+XFaFncQU0q4DGxe3s74St1TFm3dsFH5fd2b7 L0eup0WGPa8VhtEK49locLQ1aCQ9dzAEx+XAZ6N1muw0M50YaCc6FLb5FG+eocGB5HOI= X-Gm-Gg: ATEYQzwMfHWdfhDxToX9THhgRRS99OyXtWK6vgKTZcW9qoa6X7mSe6rMrX+b2Ddv55g dJ4mlvq3b/WP1goH74iLHrn5o2+PlFb9G2ORuaVqvHWrXF+/uKtKR7e/XBrSfKErow/BArLW+Dk TuZ4NEdiQO9fW+qTKkLZrgDP0B09HAcnZh/WxDnmI0moyckFskMihHGzM73AOqE3HOxrYFkFNb7 A7X8rVTMyJhQVeTQ+18CfDRezi4wm2F7qvaaTsKKLxRLLbgCISkin4OMchtiKxCOJv/IKNw1BU7 Vqr7wfzQsAvfUGnZozqBZLzEKOE3E6lGULSuJZIuKKEPufhFAZTLRZ22Q4g7i3xa3gpE7UFqmPB boAENV3sG9ydeeYpG0VX77rJCt1YCg07+OQMTmWfTO2sr5kzyDsXUGQjWRkcF/DEebO+7sMCQyc +BxkY= X-Received: by 2002:a05:620a:4625:b0:8cd:b2ce:b746 with SMTP id af79cd13be357-8cdb5a1caa9mr1277043585a.1.1773671744727; Mon, 16 Mar 2026 07:35:44 -0700 (PDT) X-Received: by 2002:a05:620a:4625:b0:8cd:b2ce:b746 with SMTP id af79cd13be357-8cdb5a1caa9mr1277040185a.1.1773671744347; Mon, 16 Mar 2026 07:35:44 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a155f33c15sm3385319e87.17.2026.03.16.07.35.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 07:35:43 -0700 (PDT) Message-ID: Date: Mon, 16 Mar 2026 15:35:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm: Fix GMEM_BASE for A650 To: Dmitry Baryshkov Cc: Alexander Koskovich , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260314-fix-gmem-base-a650-v1-1-3308f60cf74c@pm.me> <2938aa01-cc1b-4dd8-a4af-45ff8354a061@oss.qualcomm.com> <6gxzcgwzvqoaqgynwnturjybanjrk2jmmsa3qh3r7vafyyzj44@dfzkd3vigluu> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6gxzcgwzvqoaqgynwnturjybanjrk2jmmsa3qh3r7vafyyzj44@dfzkd3vigluu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: lu_V_LtQaJPz3VNOi9Ct4kA-B1WvkiFW X-Authority-Analysis: v=2.4 cv=CKInnBrD c=1 sm=1 tr=0 ts=69b81541 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=Dg97ds3F-sJKPeOKljEA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: lu_V_LtQaJPz3VNOi9Ct4kA-B1WvkiFW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDExMCBTYWx0ZWRfXxyugjNx4WtIV qRNBM9qKL9dvolgWSUbYNlG2SOJsT/3s7f7sjC0PkiFNGa6ULMv7cvjsKe1M5FcXcmAfNYyzIRp eqzNzgxkSfIwfyTn0SHrO5bAlzldb7SwC9C1fahS3GshTHlPU+vrFb1HHIdZ3+icSwvUteHIyUo p+DxlqZL8SgQsbk2H8zVKDj6/6si8NmMFkEDUsOEnIeORJL0q2R+1e2eNdzy+Tc/2LozXrz3Ae1 B7Tnef4MAHhpMLJ5LYYDtv3ZWT2xlSdlTXOZXHgRyywEUu7EE6aIhLQPPGUl0dcWguHWIPvSRGD aczU6FdcQ6sO9L4okFgOZO4zu/GVTVIk9/OFoLxYDWrRATOXiSmp9IeMiyunWsx/tRcdmupHveR LVM/7LOoePUGkeXrb9o8NgnD9eg4Qx1aSRiiOlk93Ma8fwOt0LCcBZMudDSIdDWMj0JjAOvlfYd rJzqrtWF3+sBy5YP1bQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160110 On 3/16/26 3:28 PM, Dmitry Baryshkov wrote: > On Mon, Mar 16, 2026 at 10:22:44AM +0100, Konrad Dybcio wrote: >> On 3/14/26 5:14 AM, Alexander Koskovich wrote: >>> Commit dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") changed the >>> GMEM_BASE check from adreno_is_a650_family() & adreno_is_a740_family() >>> to family >= ADRENO_6XX_GEN4. >>> >>> This inadvertently excluded A650 (ADRENO_6XX_GEN3), causing it to report >>> an incorrect GMEM_BASE which results in severe rendering corruption. >>> >>> Update check to also include ADRENO_6XX_GEN3 to fix A650. >>> >>> Fixes: dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") >> >> Hm, that commit also changed the value for A730 - Akhil/Rob, should >> that be changed back? > > I'd say, I'm also surprised about something being broken for A650. Which > path / stack uses this value? mesa Konrad