From: Markus Elfring <Markus.Elfring@web.de>
To: Lee Jones <lee.jones@linaro.org>,
Tang Bin <tangbin@cmss.chinamobile.com>,
Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: mfd: asic3: Add error checking return in asic3_mfd_probe()
Date: Mon, 20 Apr 2020 10:37:36 +0200 [thread overview]
Message-ID: <aa5f9e64-042e-21a1-d252-9856207c7511@web.de> (raw)
In-Reply-To: <20200420071339.GG3737@dell>
>>> And remove the redundant 'ret = 0'.
>>
>> I propose to reconsider this interpretation of the source code here.
>> How do you think about to move the mentioned statement into an else branch
>> at the end?
>
> Could you please fix your mailer.
Would you like to help with increasing software development resources
according to corresponding open issues?
mailto:tangbin%40cmss.chinamobile.com?In-Reply-To=%3C20200419091923.5728-1-tangbin@cmss.chinamobile.com%3E&Cc=lee.jones%40linaro.org%2Clinux-kernel%40vger.kernel.org%2Czhangshengju%40cmss.chinamobile.com&Subject=Re%3A%20%5BPATCH%5D%20mfd%3A%20asic3%3A%20Add%20error%20checking%20return%20in%20asic3_mfd_probe%28%29
Can any more clarification help also around the previous update suggestion
“mfd: asic3: Delete redundant variable definition”?
https://lore.kernel.org/lkml/20200403042020.17452-1-tangbin@cmss.chinamobile.com/
https://lore.kernel.org/patchwork/patch/1219914/
https://lkml.org/lkml/2020/4/3/4
Regards,
Markus
next prev parent reply other threads:[~2020-04-20 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 11:19 [PATCH] " Markus Elfring
2020-04-20 7:13 ` Lee Jones
2020-04-20 8:37 ` Markus Elfring [this message]
2020-04-20 8:50 ` Lee Jones
2020-04-20 10:04 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa5f9e64-042e-21a1-d252-9856207c7511@web.de \
--to=markus.elfring@web.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®