From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08EC13A7833 for ; Mon, 9 Mar 2026 11:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773057325; cv=none; b=dqAjHkhcYylQad/ORsd/zgq6PpSF7+Sv49fvBEgsEQB7KECdvlCbCE5VIah8o3+3pL1IM5VfiqBeC1I2Pac950hmH1JEDWJ8b41/4y5btQ7z+S+eF1NTFo0VAVeYSMLnoPXZJz9gcwxz39mL+OpcsLna67rgjDEz9AqovAeOL+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773057325; c=relaxed/simple; bh=tPGbrgCaMZ0DyZ19LOBd8Mpe50NT1GWQeSsYHmyqIe0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t5k5Dj2yfJilTA5+g4b3lbpM+GfT2R2wYRRuglH6LR25do2PnykoS0E4XcPE4YIsVcx7ssicUzAWqCJRVmlzo9XU3v97Jal3n8GYxRJfJArTHLOBS8UMpQlC7QLIdCQYN1gFyvffRsGl7V3oiITiDbmyTpvhHY0pFvdom37DsRI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OIi9yxSV; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OIi9yxSV" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-439c9bdc1eeso2134810f8f.3 for ; Mon, 09 Mar 2026 04:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773057321; x=1773662121; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7mQ7Kz8UXz7g8x61N7gNTXLc2y01BI63pf2wBEUFNVk=; b=OIi9yxSVWB1oNrx68Vcv25QKLF2qawBQF330ptE88+AMDpFBL0fNuGY1PqSK7zLqob qSweFmwEmfNAFqWq+Uy1c3qoX9p1aolgyHC1eWlEuBQF+6n+Ij9iMoveP+kX95Szlz3N KkFr0e77vUyt3NQHWpC4B+BczFKJwaduH2ayHsXG5rZEq8efEteBlURPi1VsmZr1R1yo i5iAwOaRE1zYmkxJfILhD5rVXRmm1sln3iausPiTQyjFZ1nnwF/BVlRGHfGv9zEaLYgJ FHAyiVqqk9AE/iMLXQjocnCqFKhk/7uATn1kwRR0DTb0tTyLqB/okQBdNTM031/rYuyQ 7xJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773057321; x=1773662121; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7mQ7Kz8UXz7g8x61N7gNTXLc2y01BI63pf2wBEUFNVk=; b=DfC0RLJeOWWBqaXqYpEDkakoKPApkeEB2aRGKbt4Sz8N0M8h6meWyMLhm7C2v15p5I UIEPgxEKQFyw/s2IABQo0+j+bPy12I9HRPBEEkrZyxzgfQvnxHTePuEura6LBPLbLYEA fb/0YSQiLA9xafZK4Sf0X5g5caaHjaFziXyQACKLvLEdZqcwclJ39/3eSyTmPasEzniw 5y9qAfJwo2MaOemh21l3kMe5i/CqfFcwSA/Rz+Uba9atO4jy8uvAoklbRODx0iWgUKFk be6cX/50G8mH/DGn9wteBgh6m36bknEkRHodtCwWekbPub9pq0pB1MdE6ibRUa33PUJy bqWg== X-Forwarded-Encrypted: i=1; AJvYcCUpMs/qy/b+EXfoF+wUV40RA73BWu+OcAdqqawJNYOoaBH8p7IrZYUl04kupfAnQjKLqibnLU5PYp0JyDM=@vger.kernel.org X-Gm-Message-State: AOJu0YxD0XO7KXxHGEnCtVG+Qz2eZNHS8WLXc9XYP9EOuaMNzdHAovvr e851AR1a++eAQfijbMZeClsVY34RBhvD1s2jsPc+XdoM15GsQCPPWGTe+4MZU2Jkxq0= X-Gm-Gg: ATEYQzyrE+bLNSpM6pgJWEb9MhjVWwBBs0ulMsheMZoELfrujnqMo4tR4IptFTzAq+w EOC9ZZJdSQ/k5XcZAGrccAT1pwBX7YdK92Z6UOBDhJ7qU1uf/BYD7Hju6OKeFv+uwALgS+HqPsf YtcKI8P7BwWdkSMerm+J9A2XC9G/jZ4LN2hBcaOESgapSMoAIY5/n+4erVhXw5K26hBaghmm7FA 1IFDFWZitypurH7PjDrCu648HrPltP0wAZ+N3CQjv/2mYvbrdZfuUBQrzF/ipLC5CdDgdjbmzm6 Wjo1w641hOcGNEbg455N+YnxIsTSqciQHglVUPhVNyGu91DqyvPe/qgMsdgaWa8JROkwMKi32uS 2OwKrDjpoVzSIN7qe4mDD+4Po9WAKr/51S7SjYvaoCfd3EsIqgVT1f5l6TNxB1JzYSQ+lwPA+Nl 1odoFcURZ/Z1c1u2kPZ5u9uYUPEpqI/fY8ciQ= X-Received: by 2002:a05:6000:2010:b0:439:d6ea:7cff with SMTP id ffacd0b85a97d-439da354a83mr21218582f8f.4.1773057321360; Mon, 09 Mar 2026 04:55:21 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff23:4410:1c2c:7aff:fe45:362e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad97be5sm26979725f8f.11.2026.03.09.04.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 04:55:20 -0700 (PDT) Date: Mon, 9 Mar 2026 12:55:09 +0100 From: Stephan Gerhold To: Konrad Dybcio Cc: Sibi Sankar , robh@kernel.org, krzk+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, bryan.odonoghue@linaro.org, ilpo.jarvinen@linux.intel.com, hansg@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Maya Matuszczyk Subject: Re: [PATCH V3 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices Message-ID: References: <20260308233646.2318676-1-sibi.sankar@oss.qualcomm.com> <20260308233646.2318676-3-sibi.sankar@oss.qualcomm.com> <96f8738f-9baa-4528-8bc6-6ce20030e391@oss.qualcomm.com> <805525cb-ef53-4bdd-a73b-6fe7513228ce@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <805525cb-ef53-4bdd-a73b-6fe7513228ce@oss.qualcomm.com> On Mon, Mar 09, 2026 at 12:47:33PM +0100, Konrad Dybcio wrote: > On 3/9/26 11:04 AM, Sibi Sankar wrote: > > On 3/9/2026 2:33 PM, Stephan Gerhold wrote: > >> On Mon, Mar 09, 2026 at 05:06:43AM +0530, Sibi Sankar wrote: > >>> Add Embedded controller driver support for Hamoa/Purwa/Glymur qualcomm > >>> reference boards. It handles fan control, temperature sensors, access > >>> to EC state changes and supports reporting suspend entry/exit to the > >>> EC. > >>> > >>> Co-developed-by: Maya Matuszczyk > >>> Signed-off-by: Maya Matuszczyk > >>> Signed-off-by: Sibi Sankar > >>> --- > >>>   MAINTAINERS                            |   7 + > >>>   drivers/platform/arm64/Kconfig         |  12 + > >>>   drivers/platform/arm64/Makefile        |   1 + > >>>   drivers/platform/arm64/qcom-hamoa-ec.c | 462 +++++++++++++++++++++++++ > >>>   4 files changed, 482 insertions(+) > >>>   create mode 100644 drivers/platform/arm64/qcom-hamoa-ec.c > >>> > >>> [...] > >>> diff --git a/drivers/platform/arm64/qcom-hamoa-ec.c b/drivers/platform/arm64/qcom-hamoa-ec.c > >>> new file mode 100644 > >>> index 000000000000..83aa869fad8f > >>> --- /dev/null > >>> +++ b/drivers/platform/arm64/qcom-hamoa-ec.c > >>> @@ -0,0 +1,462 @@ > >>> [...] > >>> +/* > >>> + * Fan Debug control command: > >>> + * > >>> + * Command Payload: > >>> + * ------------------------------------------------------------------------------ > >>> + * | Offset    | Name        | Description                    | > >>> + * ------------------------------------------------------------------------------ > >>> + * | 0x00    | Command    | Fan control command                | > >>> + * ------------------------------------------------------------------------------ > >>> + * | 0x01    | Fan ID    | 0x1 : Fan 1                    | > >>> + * |        |        | 0x2 : Fan 2                    | > >>> + * ------------------------------------------------------------------------------ > >>> + * | 0x02    | Byte count = 4| Size of data to set fan speed            | > >>> + * ------------------------------------------------------------------------------ > >>> + * | 0x03    | Mode        | Bit 0: Debug Mode On/Off (0 - OFF, 1 - ON )    | > >>> + * |        |        | Bit 1: Fan On/Off (0 - Off, 1 - ON)        | > >>> + * |        |        | Bit 2: Debug Type (0 - RPM, 1 - PWM)        | > >>> + * ------------------------------------------------------------------------------ > >>> + * | 0x04 (LSB)    | Speed in RPM    | RPM value, if mode selected is RPM        | > >>> + * | 0x05    |        |                        | > >>> + * ------------------------------------------------------------------------------ > >>> + * | 0x06    | Speed in PWM    | PWM value, if mode selected is PWM (0 - 255)    | > >>> + * ______________________________________________________________________________ > >>> + * > >>> + */ > >>> +static int qcom_ec_fan_set_cur_state(struct thermal_cooling_device *cdev, unsigned long state) > >>> +{ > >>> +    struct qcom_ec_cooling_dev *ec_cdev = cdev->devdata; > >>> +    struct device *dev = ec_cdev->parent_dev; > >>> +    struct i2c_client *client = to_i2c_client(dev); > >>> + > >>> +    u8 request[6] = { ec_cdev->fan_id, EC_FAN_SPEED_DATA_SIZE, > >>> +              EC_FAN_DEBUG_MODE_ON | EC_FAN_ON | EC_FAN_DEBUG_TYPE_PWM, > >>> +              0, 0, state }; > >>> +    int ret; > >>> + > >>> +    ret = i2c_smbus_write_i2c_block_data(client, EC_FAN_DBG_CONTROL_CMD, > >>> +                         sizeof(request), request); > >> I think it's nice to provide users a way to override the fan speed, but > >> is this really the main interface of the EC that we want to use for > >> influencing the fan speed? > >> > >> As the name of the command suggests, this is a debug command that > >> essentially overrides the internal fan control algorithm of the EC. If > >> you use this to turn the fan off and then Linux hangs, I would expect > >> that the fan stays off until the device will eventually overheat. > >> > >> I think it would be more reliable if: > >> > >>   (1) The default mode of operation does not make use of the "debug mode" > >>       command and instead sends the internal SoC temperatures to the EC > >>       to help optimize the fan control. (This is what Windows does on > >>       Hamoa, not sure if this is still needed on Glymur?) > > > > That's true, Glymur already has a way to access average SoC > > temperature and even on Hamoa it can still be functional without > > SoC temperature i.e. with thermistors it has access to. > > > > The aim of the series is to expose fans as a cooling device so > > that linux has a way of fan control independent to the algorithm > > running on the EC. > > I suppose the main question here is "what happens if i set the fan to zero > and put the laptop in my backpack" > > The driver for M-series Macs for example, 785205fd8139 ("hwmon: Add Apple > Silicon SMC hwmon driver") hides that behind a cmdline param, since they > have no certainty. I would *assume* that if the CPU hits thermal junction > temperatures, our boards will reset, but we should be able to get a definitive > answer here. > The CPUs should automatically throttle when reaching high temperatures and Linux should also do this for the GPU. So the chance of reaching a overtemperature state should be low as long as Linux correctly functions. The biggest risk would be probably if Linux hangs, the watchdog doesn't trigger and the machine is stuck in some state. As for the hardware shutdown temperature, see commit 03f2b8eed73 ("arm64: dts: qcom: x1e80100: Apply consistent critical thermal shutdown"): "The firmware configures the TSENS controller with a maximum temperature of 120°C. When reaching that temperature, the hardware automatically triggers a reset of the entire platform." The question is if you really want your device to hit 120°C. :-) Thanks, Stephan