From: Andrew Lunn <andrew@lunn.ch>
To: Simon Horman <simon.horman@corigine.com>
Cc: Lukasz Majewski <lukma@denx.de>,
Heiner Kallweit <hkallweit1@gmail.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: smsc: Implement .aneg_done callback for LAN8720Ai
Date: Thu, 6 Apr 2023 16:19:31 +0200 [thread overview]
Message-ID: <aa6415be-e99b-46df-bb3b-d2c732a33f31@lunn.ch> (raw)
In-Reply-To: <ZC7Nu5Qzs8DyOfQY@corigine.com>
On Thu, Apr 06, 2023 at 03:48:43PM +0200, Simon Horman wrote:
> On Thu, Apr 06, 2023 at 03:11:27PM +0200, Lukasz Majewski wrote:
> > The LAN8720Ai has special bit (12) in the PHY SPECIAL
> > CONTROL/STATUS REGISTER (dec 31) to indicate if the
> > AutoNeg is finished.
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
>
> Hi Lukasz,
>
> I think you need to rebase this on net-next.
>
> If you repost please also include 'net-next' in the subject:
> [PATCH net-next v2].
>
> And a note about the changes between v1 and v2.
This actually seems like a fix. So it should probably be based on net,
and have a Fixes: tag.
Lukasz, how does this bit differ to the one in BMSR? Is the BMSR bit
broken? Is there an errata for this? It would be good to describe the
problem you see which this patch fixes.
Andrew
next prev parent reply other threads:[~2023-04-06 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 13:11 Lukasz Majewski
2023-04-06 13:48 ` Simon Horman
2023-04-06 14:19 ` Andrew Lunn [this message]
2023-04-12 11:25 ` Lukasz Majewski
2023-04-12 13:34 ` Andrew Lunn
2023-04-12 14:12 ` Lukasz Majewski
2023-04-12 13:47 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6415be-e99b-46df-bb3b-d2c732a33f31@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®