From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
kvalo@codeaurora.org, hante.meuleman@broadcom.com,
franky.lin@broadcom.com, wright.feng@cypress.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com
Subject: Re: [PATCH 11/11] net: brcmfmac: constify pci_device_id.
Date: Mon, 17 Jul 2017 21:21:12 +0200 [thread overview]
Message-ID: <aa683182-5d94-1b63-2c22-fec3775ae7d3@broadcom.com> (raw)
In-Reply-To: <1500315402-3439-1-git-send-email-arvind.yadav.cs@gmail.com>
On 17-07-17 20:16, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> index f878706..e6e9b00 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> @@ -1951,7 +1951,7 @@ static const struct dev_pm_ops brcmf_pciedrvr_pm = {
> BRCM_PCIE_VENDOR_ID_BROADCOM, dev_id,\
> subvend, subdev, PCI_CLASS_NETWORK_OTHER << 8, 0xffff00, 0 }
>
> -static struct pci_device_id brcmf_pcie_devid_table[] = {
> +static const struct pci_device_id brcmf_pcie_devid_table[] = {
> BRCMF_PCIE_DEVICE(BRCM_PCIE_4350_DEVICE_ID),
> BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
> BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
>
next prev parent reply other threads:[~2017-07-17 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 18:16 Arvind Yadav
2017-07-17 19:21 ` Arend van Spriel [this message]
2017-07-28 15:04 ` [11/11] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa683182-5d94-1b63-2c22-fec3775ae7d3@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®