Re: [PATCH v2 5/5] phy: qcom: qmp-usbc: Add qmp configuration for QCS615

[Tingwei Zhang <quic_tingweiz@quicinc.com>]

On 10/18/2024 2:27 AM, Dmitry Baryshkov wrote:
> On Thu, 17 Oct 2024 at 16:07, Krishna Kurapati
> <quic_kriskura@quicinc.com> wrote:
>>
>> Provide PHY configuration for the USB QMP PHY for QCS615 Platform.
>>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> After checking platform details,
> 
> Unreviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> Please perform global s/QCS615/SM6150/ and s/qcs615/sm6150/

QCS615 and SM6150 are different variants of the same SoC. QCS615 is an 
IoT variant, while SM6150 is a mobile variant. We are currently adding 
QCS615 SoC support to the upstream Kernel, as it is in an active 
development stage and we anticipate many products based on this SoC. On 
the other hand, the SM6150 is an older mobile platform that is unlikely 
to be used in new designs. For a product introduction of the QCS615, 
please refer to 
https://docs.qualcomm.com/bundle/publicresource/87-83838-1_REV_A_Qualcomm_IQ6_Series_Product_Brief.pdf

> 
>> ---
>>   drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
>> index d4fa1063ea61..c56ba8468538 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
>> @@ -1123,6 +1123,9 @@ static const struct of_device_id qmp_usbc_of_match_table[] = {
>>          }, {
>>                  .compatible = "qcom,qcm2290-qmp-usb3-phy",
>>                  .data = &qcm2290_usb3phy_cfg,
>> +       }, {
>> +               .compatible = "qcom,qcs615-qmp-usb3-phy",
>> +               .data = &qcm2290_usb3phy_cfg,
>>          }, {
>>                  .compatible = "qcom,sdm660-qmp-usb3-phy",
>>                  .data = &sdm660_usb3phy_cfg,
>> --
>> 2.34.1
>>
> 
> 


-- 
Thanks,
Tingwei