From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25012C4332F for ; Tue, 13 Dec 2022 16:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235754AbiLMQYy (ORCPT ); Tue, 13 Dec 2022 11:24:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235729AbiLMQYv (ORCPT ); Tue, 13 Dec 2022 11:24:51 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A688CF15 for ; Tue, 13 Dec 2022 08:24:48 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id x11so3810763ljh.7 for ; Tue, 13 Dec 2022 08:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O9lhRP4vwAQazbZFW3dbqSAS6PGTLh/z2McBocENAxg=; b=StN78XuDZ9jj1i9eK3S9SBvR9+DQ2yT1cAXKfaF3wiZNHteupurkIEjCDfQsie+nOx m+lzMiRaA/KoTZ1zKakBMxCP9UljE6gxK6H4eZk5cmjUUK2TWeNBvZohW2Y8kkiJ2u0F hryC9P2VnwBNClgSjD5K/iOX0ZoVOpf0JqyTSZZfNGk3P7wAA/amsjAQ7j+2ahGmK5UB hD7RPxot2KvtUiRqxA33D2cIJR4g1JipBaZHxMN6AEswJm1bSmE8Gp56B0eRNnhyTaL0 XUitJBPuY/TKmJtMKZudqrFB8atIlThip42tfXdK7jPdrk0JJ6Khq24QUgG7yyV2Gz55 lwPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O9lhRP4vwAQazbZFW3dbqSAS6PGTLh/z2McBocENAxg=; b=iKNcF4EE5WqoEepQRoidAunTjt9tOHBrqsWvtSQPS+69cOvnRHVteobnxojCV6L/W5 vFwDsKgj/+byYbJJnX0mHb1pE1Cs9qD3Ialt9oxKevDR8Vx3dCK9OabSR165y+NYkiNb 9vTDzuWTlRTmHdtRU5I5oKTI8LV0qJalzPpIycc+xGsZmoOKDL26zv4d2BFbjItHDslm 7G4qmMIBY2JsdADAX3to54+hEs7p9tlqWT3qza0DI3RGGs88QL8z3XbdEBGWMNx6kkDN OX8QOgqAeNygHgKlXreLLXDLNeP3kFqSmSOYE6gjhPj2+DVF4c0SALNed6K9OyPKbwVd yrLw== X-Gm-Message-State: ANoB5plEbw1SCLSLC2mJn5QhcYAQuuqnfQwTGMO34T0rYY003imEjtcC JEpwKlD/fKaqEHyq9UukRKQf/Q== X-Google-Smtp-Source: AA0mqf4bRoay6xz9loy59VEgInoVuNzqbHi1bApLvPMco1RzkoH6wFH02p9JxKHi+zAXV8Yy5LPjyw== X-Received: by 2002:a05:651c:234:b0:279:e86c:7101 with SMTP id z20-20020a05651c023400b00279e86c7101mr5275011ljn.8.1670948687046; Tue, 13 Dec 2022 08:24:47 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id f9-20020a05651c03c900b0027b65f34947sm144620ljp.1.2022.12.13.08.24.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 08:24:46 -0800 (PST) Message-ID: Date: Tue, 13 Dec 2022 17:24:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 02/13] dt-bindings: arm: msm: Fix register regions used for LLCC banks Content-Language: en-US To: Manivannan Sadhasivam , andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: quic_saipraka@quicinc.com, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, stable@vger.kernel.org References: <20221212123311.146261-1-manivannan.sadhasivam@linaro.org> <20221212123311.146261-3-manivannan.sadhasivam@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221212123311.146261-3-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2022 13:33, Manivannan Sadhasivam wrote: > Register regions of the LLCC banks are located at separate addresses. > Currently, the binding just lists the LLCC0 base address and specifies > the size to cover all banks. This is not the correct approach since, > there are holes and other registers located in between. > > So let's specify the base address of each LLCC bank and get rid of > reg-names property as it is not needed anymore. It should be noted that > the bank count differs for each SoC, so that also needs to be taken into > account in the binding. > > Cc: # 4.19 > Fixes: 7e5700ae64f6 ("dt-bindings: Documentation for qcom, llcc") > Reported-by: Parikshit Pareek > Signed-off-by: Manivannan Sadhasivam > --- > .../bindings/arm/msm/qcom,llcc.yaml | 97 ++++++++++++++++--- > 1 file changed, 83 insertions(+), 14 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml > index d1df49ffcc1b..260bc87629a7 100644 > --- a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml > @@ -33,14 +33,8 @@ properties: > - qcom,sm8550-llcc > > reg: > - items: > - - description: LLCC base register region > - - description: LLCC broadcast base register region > - > - reg-names: > - items: > - - const: llcc_base > - - const: llcc_broadcast_base > + minItems: 2 > + maxItems: 9 > > interrupts: > maxItems: 1 > @@ -48,7 +42,76 @@ properties: > required: > - compatible > - reg > - - reg-names > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sc7180-llcc > + - qcom,sm6350-llcc > + then: > + properties: > + reg: > + items: > + - description: LLCC0 base register region > + - description: LLCC broadcast base register region > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sc7280-llcc > + then: > + properties: > + reg: > + items: > + - description: LLCC0 base register region > + - description: LLCC1 base register region > + - description: LLCC broadcast base register region This will break all existing users (all systems, bootloaders/firmwares), so you need to explain that in commit msg - why breaking is allowed, who is or is not going to be affected etc. Otherwise judging purely by bindings this is an ABI break. Reason "This is not the correct approach since, there are holes and other registers located in between." is not enough, because this suggests previous approach was just not the best and you have something better. Better is not a reason for ABI break. > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sc8180x-llcc > + - qcom,sc8280xp-llcc > + then: > + properties: > + reg: > + items: > + - description: LLCC0 base register region > + - description: LLCC1 base register region > + - description: LLCC2 base register region > + - description: LLCC3 base register region > + - description: LLCC4 base register region > + - description: LLCC5 base register region > + - description: LLCC6 base register region > + - description: LLCC7 base register region > + - description: LLCC broadcast base register region > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sdm845-llcc > + - qcom,sm8150-llcc > + - qcom,sm8250-llcc > + - qcom,sm8350-llcc > + - qcom,sm8450-llcc > + then: > + properties: > + reg: > + items: > + - description: LLCC0 base register region > + - description: LLCC1 base register region > + - description: LLCC2 base register region > + - description: LLCC3 base register region > + - description: LLCC broadcast base register region > > additionalProperties: false > > @@ -56,9 +119,15 @@ examples: > - | > #include > > - system-cache-controller@1100000 { > - compatible = "qcom,sdm845-llcc"; > - reg = <0x1100000 0x200000>, <0x1300000 0x50000> ; > - reg-names = "llcc_base", "llcc_broadcast_base"; > - interrupts = ; > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + system-cache-controller@1100000 { > + compatible = "qcom,sdm845-llcc"; Inconsistent indentation for DTS example. Use 4 spaces for it. > + reg = <0 0x01100000 0 0x50000>, <0 0x01180000 0 0x50000>, > + <0 0x01200000 0 0x50000>, <0 0x01280000 0 0x50000>, > + <0 0x01300000 0 0x50000>; > + interrupts = ; > + }; > }; Best regards, Krzysztof