From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935220AbcI3AVQ (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Sep 2016 20:21:16 -0400
Received: from mga06.intel.com ([134.134.136.31]:8972 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S935085AbcI3AVK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Sep 2016 20:21:10 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,417,1473145200"; 
   d="scan'208";a="14819683"
Subject: Re: [PATCH] include/linux/property.h: fix typo/compile error
To: John Youn <johnyoun@synopsys.com>
References: <2de3b929290d88a723ed829a3e3cbd02044714df.1475114627.git.johnyoun@synopsys.com>
Cc: linux-kernel@vger.kernel.org, Hanjun Guo <hanjun.guo@linaro.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
Message-ID: <aa6a6ed6-345f-8505-368f-6447f699493f@intel.com>
Date: Fri, 30 Sep 2016 02:21:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <2de3b929290d88a723ed829a3e3cbd02044714df.1475114627.git.johnyoun@synopsys.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/29/2016 4:10 AM, John Youn wrote:
> This fixes commit d76eebfa175e ("include/linux/property.h: fix build
> issues with gcc-4.4.4").
>
> With that commit we get the following compile error when using the
> PROPERTY_ENTRY_INTEGER_ARRAY macro.
>
> ../include/linux/property.h:201:39: error: ‘u32_data’ undeclared (first
>                   use in this function)
>    PROPERTY_ENTRY_INTEGER_ARRAY(_name_, u32, _val_)
>                                         ^
> ../include/linux/property.h:193:17: note: in definition of macro
>                   ‘PROPERTY_ENTRY_INTEGER_ARRAY’
>    { .pointer = { _type_##_data = _val_ } },  \
>                   ^
>
> This needs a '.' to reference the union member. It seems this was just
> overlooked here since it is done correctly in similar constructs in
> other parts of the original commit.
>
> This fix is in preparation of upcoming commits that will use this macro.
>
> Fixes: commit d76eebfa175e ("include/linux/property.h: fix build issues with gcc-4.4.4")
> Signed-off-by: John Youn <johnyoun@synopsys.com>

Applied.

Thanks,
Rafael


> ---
>   include/linux/property.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 3a2f9ae..856e50b 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -190,7 +190,7 @@ struct property_entry {
>   	.length = ARRAY_SIZE(_val_) * sizeof(_type_),		\
>   	.is_array = true,					\
>   	.is_string = false,					\
> -	{ .pointer = { _type_##_data = _val_ } },		\
> +	{ .pointer = { ._type_##_data = _val_ } },		\
>   }
>   
>   #define PROPERTY_ENTRY_U8_ARRAY(_name_, _val_)			\