From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sirat <email@sirat.me>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: proximity: add driver for ST VL53L1X ToF sensor
Date: Mon, 9 Mar 2026 13:29:54 +0200 [thread overview]
Message-ID: <aa6vMjKwcjYAE9xN@ashevche-desk.local> (raw)
In-Reply-To: <CANn+LWKVJgXTTyd4usZcaAzvws1DvzFuQ2Lm9f8xa82SU36DDA@mail.gmail.com>
On Mon, Mar 09, 2026 at 04:27:22PM +0600, Sirat wrote:
> On Mon, Mar 9, 2026 at 3:08 AM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Sun, Mar 08, 2026 at 05:37:28PM +0600, Siratul Islam wrote:
> > > Add support for the STMicroelectronics VL53L1X Time-of-Flight
> > > ranging sensor with I2C interface.
> >
> > I'm sorry, I missed cover letter, but can you remind if it has the explanation
> > that brand new driver is needed because of ...?
>
> Thanks for the review. The existing VL53L0X is very different from the
> VL53L1X despite
> similar naming. Trying to extend the existing driver would mean
> rewriting most of it.
>
> The VL53L1X has a different register map (16-bit addresses vs 8-bit),
> requires a 91-byte firmware blob at boot, has a VHV calibration cycle,
> and distance
> mode/timing budget configuration that doesn't exist on the L0X at all.
> Also, newer
> abstractions like regmap instead of raw i2c_smbus.
>
> I'll make sure to add the info on the v3 cover letter. The rest of the
> review I will address on v3.
Sure, but have you checked also other drivers? Sometimes the chips are designed
based on the ones from acquired companies or licensed IPs. Please, be sure you
checked also other drivers in the same subfolder (sometimes we have even cross
cases, when the IP is multi-functional and parts of it are already done as other
drivers in different subfolders, but I don't think this is the case you have).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-03-09 11:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 11:37 [PATCH v2 0/2] " Siratul Islam
2026-03-08 11:37 ` [PATCH v2 1/2] dt-bindings: iio: proximity: add " Siratul Islam
2026-03-09 7:31 ` Krzysztof Kozlowski
2026-03-08 11:37 ` [PATCH v2 2/2] iio: proximity: add driver for " Siratul Islam
2026-03-08 21:08 ` Andy Shevchenko
2026-03-09 10:27 ` Sirat
2026-03-09 11:29 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6vMjKwcjYAE9xN@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®