From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793093518; b=J6SWAwIaB0C5VV/Qcvb6EY2xne+vjYrumujqHzg3Y0q4YPFFWRreLjr0OMKXVZ8s4ukF cnF4qUe5jMRaO42DY1KTS2+qZ9UEwadehdrTa7+uMNbZVQFFm8Fi6CIyahq/dgKkCPrk9 iH5iaiM5B/QqLDMGv0CgT60fdV5bAXIl6PnIDG4fkKTdVCFuLZylOMg10mHZ2MmP5Qfmv kjnZeDqJQ+O0Ccv9QtQP67P0r8VS/4birF88wqwWl4SebELTx9YDy2mPh8ZTqkG92rC5B wKF+FWa1rCctaYiBZd6sAsXhHfSm5XX13IB2SKXnZZD91jXxym2ap/j/RFYQ4PoPvQw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793093518; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-GUID:X-Proofpoint-Spam-Info:X-Authority-Analysis: X-Proofpoint-ORIG-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=tMas7QgfTczyZxXDj1TfoR+MSTG6n9DPxh649aqtWyg=; b=yS9u7UAMmt3/DrglyVfvXCBEGdnnacmNbL6qxNb1/ae0pkJEfRaKRLhbAZYUTmtc2rvt EdeC/Pj+V2cDmHoQgS7UhW2neUfv1avtTZnkWrp+MJqP5dRf8dMBTe67DaqvFm+ngfngn jOA+UaMf90YID/XNkVCgF0Df1XFsPw9e4BpXgcCflTMMmHIgTeFLUFgmkqtXf+69gfHP+ HAl7pilNjaQ9pESnD0NZMj4Khf7ItcPH7YlWJrL9D6MZR9CJkni/Wx6vggJmw8NUN3zEM tpi+k8DFHNAfgyk923O4j78CHbS2LujiVYW+48tzdDkwhIgoZBdOXb29RS2NTLQ+WGA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=d18HWBTK; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=PNfisHcf; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C117606A332 for ; Tue, 27 Oct 2026 09:31:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5C117606A332 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=d18HWBTK; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=PNfisHcf Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69R8fwhH2259207 for ; Tue, 27 Oct 2026 09:31:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tMas7QgfTczyZxXDj1TfoR+MSTG6n9DPxh649aqtWyg=; b=d18HWBTK5yk45lzr b74uArz3Zh8QM210ZHXY3jNxD1DCFe02CJCPjrPzNP/yrxbduO9Ow9Fq0JWhIPa1 UYJ8yDexkkqlt/YNcxfPcug/zxVpK4fuewgkE/D0pI0HezeqNzXsiZV9SOYl/kg7 MyDWAjvKwKTv4pI/uqLGGN7+uF5ncjUff0BjHqLmPJCF7r2Ej6rStwKuvQ9vYJQc WcUQYFdIGfUbA7pehc/5hfZ3/DM4tey/XlA9xXZwXpY7O9Pweu46EFGPRTzHrAv4 1H5hC4OBkBBLOawipZ1X+GwKDkuYVt/++g+hgNdV5+GuMBuxXyvL1OQARwyb3prD 1iknbA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hjqw20cw2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Oct 2026 09:31:56 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3adcb81f487so6322071a91.3 for ; Tue, 27 Oct 2026 02:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793093515; x=1793698315; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tMas7QgfTczyZxXDj1TfoR+MSTG6n9DPxh649aqtWyg=; b=PNfisHcfqdT/aw10V8FuDSN/N7ru/Pm2ELzncld3ywghxh1YLdIg5r4QgNkUNkhbgu d8cyT3jpVfZ/Xc9+H5i31TZa7vEB8Sm+MC9QoX/tbV3ZtxEYhM5E6QDSfTXuxYmFuCr8 vGkfpK3iHU/VBJhRgRDcn+LDeA6lvqOTlaDWJBjGM6ku6gz6jP6hDHXTEHN0mYXsc/yI Mc95Kcv/+7f72cANGfv+NcZA7rRfPspvqtqizjV2DyPpat7cvvxx2F86XEKK2O5Throi faB2OStN+D6GKOwMNus7frAT90+ymb9go171GRApQsZBXygOI2ynC1g91ULp5lURoP0W tfLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793093515; x=1793698315; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tMas7QgfTczyZxXDj1TfoR+MSTG6n9DPxh649aqtWyg=; b=HkDjln2jhoFU04xOjNEivR9J+nz1cbT7ua5IRMGhmuYD6/et+jLv/lbULCBZV6fJ+m 5toolRfdH8M6Xur9A1VVu9W45G/TKMOzbnNi0d+VHkbNg3KAeB9W1n8R82eODmDYCdWL ffcY7pJDpuggP4A6leKlwtdSplxrveW/aOUeqrJQD+IXCHoOsaTSO/lVKI5u4aNP/c7X 4ygY58bdMjCPnV2FdfiRPZRDi/1tKrm80CWiRVxE1w9Z4vctp6CX5fDBklOrlj8JsW8s BgZXuebckioIcFJFYHt9St4b5rD+jUwuMMkslOzyRCKzDJOAqi3dT/QEXXBRhR2fe2Go 8fpA== X-Forwarded-Encrypted: i=1; AKwUvBwEB5oBgcqZWjooaJveovNTdiVhXNK7Q2/GpnWzTqXTkngaMJ7sEh3DiWc7DQ6JKcpUp12X/Iq+ztCKCvI=@vger.kernel.org X-Gm-Message-State: AFq9FYKqh1ufgKGw4VhXKf7ElG8OGI2ikOLJvKeCguVX50pmiaJFRECm FLoJlamdbRZ5j/90ULleRaRdjCC/vUD2KKFa30cP1PZHsDsAPi0e3WIsRll0rAP+QpNZR3rNhhu t52CsNYXhjbyKII7oGrV652YDc6XVP12wYAuc8QU60v+brdFhBc9HE0IJ1FIA9Fv7ZxQ= X-Gm-Gg: AYBFou2utPChwwmRAl2uw9BPmnBz4w1+zuW/aWeAQtWdsyzrj2JFM0Vw+jhW+hTbV/r qVbXcQEZEaAyFZ10DP3Z+d0Jv1h9NzgKSWqj3sZjfGBFQ5XSdFtCppRaMyTeRutJbz1LbynyrT3 aFOfvuvKMWsipFcavcuVh5jRW5tsIOncTr4yQNoKm2ritjMaUcSXU4w5SC4C6PVZIb4t/rHg2H2 Oj0e0moSEp4vXrF20vRCZiDys1IUGI0YB9vyOK0GYzCM6fZP5g4Db3NFJDEuXgTAQm8KEhCmHYz CAaA6FlSmTQchBl5ZYQF2tk3YfiIa1EJD+OfBVnugXruh3Y5yLwETmuhydY99P6aPqRwg6GtP/O Ug02NK4W2cdmUqKAwFe1zONOdLHsxl5AN6gB7pH2hWbfUe8mJUdaoSXoJyLzRu1oB/uRxIR96M4 RqpTwZ X-Received: by 2002:a17:90b:164e:b0:3a5:147a:3b63 with SMTP id 98e67ed59e1d1-3ade9b2ee37mr8269747a91.8.1793093515010; Tue, 27 Oct 2026 02:31:55 -0700 (PDT) X-Received: by 2002:a17:90b:164e:b0:3a5:147a:3b63 with SMTP id 98e67ed59e1d1-3ade9b2ee37mr8269724a91.8.1793093514545; Tue, 27 Oct 2026 02:31:54 -0700 (PDT) Received: from [10.204.101.238] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3adeba47266sm6423275a91.1.2026.10.27.02.31.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2026 02:31:53 -0700 (PDT) Message-ID: Date: Tue, 27 Oct 2026 15:01:41 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/8] media: iris: migrate firmware loading to qcom_mdt_pas_load() and qcom_pas_prepare_and_auth_reset() To: Mukesh Ojha , Sumit Garg , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , David Airlie , Simona Vetter , Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier Cc: Abel Vesa , Sean Paul , Akhil P Oommen , Abhinav Kumar , Jessica Zhang , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org References: <20260925155737.4161358-1-mukesh.ojha@oss.qualcomm.com> <20260925155737.4161358-4-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Gourav Kumar In-Reply-To: <20260925155737.4161358-4-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI3MDAzNyBTYWx0ZWRfX7I5ETh7gfw57 YOjG6C+xV753yzaKk7EbxtZc1yBglHeGHYk661BgWtcrUXUhYXP1ljQQl1I3SiiBvSTenLypcoq J/lPxvlKdee9E1WCQ0Xrz/3GkUR/6mhxpcYzakmAAAsx71k6TYRMkZb8c5+E8SMfczOXF7lZNk/ IGIj565qAKxrFROPPDtsYRGLwD4uvDBs/P9HTaOdE6XUcEDIK1ch8VkMnUFNoD57ZlbcZJQBmnT tu7w7cI109aatn2IEiALWMr/XUmrnNNX4bghlpRxylmYSyEtsnqTF3t5J3N+U+Ckqg2F0bGHAU7 0stuqq8z5UEQSffYaIFDodr28Jgmn/IinVm5fIHhXm6Tg41W7pnR7iDVljhQqFAkc9BnDSAJUzb 6vFEM4a5wuKnWW8mw2RzXWFbrAwMVNlz7Nz/pnHyZRVbLsJfdMQ1PFIhO2LjMclhjxbDTD06AYu wAlPiDwWDUcZ9HGaq+w== X-Proofpoint-GUID: 77V96looK5lYHHqqp5JB7ID5CJTx0ZdH X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI3MDAzNyBTYWx0ZWRfXw4UIFlx3e+WZ C7y25+XEedbqswQMhrUccg4VVX2STEO1Pbk16HXg+OCCj8zXlvm87nvIs1u/qubTQojed+Da4aE 5bu1cHnMONCpj6bha45PpnZnCPtsd5g= X-Authority-Analysis: v=2.4 cv=PsYG/AM3 c=1 sm=1 tr=0 ts=6ae06f8c cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=nYfwElOfYSAnSMmgWPMA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: 77V96looK5lYHHqqp5JB7ID5CJTx0ZdH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-27_02,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610270037 On 9/25/2026 9:27 PM, Mukesh Ojha wrote: > iris_load_fw_to_memory() calls qcom_mdt_load() which bundles metadata > init, memory setup, and segment loading with no PAS context, and > iris_fw_load() calls qcom_pas_auth_and_reset() which skips the shmbridge > prepare step required before TrustZone authentication. > > Since the auth call is in a different function from where the PAS context > is allocated, add a pas_ctx pointer to struct iris_core so it can be > threaded between the two call sites. Replace qcom_mdt_load() with > devm_qcom_pas_context_alloc() and qcom_mdt_pas_load() in > iris_load_fw_to_memory(), storing the context in core->pas_ctx, then > pass it to qcom_pas_prepare_and_auth_reset() in iris_fw_load(). > > Signed-off-by: Mukesh Ojha > --- > drivers/media/platform/qcom/iris/iris_core.h | 2 ++ > .../media/platform/qcom/iris/iris_firmware.c | 20 ++++++++----------- > 2 files changed, 10 insertions(+), 12 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_core.h b/drivers/media/platform/qcom/iris/iris_core.h > index 24da60448cf2..68e6adcc1dfd 100644 > --- a/drivers/media/platform/qcom/iris/iris_core.h > +++ b/drivers/media/platform/qcom/iris/iris_core.h > @@ -8,6 +8,7 @@ > > #include > #include > +#include > #include > > #include "iris_hfi_common.h" > @@ -123,6 +124,7 @@ struct iris_core { > /* encoder and decoder have overlapping caps, so two different arrays are required */ > struct platform_inst_fw_cap inst_fw_caps_dec[INST_FW_CAP_MAX]; > struct platform_inst_fw_cap inst_fw_caps_enc[INST_FW_CAP_MAX]; > + struct qcom_pas_context *pas_ctx; > }; > > int iris_core_init(struct iris_core *core); > diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c > index 21cdf1c39835..e73a5dd98b88 100644 > --- a/drivers/media/platform/qcom/iris/iris_firmware.c > +++ b/drivers/media/platform/qcom/iris/iris_firmware.c > @@ -115,9 +115,7 @@ static int iris_load_fw_to_memory(struct iris_core *core) > struct resource res; > phys_addr_t mem_phys; > const char *fw_name; > - size_t res_size; > ssize_t fw_size; > - void *mem_virt; > int ret; > > ret = of_reserved_mem_region_to_resource(dev->of_node, 0, &res); > @@ -125,7 +123,6 @@ static int iris_load_fw_to_memory(struct iris_core *core) > return ret; > > mem_phys = res.start; > - res_size = resource_size(&res); > > firmware = iris_detect_firmware(core, &fw_name); > if (IS_ERR(firmware)) > @@ -134,21 +131,20 @@ static int iris_load_fw_to_memory(struct iris_core *core) > core->iris_firmware_data = core->iris_firmware_desc->firmware_data; > > fw_size = qcom_mdt_get_size(firmware); > - if (fw_size < 0 || res_size < (size_t)fw_size) { > + if (fw_size < 0 || resource_size(&res) < (size_t)fw_size) { > ret = -EINVAL; > goto err_release_fw; > } > > - mem_virt = memremap(mem_phys, res_size, MEMREMAP_WC); > - if (!mem_virt) { > - ret = -ENOMEM; > + core->pas_ctx = devm_qcom_pas_context_alloc(dev, IRIS_PAS_ID, mem_phys, > + resource_size(&res)); > + if (IS_ERR(core->pas_ctx)) { > + ret = PTR_ERR(core->pas_ctx); > + core->pas_ctx = NULL; > goto err_release_fw; > } > > - ret = qcom_mdt_load(dev, firmware, fw_name, > - IRIS_PAS_ID, mem_virt, mem_phys, res_size, NULL); > - > - memunmap(mem_virt); > + ret = qcom_mdt_pas_load(core->pas_ctx, firmware, fw_name, NULL); qcom_mdt_pas_load() passes the ctx to qcom_pas_init_image(), which keeps the metadata buffer in ctx->ptr, and qcom_pas_prepare_and_auth_reset() does not free it. Who is expected to call qcom_pas_metadata_release() for iris? I don't see it called after authentication (or on its failure), unlike in qcom_q6v5_pas.c. Gourav Kumar > err_release_fw: > release_firmware(firmware); > > @@ -166,7 +162,7 @@ int iris_fw_load(struct iris_core *core) > return ret; > } > > - ret = qcom_pas_auth_and_reset(IRIS_PAS_ID); > + ret = qcom_pas_prepare_and_auth_reset(core->pas_ctx); ctx->use_tzmem is not set for iris, so the shmbridge creation in qcom_scm_pas_prepare_and_auth_reset() is skipped and the behaviour is the same as the old qcom_pas_auth_and_reset(). Please reword the commit message accordingly, since it currently implies that the prepare step is now performed by the new API as a fix. Gourav Kumar > if (ret) { > dev_err(core->dev, "auth and reset failed: %d\n", ret); > return ret;