From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74A1323394B for ; Wed, 20 May 2026 13:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779283980; cv=none; b=lsXRQ0nq0BWxzIGPzrwiCqBFpY96W39hM0DrBXTpht4QPyYYeQBVEtbVHlBbA9XxiMWFeaZ+IAs/aXgCIdA55JPEJ7ZlzK1weH3zdXrSAEvvlzxrKDeUgDMJmHteh+zf7LVNgnRKPb5pUtlqrvMuJ2FchRWf6WAgKm223jiu58s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779283980; c=relaxed/simple; bh=nOnX5fFpX5kvVHAUEI/bnPHTiQkmScNvb5pOafPwrDs=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=CV7ZfbZdembRlu8BseqcvaPW+t27ETBQAPisJWy/NNmgxVTnV3elRVdzGfosLUcHygXHtaW2B8WZ3/A6/dVXIjM/bFEv4I60aV3J+GRPf6oWsdSS0rNOBBbE4pbGxY1QCDZyL4CGos/N+/MCzzNEQ7lYiStLqqXHde/uWlBjWiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jso61IMr; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jso61IMr" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-488ad135063so39491775e9.0 for ; Wed, 20 May 2026 06:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779283977; x=1779888777; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=NyR0lUExHVdJdV8G0OFN7AbJBHhKInSpK/sXFoV8qMM=; b=jso61IMr8OIVC1dRtopDlrlApQaugepRznCcin3xxHByDxegPGv7hAQMIrQEZsYLUt Krl72HphatBdV6jxXjekwxwcqudy92OWVTMgtXS4vN7Ev4JTGxlee+lwhAqdu2hlB0m8 au8rfEByf3JH2SrnwFzh3WpxYcx4T/vbcuQKNiQ7HE4lzssojSJGRCDU1oBP2ezAhqkm u+EoEWmKWKFLAsJI1FRCWEe2FbPqfeXi5AprqCZtM5As2/kR2oZskyYk2VOgmYrRKGUK zDrfEsNIezZ+ShyQ+ieGwhOFkJGTQlSWZV3DvLjUJ3XztaskwayG2kl0BF/PwAJTL35M AsIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779283977; x=1779888777; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NyR0lUExHVdJdV8G0OFN7AbJBHhKInSpK/sXFoV8qMM=; b=m58LlHISuDjLbCtjArj5PplGXQLk2MjJ5mZ3OZBkYjVzl2uSDDFyWniZysw1AZ0cRl wgCv40VbjvjHhqmn+t7hvBxtMIyWXPs8+DuUqWzXsp1zg7W7ohZEtKmOEdkNpj3kiILW uwPXxRUcCsBs0gYG4p+E079Y6pE68pfv4FBNCFnXSCQJsjKH96zWnUxKFEvEZJr4nVvQ Rs/OujXzpfur22CVPWek1dybjMsARqyVhm180+ZaA74SbrGVfYq9SK0EKr4jVp0F4kVv 8kzBYSIrtHMPva7kg8wOPC3but9tGnVqhyYd2oUzHVOk/X3oxwl+ul0vFwz/dvy603Uc iiuA== X-Forwarded-Encrypted: i=1; AFNElJ8jFS7tqaDs0UoS2NXddIgrkLeej8w7xs4hHAGwTFXXWkdGDGdkjkISS52ewAEjvjTnhF5eAlZtQrlcNlc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw52MZwAA5E5AjOYEWEF0xWa/LaXpOD/VYi27EzZNIQPXSZt6Sf WsDP1u76cXtTnj14V+XGAnZjULic1SBoUi+UQ0qFYDaW24B0BqhExLtvVKsd7gM6yes= X-Gm-Gg: Acq92OHiSdLqQi5jGHcyniM+mZlwfl/n4EwcuplMTUF4VAG1o7clV0dxiMIEbOsr91M 32Bp7cGimTIRVBzRvmRzIN20wjKbA79rtZI8AZepPjaa/vlNGSvfRVL23ZXnSicIpaGiK1Z7UKr 5U8Fn6Mp8ZXKkbCKVHsZupVUXSeySm1uS/xOQZYWr+/deLwmRTZCHvhUwMSPmWDurG1a9S2RHg9 kK/InomVaFfga/RcDaQeRyiHAiIQISzcI9kJtNFHRog1NvV4flFrH+ru/nqk4JQASJO8ke4K/lH 4JHX0HpHraIm/tT/AJLyyb1fTONj+MdyAYp4GiqnGlUbMINTFPc+muUFwMfMstjrTbezsac/h27 qV4aeKuO/KbcMWfhZ3hxlfDhkjcwsS16LB1/pCV9/PI/bdBbwVmrLjp2q/eIE/vl1O7UGsHm8c1 1dd7xthhSDxpPWelvoMmlrKVFu89pVknz7yJ3CxHCWe50eVZPa0FWzFJG9L0HB/9+bbfOtaN5pS g== X-Received: by 2002:a05:600c:5296:b0:48a:65ad:1881 with SMTP id 5b1f17b1804b1-48fe60ed846mr375637585e9.13.1779283976713; Wed, 20 May 2026 06:32:56 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:dec9:6d:b572:fe67? ([2a01:e0a:106d:1080:dec9:6d:b572:fe67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ed30110sm58585852f8f.13.2026.05.20.06.32.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 06:32:56 -0700 (PDT) Message-ID: Date: Wed, 20 May 2026 15:32:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 2/8] drm/bridge: dw-hdmi: Use the common TMDS char rate constant To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Maxime Ripard , Andrzej Hajda , Andy Yan , David Airlie , Dmitry Baryshkov , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Liu Ying , Luca Ceresoli , Maarten Lankhorst , Robert Foss , Shengjiu Wang , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20260519144712.1418302-1-javierm@redhat.com> <20260519144712.1418302-3-javierm@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260519144712.1418302-3-javierm@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/19/26 16:46, Javier Martinez Canillas wrote: > Replace the driver local HDMI14_MAX_TMDSCLK define with the shared > constant defined in the header. > > The local define incorrectly referenced HDMI 1.4, but the 340 MHz > maximum TMDS character rate was actually introduced in HDMI 1.3. > > Suggested-by: Maxime Ripard > Signed-off-by: Javier Martinez Canillas > --- > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 41b3a9cfa2f5..d7c0a599aa42 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -51,8 +51,6 @@ > /* DW-HDMI Controller >= 0x200a are at least compliant with SCDC version 1 */ > #define SCDC_MIN_SOURCE_VERSION 0x1 > > -#define HDMI14_MAX_TMDSCLK 340000000 > - > static const u16 csc_coeff_default[3][4] = { > { 0x2000, 0x0000, 0x0000, 0x0000 }, > { 0x0000, 0x2000, 0x0000, 0x0000 }, > @@ -1426,7 +1424,7 @@ void dw_hdmi_set_high_tmds_clock_ratio(struct dw_hdmi *hdmi, > > /* Control for TMDS Bit Period/TMDS Clock-Period Ratio */ > if (dw_hdmi_support_scdc(hdmi, display)) { > - if (mtmdsclock > HDMI14_MAX_TMDSCLK) > + if (mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) > drm_scdc_set_high_tmds_clock_ratio(hdmi->curr_conn, 1); > else > drm_scdc_set_high_tmds_clock_ratio(hdmi->curr_conn, 0); > @@ -1671,7 +1669,7 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, > } > > /* Wait for resuming transmission of TMDS clock and data */ > - if (mtmdsclock > HDMI14_MAX_TMDSCLK) > + if (mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) > msleep(100); > > return dw_hdmi_phy_power_on(hdmi); > @@ -2032,7 +2030,7 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, > /* Set up HDMI_FC_INVIDCONF */ > inv_val = (hdmi->hdmi_data.hdcp_enable || > (dw_hdmi_support_scdc(hdmi, display) && > - (vmode->mtmdsclock > HDMI14_MAX_TMDSCLK || > + (vmode->mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3 || > hdmi_info->scdc.scrambling.low_rates)) ? > HDMI_FC_INVIDCONF_HDCP_KEEPOUT_ACTIVE : > HDMI_FC_INVIDCONF_HDCP_KEEPOUT_INACTIVE); > @@ -2100,7 +2098,7 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, > > /* Scrambling Control */ > if (dw_hdmi_support_scdc(hdmi, display)) { > - if (vmode->mtmdsclock > HDMI14_MAX_TMDSCLK || > + if (vmode->mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3 || > hdmi_info->scdc.scrambling.low_rates) { > /* > * HDMI2.0 Specifies the following procedure: Reviewed-by: Neil Armstrong Thanks, Neil