From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C480DC2D0E4 for ; Tue, 24 Nov 2020 09:24:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 613182073C for ; Tue, 24 Nov 2020 09:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731046AbgKXJYC (ORCPT ); Tue, 24 Nov 2020 04:24:02 -0500 Received: from mga05.intel.com ([192.55.52.43]:39351 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728967AbgKXJYB (ORCPT ); Tue, 24 Nov 2020 04:24:01 -0500 IronPort-SDR: N6Ws2FGnDnjTIRIiR7Top/dnrV+duLZhKWVadB6XCrh3lTdwVWWJY/SrPQvnVZL0g9aZsl7Rli 9iKERktTvN+w== X-IronPort-AV: E=McAfee;i="6000,8403,9814"; a="256625862" X-IronPort-AV: E=Sophos;i="5.78,365,1599548400"; d="scan'208";a="256625862" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 01:24:01 -0800 IronPort-SDR: rzf+hTGb+Dv5gOBzH0BHWmnb4KqMg9C1xc/9bOizILZKW97lOyQ92i4cJtQFIejmDQWUtE0MTD Dqnlzv9Zfwvg== X-IronPort-AV: E=Sophos;i="5.78,365,1599548400"; d="scan'208";a="478438788" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.117]) ([10.239.13.117]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 01:23:58 -0800 Subject: Re: [kbuild-all] Re: sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here To: Andy Shevchenko , Dan Carpenter Cc: "Rojewski, Cezary" , Andy Shevchenko , lkp , "kbuild-all@lists.01.org" , "linux-kernel@vger.kernel.org" , Mark Brown References: <202011220325.oB7oeTEq-lkp@intel.com> <20201123105317.GZ4077@smile.fi.intel.com> <8cb2dcbdef2446238c6a1fe8e8b74504@intel.com> From: Rong Chen Message-ID: Date: Tue, 24 Nov 2020 17:23:09 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/24/20 5:13 PM, Andy Shevchenko wrote: > On Tue, Nov 24, 2020 at 10:06 AM Rong Chen wrote: >> On 11/23/20 7:41 PM, Rojewski, Cezary wrote: >>> On 2020-11-23 11:53 AM, Andy Shevchenko wrote: >>>> On Sun, Nov 22, 2020 at 03:52:27AM +0800, kernel test robot wrote: > ... > >>>> This sounds like false positive. From where it gets the idea of resource_size() >>>> for the *start* offset?! >>>> >>> Indeed it is false positive. I've already explained this in: >>> >>> RE: [bug report] ASoC: Intel: catpt: Firmware loading and context restore >>> https://www.spinics.net/lists/alsa-devel/msg117145.html >> Thanks a lot, we'll ignore the warning next time. > I think the proper solution here is to notify smatch upstream to fix the tool. > +Dan Carpenter Hi Dan, Could you take a look at this? the original report is at https://lore.kernel.org/lkml/202011220325.oB7oeTEq-lkp@intel.com/ Best Regards, Rong Chen