From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90A2D29BDB1 for ; Sat, 28 Mar 2026 11:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774697875; cv=none; b=o5/rBKfyaUr0hWMtv9PXTS3y1kXgDsY0Q2vD0YUJRjhNlD6FTTYhafuGR/+b6Ihg0MBHMAGI1HyrH2TgHSC6RxcQdt66dxNHyF2S+6aTNCedMXaYByAGV8tcolZOgla5oTAh5ABnD8zepzyQECnfGXJn1cyEWzIpHhKcZ8E5PdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774697875; c=relaxed/simple; bh=OjgkSIO2ad2NibMyUFh+sgUj3CG69zp0K+DcVr3S4Lk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sD9Oxed5vPFP3M++dHe21wdtcEVZwuF0tZ/JnTCACIElEIGUruwU200GPepnulRgYty0LXmr4c6d8FlMS5xxf8bywyOKHUbtlH5h4lbEF3wsJpCH7frviC/IxbxJg0x79NNJirzyXvSZxLpJeNMx7lOiDmavjI4aXrxBqdo+QJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eDrGyPgh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hQ+GQ1hj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eDrGyPgh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hQ+GQ1hj" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62S28WZ7854012 for ; Sat, 28 Mar 2026 11:37:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pFKLV1uuPMHuCXFEpJEzKwAbPMuwARFQ2NoKMHcpKbM=; b=eDrGyPghCbNIvNWD OqIVjLta3TwepWb8VuiM/5uj0WSxSyxci7QALthAEW6iO/k4n4YGOBbRJn+VssNM VjdHt7RdNlg4KGNVqFu8CKmrUfz56KQdiHFwOZk8YE55fiE8MGfjLrzCdwXgdTmS K+7gJbl07JuWoet3a9kmR5pUkHcmYsdRXBWlLy+JecaQtmJp3HocK++GLtOZPEe+ s5OOVm1xMzMaC9yvbwUHMJlZC/hNnCodNFyYWKYL3aoVjMH+8QCDdmBDgoaWmmsE HoQLFjHPOXlZKhpBLtmAysjaipwv0yzSJEfomanTX1BzZ79LdzEXyqigR+hBoOho 5ZoDcg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d65xqgudq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 28 Mar 2026 11:37:53 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2adef9d486bso59914765ad.2 for ; Sat, 28 Mar 2026 04:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774697873; x=1775302673; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pFKLV1uuPMHuCXFEpJEzKwAbPMuwARFQ2NoKMHcpKbM=; b=hQ+GQ1hjCSb8AH+SWiwjn95QUvv7MAF7s5fK295q5tfH0RTQoE1JsB1ogxsII52ybJ cI9DzwwnxHWHDpdZAaSfPQJfhVWEYe1peJh/mWctoP4nUkDF1W86lEpBFbCBb316nJ5f mtLBNMJ1z+p44G5uBrXjUn3A4BnJHS/0NLZWRSczqy2/L/H1havk9/DvsD0tAuqzVQlR iSGnm587fHiyFwRRPQWr+WhFKmVRxtTwmVaWOV1fvkThvaGCAmAfH0eAh/yQ9iO/Ge/O bh3UtNJUmCe3Zou0/s+qZQYc/aobA3Ro/IX34TYieaAYQvYb0wvIuhezSJhkXuRFMECZ j1PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774697873; x=1775302673; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pFKLV1uuPMHuCXFEpJEzKwAbPMuwARFQ2NoKMHcpKbM=; b=k5lyalAtcT52E9ZqN7BQbvsgLljobbmAdeWn7/RmCLMWTM/nZVOzCu5Sl/4lQ8IgWh ZTecD+zeL4g4nRsUu/GTZeV+yNCXF2DWyCIeqGC7IjQQx6iplSsEcBkUOq3EiYjuPl1J 0xPlao6X1h5+PGkfqWr+NViCyODOE8wvgeXPzcGF0xUG59i7O15f++2RNzMcKn6Gfay7 65QA/4K/+5iXrlEBTo7qnGlm4/b5J0i167ukgMFIkIqCNWSZ/1ZsmACKrKlzQdFkmUsw PzbE/+RAec+7NEQua7UPZB/gaJ0Jhh2pU6e70GQ3LUBQqY0PXEg16AkXd5ghcG5M9cNi 7O9g== X-Forwarded-Encrypted: i=1; AJvYcCXDjK7cesKBdFf0939wuNTjJ4qskZ2mZenF+wlN0GRWU5ULL1Y7/RMfwnyqJew7cstGvYXs2RqCve65VLU=@vger.kernel.org X-Gm-Message-State: AOJu0YwUMsFxNJWHcjzTxVTHmluAiDhQvB7QBw77X0TTilc6GjN58Y9K QP6fjZetxM+9lZy1u7FOM44F6TdVd9pl01QlRTF0w41XQlSC3BYUlonFvQp2Yw3nm19hwuJUMV+ H7M7DkLiIjDsXqxda3C3zgxGZ+EaNmoF1JmyQuPsmO9Z/8kOklMIsHelX9DF2iiTntKw= X-Gm-Gg: ATEYQzwSTVCu5bmkydozQLWKKOBCqwRunvfQ9KtaqX/5bc83vBdEFNAjZn7xfcgP37V OFpoUFQggRHMDHKnZZZoP2LvhilOjQ8c2AdI0Sy+eglhBlUgDX3e76FX4XK0DEmNgY/9bI47MwZ BnL0kFF19hBqyxOw7mX+2dB2CApGIWACmOcmOik5ct8T9edjfPc5fK12EQDBk/y1RtAc6j/buRW sbeoNgvzlvV9iBHxrTHRH1Ln80jQ/gDEFA4hzPxl8tJV9TKpSBqNlBHI7NY4HTl5DU6XZ0acNJ8 VFDLJ5bJDwplUnd0oWN7wO49NeiGy7fmx1bUAAhYARLWs4siDfnNN5uNapOdT/eWJgAiLZ+KPik 2t66SX1IIren8Mu+jOIplbt6opl+4bXoztmrkmBX3Se5liwudeB6sWpo= X-Received: by 2002:a17:903:3d0f:b0:2b0:7e4d:f390 with SMTP id d9443c01a7336-2b0cdcf14d2mr63227235ad.41.1774697872977; Sat, 28 Mar 2026 04:37:52 -0700 (PDT) X-Received: by 2002:a17:903:3d0f:b0:2b0:7e4d:f390 with SMTP id d9443c01a7336-2b0cdcf14d2mr63226925ad.41.1774697872472; Sat, 28 Mar 2026 04:37:52 -0700 (PDT) Received: from [192.168.0.172] ([49.205.250.68]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2427b3bfdsm26195065ad.75.2026.03.28.04.37.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Mar 2026 04:37:51 -0700 (PDT) Message-ID: Date: Sat, 28 Mar 2026 17:07:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/7] media: iris: add platform data for kaanapali To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Saravana Kannan , Joerg Roedel , Will Deacon , Robin Murphy , Stefan Schmidt , Hans Verkuil , Vishnu Reddy , Hans Verkuil , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Bryan O'Donoghue References: <20260313-kaanapali-iris-v3-0-9c0d1a67af4b@oss.qualcomm.com> <20260313-kaanapali-iris-v3-7-9c0d1a67af4b@oss.qualcomm.com> <5t3bke2sjkxahn4pjhdpyznbrdmu67u7cfgdfwqgjcgo7cbg2e@4wr2jadk6b7i> Content-Language: en-US From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 2MD6TQSv-z2gM9wZ-Bl_J-52IUneVLkQ X-Proofpoint-GUID: 2MD6TQSv-z2gM9wZ-Bl_J-52IUneVLkQ X-Authority-Analysis: v=2.4 cv=evLSD4pX c=1 sm=1 tr=0 ts=69c7bd91 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=yLWmkx75ThOYqhw51wEqsw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=WznVFTgscVg43mOb2l8A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI4MDA4NCBTYWx0ZWRfX5ECnME9NQWOQ 93TOugU9QkVuJjeRItmUzpCuoU5kl9tAS6j5WzK31bX+Yr/GvRoQlEMSokpCxPJ61+h9oDcGqYH 4uR7zVHTUjAfhdQAW8bTfTBDsSE42liUZXhCdl8+MSv9gppvMXunXlqaGIEQDSfOit4/TJ9hLmq 08Hq1P6jW49Us/DmS5+truWxRj+WlBpiZzbi34YcsKNhvDcBoIZ9A9el9JicJiDAOhsKkzRG49Q d0JJPS1hGYMVVv1vkJzzpl22SJBXoreB4SQ3WOJmipG2z0oYcUwVrqRRbdRs6wXlHt/mlrqIQts E0oEl7devod6niocu7BhtwUyeOByZGyfzTIM9Da/8u/uY6U12yP1+ypuRSBjVqMRaptoqVoquvt rBwMdN4b6pZs+Nw2QnaxV13eRpz+mGqgYKrJyM0UZkUTxcBDpuCybM8gU5FaIdBorCTdVnEXy3h HlQaWv3VIoAMHTbxc8A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-27_02,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603280084 On 3/13/2026 9:25 PM, Krzysztof Kozlowski wrote: > On 13/03/2026 16:46, Dmitry Baryshkov wrote: >> On Fri, Mar 13, 2026 at 06:49:41PM +0530, Vikash Garodia wrote: >>> Add support for the kaanapali platform by re-using the SM8550 >>> definitions and using the vpu4 ops. >>> Move the configurations that differs in a per-SoC platform header, that >>> will contain SoC specific data. >>> >>> Co-developed-by: Vishnu Reddy >>> Signed-off-by: Vishnu Reddy >>> Signed-off-by: Vikash Garodia >>> --- >>> .../platform/qcom/iris/iris_platform_common.h | 1 + >>> .../media/platform/qcom/iris/iris_platform_gen2.c | 90 ++++++++++++++++++++++ >>> .../platform/qcom/iris/iris_platform_kaanapali.h | 83 ++++++++++++++++++++ >>> drivers/media/platform/qcom/iris/iris_probe.c | 4 + >>> 4 files changed, 178 insertions(+) >>> >> >>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_kaanapali.h b/drivers/media/platform/qcom/iris/iris_platform_kaanapali.h >>> new file mode 100644 >>> index 0000000000000000000000000000000000000000..bdca1e5bf673353862c1554fb0420f73b3f519cb >>> --- /dev/null >>> +++ b/drivers/media/platform/qcom/iris/iris_platform_kaanapali.h >>> @@ -0,0 +1,83 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> +/* >>> + * Copyright (c) Qualcomm Innovation Center, Inc. All rights reserved. >>> + */ >>> + >>> +#ifndef __IRIS_PLATFORM_KAANAPALI_H__ >>> +#define __IRIS_PLATFORM_KAANAPALI_H__ >>> + >>> +#include >> >> So, you are including the bindings here, from the header, which gets >> included from the C source file including headers for all the platforms. >> What if Kaanapali+1 (or +3) defines different sets of regions? > > Different problem - header file MUST NOT have data definitions. > > That's basic of C, we don't write such code. First because it leads to > multiplied, redundant data. Second, that's not C coding style. Ack, will define in c and extern in header approach > > This pattern in Qualcomm Iris is terrible and I could accept variations > of existing data like below: > >> >>> + >>> +#define VIDEO_REGION_VM0_SECURE_NP_ID 1 >>> +#define VIDEO_REGION_VM0_NONSECURE_NP_ID 5 >>> + >>> +static const char *const kaanapali_clk_reset_table[] = { >>> + "bus0", >>> + "bus1", >>> + "core", >>> + "vcodec0_core", >>> +}; >>> + >>> +static const char *const kaanapali_pmdomain_table[] = { >>> + "venus", >>> + "vcodec0", >>> + "vpp0", >>> + "vpp1", >>> + "apv", >>> +}; >>> + >>> +static const struct platform_clk_data kaanapali_clk_table[] = { >>> + { IRIS_AXI_CLK, "iface" }, >>> + { IRIS_CTRL_CLK, "core" }, >>> + { IRIS_HW_CLK, "vcodec0_core" }, >>> + { IRIS_AXI1_CLK, "iface1" }, >>> + { IRIS_CTRL_FREERUN_CLK, "core_freerun" }, >>> + { IRIS_HW_FREERUN_CLK, "vcodec0_core_freerun" }, >>> + { IRIS_BSE_HW_CLK, "vcodec_bse" }, >>> + { IRIS_VPP0_HW_CLK, "vcodec_vpp0" }, >>> + { IRIS_VPP1_HW_CLK, "vcodec_vpp1" }, >>> + { IRIS_APV_HW_CLK, "vcodec_apv" }, >>> +}; >>> + >>> +static const char *const kaanapali_opp_clk_table[] = { >>> + "vcodec0_core", >>> + "vcodec_apv", >>> + "vcodec_bse", >>> + "core", >>> + NULL, >>> +}; >>> + >>> +static struct tz_cp_config tz_cp_config_kaanapali[] = { > > But this is new thus NAK. > > Don't grow this broken pattern. There is no single reason data > definition should be placed in a header. No single one. > > Best regards, > Krzysztof