From: "Cyrill Gorcunov" <gorcunov@gmail.com>
To: "Andi Kleen" <ak@suse.de>
Cc: "David Miller" <davem@davemloft.net>,
tglx@linutronix.de, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [IA32-EMU] Remove trailing spaces
Date: Tue, 13 Nov 2007 07:28:23 +0300 [thread overview]
Message-ID: <aa79d98a0711122028o506c9642j6ebee8252a97e543@mail.gmail.com> (raw)
In-Reply-To: <200711130008.34311.ak@suse.de>
The patch is just an addition to second one. So if you dont like it -
just drop it, if it do conflict with other patches - just drop it.
That simple :) what is the benefit of removing spaces? "try to keep
your code clean" i've read somwhere...
On 11/13/07, Andi Kleen <ak@suse.de> wrote:
> On Monday 12 November 2007 23:59:21 David Miller wrote:
> > From: Andi Kleen <ak@suse.de>
> > Date: Mon, 12 Nov 2007 23:55:54 +0100
> >
> > > Sure, it's likely not your time that will be wasted.
> >
> > I have to respin in excess of 800 networking patches at a time due to
> > these kinds of things. It's absolutely trivial, whether by hand
> > or using tool options that help you with this kind of task.
>
> Sure, but what benefit did it have?
>
> Could you have done something more useful in the time you needed to
> write the scripts for that?
>
> Also it's not only my time -- there are a lot of people who have x86
> patches. e.g. if 20 people have patches and they need half an hour
> each to write and test and apply scripts for that we're talking about more
> than a man-day overall wasted.
>
> > Suck it up Andi.
>
> Well it just seems a dumb thing to do and I like to complain about dumb
> things.
> Sorry that you are more generous about wasting other people's time.
>
> The end white space tends to disappear over time anyways because
> it is filtered out on everything new, but bulk changing it on old
> unchanged code is not a good idea.
>
> -Andi (who will shut up because he's approaching the half hour limit
> for such silly topics. At least it was only me and you though, not 20
> people)
>
prev parent reply other threads:[~2007-11-13 4:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 18:17 Cyrill Gorcunov
2007-11-12 21:01 ` Andi Kleen
2007-11-12 21:55 ` Andrew Morton
2007-11-12 22:50 ` David Miller
2007-11-12 22:55 ` Andi Kleen
2007-11-12 22:59 ` David Miller
2007-11-12 23:08 ` Andi Kleen
2007-11-13 4:28 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa79d98a0711122028o506c9642j6ebee8252a97e543@mail.gmail.com \
--to=gorcunov@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®