From: "Cyrill Gorcunov" <gorcunov@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant
Date: Thu, 13 Mar 2008 00:21:37 +0300 [thread overview]
Message-ID: <aa79d98a0803121421gda8354akaa36cee2f225a2b4@mail.gmail.com> (raw)
In-Reply-To: <47D846CE.1020005@zytor.com>
Yep, it wold be more elegant, i'll fix it tomorrow. (sorry for
top-posting, i'm not on my local laptop now)
On 3/13/08, H. Peter Anvin <hpa@zytor.com> wrote:
> Cyrill Gorcunov wrote:
> > This patch replaces numeric constant with an appropriate macro
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> >
> > ---
> >
> > Index: linux-2.6.git/include/asm-x86/processor.h
> > ===================================================================
> > --- linux-2.6.git.orig/include/asm-x86/processor.h 2008-02-20
> 19:14:57.000000000 +0300
> > +++ linux-2.6.git/include/asm-x86/processor.h 2008-03-12
> 23:10:02.000000000 +0300
> > @@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
> > /*
> > * User space process size. 47bits minus one guard page.
> > */
> > -#define TASK_SIZE64 (0x800000000000UL - 4096)
> > +#define TASK_SIZE64 (0x800000000000UL - PAGE_SIZE)
> >
> > /* This decides where the kernel will search for a free chunk of vm
> > * space during mmap's.
>
> Although I'd personally prefer ((1UL << 47) - PAGE_SIZE)
>
> -hpa
>
prev parent reply other threads:[~2008-03-12 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 20:14 Cyrill Gorcunov
2008-03-12 21:10 ` H. Peter Anvin
2008-03-12 21:21 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa79d98a0803121421gda8354akaa36cee2f225a2b4@mail.gmail.com \
--to=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®