From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757986AbYELGRN (ORCPT ); Mon, 12 May 2008 02:17:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753002AbYELGQ5 (ORCPT ); Mon, 12 May 2008 02:16:57 -0400 Received: from wa-out-1112.google.com ([209.85.146.181]:25901 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbYELGQ4 (ORCPT ); Mon, 12 May 2008 02:16:56 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=VJmKRizXr5YFoFE/WUW2upKRhNxdZSZZmXvFTDeaqYW76+Zmv1CKNjVTLJjNvMlC+KzsU0zp0YVQNeRQEWiKHTAd7UqPR5C6YADK0uFZBevJb0iD5TYccGcCWcqs9Ghk8acTLrboU2LzYLRPrdDSXX4ZnZRJ/lR+wxTBQ2FmdVk= Message-ID: Date: Mon, 12 May 2008 10:16:54 +0400 From: "Cyrill Gorcunov" To: "Rafael J. Wysocki" Subject: Re: 2.6.26-rc1 on x86: ld: warning: dot moved backwards before `.text' Cc: "H. Peter Anvin" , "Sam Ravnborg" , "Mikael Pettersson" , "Pavel Machek" , tglx@linutronix.de, mingo@redhat.com, linux-kernel@vger.kernel.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <18470.787.498329.144701@harpo.it.uu.se> <48273A32.5020104@zytor.com> <20080511182905.GD6942@cvg> <200805112322.53473.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 12, 2008 at 8:15 AM, Cyrill Gorcunov wrote: > On Mon, May 12, 2008 at 1:22 AM, Rafael J. Wysocki wrote: >> On Sunday, 11 of May 2008, Cyrill Gorcunov wrote: >>> [H. Peter Anvin - Sun, May 11, 2008 at 11:25:54AM -0700] >>> > Cyrill Gorcunov wrote: >>> >> Hi Peter, >>> >> actually I only doubt about exactly position of this headers - I mean >>> >> meguess it better should be _before_ "_end" not after. Since the others >>> >> script uses (acpi/wakeup_rm.S): >>> >> wakeup_code_start: >>> >> .incbin "arch/x86/kernel/acpi/realmode/wakeup.bin" >>> >> wakeup_code_end: >>> >> and kernel uses these wakeup_code_* marks to save/restore memory I think >>> >> it should be like >>> >> . = HEADER_OFFSET; >>> >> .header : { >>> >> ... >>> >> } >>> >> . = ALIGN(16); >>> >> _end = .; >>> >> /DISCARD/ ... >>> > >>> > Yes, I believe that's correct. >>> > >>> > -hpa >>> > >>> >>> Thanks for review, Peter, I'll cook a patch and wait for >>> Pavel's opinion ;-) >> >> I've tested the appended one. If that's what you mean, we'll ask Ingo to take >> it. >> >> Thanks, >> Rafael >> >> >> --- >> arch/x86/kernel/acpi/realmode/wakeup.lds.S | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> Index: linux-2.6/arch/x86/kernel/acpi/realmode/wakeup.lds.S >> =================================================================== >> --- linux-2.6.orig/arch/x86/kernel/acpi/realmode/wakeup.lds.S >> +++ linux-2.6/arch/x86/kernel/acpi/realmode/wakeup.lds.S >> @@ -12,11 +12,6 @@ ENTRY(_start) >> >> SECTIONS >> { >> - . = HEADER_OFFSET; >> - .header : { >> - *(.header) >> - } >> - >> . = 0; >> .text : { >> *(.text*) >> @@ -50,6 +45,11 @@ SECTIONS >> __bss_end = .; >> } >> >> + . = HEADER_OFFSET; >> + .header : { >> + *(.header) >> + } >> + >> . = ALIGN(16); >> _end = .; >> >> > > Thanks Rafael, > > it's exactly what I meant - http://lkml.org/lkml/2008/5/11/120 ;) > Heh, now we have even two patches (exactly the same in contents). So, Ingo, could you pick up any patch, please? ;-) (i'm in office now without access to my linux machine, so I can't send the patch with my and Rafael's sign-offs)