From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Tim Abbott <tabbott@mit.edu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Anders Kaseorg <andersk@mit.edu>, Waseem Daher <wdaher@mit.edu>,
Denys Vlasenko <vda.linux@googlemail.com>,
Jeff Arnold <jbarnold@mit.edu>, Paul Mundt <lethal@linux-sh.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH 09/14] s390: Use macros for .data.page_aligned.
Date: Tue, 28 Apr 2009 11:39:07 +0400 [thread overview]
Message-ID: <aa79d98a0904280039l3eef7e76g3994018c2e9d42eb@mail.gmail.com> (raw)
In-Reply-To: <1240864388-26315-10-git-send-email-tabbott@mit.edu>
On 4/28/09, Tim Abbott <tabbott@mit.edu> wrote:
> .data.page_aligned should not need a separate output section, so as
> part of this cleanup I moved into the .data output section in the
> linker scripts in order to eliminate unnecessary references to the
> section name.
>
> Remove the reference to .data.idt, since nothing is put into the
> .data.idt section on the s390 architecture. It looks like Cyrill
> Gorcunov posted a patch to remove the .data.idt code on s390
> previously:
>
> <http://lkml.indiana.edu/hypermail/linux/kernel/0802.2/2536.html>
>
> CCing him and the people who acked that patch in case there's a reason
> it wasn't applied.
>
It was not applied case of being a bit buggy.
You've fixed it as well. Thanks and my ack if needed.
> Signed-off-by: Tim Abbott <tabbott@mit.edu>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
> arch/s390/kernel/vdso.c | 2 +-
> arch/s390/kernel/vdso32/vdso32_wrapper.S | 3 ++-
> arch/s390/kernel/vdso64/vdso64_wrapper.S | 3 ++-
> arch/s390/kernel/vmlinux.lds.S | 6 +-----
> 4 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/arch/s390/kernel/vdso.c b/arch/s390/kernel/vdso.c
> index 89b2e7f..eff6fba 100644
> --- a/arch/s390/kernel/vdso.c
> +++ b/arch/s390/kernel/vdso.c
> @@ -64,7 +64,7 @@ __setup("vdso=", vdso_setup);
> static union {
> struct vdso_data data;
> u8 page[PAGE_SIZE];
> -} vdso_data_store __attribute__((__section__(".data.page_aligned")));
> +} vdso_data_store __page_aligned_data
> struct vdso_data *vdso_data = &vdso_data_store.data;
>
> /*
> diff --git a/arch/s390/kernel/vdso32/vdso32_wrapper.S
> b/arch/s390/kernel/vdso32/vdso32_wrapper.S
> index 61639a8..ae42f8c 100644
> --- a/arch/s390/kernel/vdso32/vdso32_wrapper.S
> +++ b/arch/s390/kernel/vdso32/vdso32_wrapper.S
> @@ -1,7 +1,8 @@
> #include <linux/init.h>
> +#include <linux/linkage.h>
> #include <asm/page.h>
>
> - .section ".data.page_aligned"
> + __PAGE_ALIGNED_DATA
>
> .globl vdso32_start, vdso32_end
> .balign PAGE_SIZE
> diff --git a/arch/s390/kernel/vdso64/vdso64_wrapper.S
> b/arch/s390/kernel/vdso64/vdso64_wrapper.S
> index d8e2ac1..c245842 100644
> --- a/arch/s390/kernel/vdso64/vdso64_wrapper.S
> +++ b/arch/s390/kernel/vdso64/vdso64_wrapper.S
> @@ -1,7 +1,8 @@
> #include <linux/init.h>
> +#include <linux/linkage.h>
> #include <asm/page.h>
>
> - .section ".data.page_aligned"
> + __PAGE_ALIGNED_DATA
>
> .globl vdso64_start, vdso64_end
> .balign PAGE_SIZE
> diff --git a/arch/s390/kernel/vmlinux.lds.S b/arch/s390/kernel/vmlinux.lds.S
> index 89399b8..d552089 100644
> --- a/arch/s390/kernel/vmlinux.lds.S
> +++ b/arch/s390/kernel/vmlinux.lds.S
> @@ -59,6 +59,7 @@ SECTIONS
> } :data
>
> .data : { /* Data */
> + PAGE_ALIGNED_DATA
> DATA_DATA
> CONSTRUCTORS
> }
> @@ -71,11 +72,6 @@ SECTIONS
> . = ALIGN(PAGE_SIZE);
> __nosave_end = .;
>
> - . = ALIGN(PAGE_SIZE);
> - .data.page_aligned : {
> - *(.data.idt)
> - }
> -
> . = ALIGN(0x100);
> .data.cacheline_aligned : {
> *(.data.cacheline_aligned)
> --
> 1.6.2.1
>
>
next prev parent reply other threads:[~2009-04-28 7:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 20:32 [PATCH 00/14] clean up page aligned data and bss sections Tim Abbott
2009-04-27 20:32 ` [PATCH 01/14] Add new macros for page-aligned " Tim Abbott
2009-04-27 20:32 ` [PATCH 02/14] sh: Use macros for .bss.page_aligned section Tim Abbott
2009-04-27 20:32 ` [PATCH 03/14] mn10300: " Tim Abbott
2009-04-27 20:32 ` [PATCH 04/14] xtensa: " Tim Abbott
2009-04-27 20:32 ` [PATCH 05/14] x86: " Tim Abbott
2009-04-27 20:33 ` [PATCH 06/14] alpha: Use macros for .data.page_aligned Tim Abbott
2009-04-27 20:33 ` [PATCH 07/14] avr32: Use standard macros for .data.page_aligned section Tim Abbott
2009-04-27 20:33 ` [PATCH 08/14] sh: Use " Tim Abbott
2009-04-27 20:33 ` [PATCH 09/14] s390: Use macros for .data.page_aligned Tim Abbott
2009-04-27 20:33 ` [PATCH 10/14] powerpc: Remove unused __page_aligned macro Tim Abbott
2009-04-27 20:33 ` [PATCH 11/14] powerpc: Use macros for .data.page_aligned section Tim Abbott
2009-04-27 20:33 ` [PATCH 12/14] mn10300: Drop unused .data.idt section Tim Abbott
2009-04-27 20:33 ` [PATCH 13/14] x86: Use section .data.page_aligned for the idt_table Tim Abbott
2009-04-27 20:33 ` [PATCH 14/14] x86: Use macros for .data.page_aligned Tim Abbott
2009-04-28 4:41 ` [PATCH 12/14] mn10300: Drop unused .data.idt section Cyrill Gorcunov
2009-04-28 4:20 ` [PATCH 11/14] powerpc: Use macros for .data.page_aligned section Tim Abbott
2009-04-28 4:21 ` [PATCH 1/2] powerpc: share .data output section definition between 32 and 64 bits Tim Abbott
2009-04-28 4:21 ` [PATCH 2/2] powerpc: Use macros for .data.page_aligned section Tim Abbott
2009-04-28 15:07 ` [PATCH 11/14] " Stephen Rothwell
2009-04-28 15:13 ` Tim Abbott
2009-04-28 15:17 ` Stephen Rothwell
2009-04-28 7:39 ` Cyrill Gorcunov [this message]
2009-04-27 21:57 ` [PATCH 08/14] sh: " Paul Mundt
2009-04-28 14:49 ` [PATCH 07/14] avr32: Use standard " Haavard Skinnemoen
2009-04-27 21:57 ` [PATCH 02/14] sh: Use macros for .bss.page_aligned section Paul Mundt
2009-04-27 23:43 ` [PATCH 03/14] mn10300: " David Howells
2009-04-27 23:48 ` Tim Abbott
2009-04-28 12:45 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa79d98a0904280039l3eef7e76g3994018c2e9d42eb@mail.gmail.com \
--to=gorcunov@openvz.org \
--cc=andersk@mit.edu \
--cc=jbarnold@mit.edu \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=schwidefsky@de.ibm.com \
--cc=tabbott@mit.edu \
--cc=torvalds@linux-foundation.org \
--cc=vda.linux@googlemail.com \
--cc=wdaher@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®