From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Chris Malley <mail@chrismalley.co.uk>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: perf sched record hangs machine
Date: Wed, 23 Sep 2009 12:48:04 +0400 [thread overview]
Message-ID: <aa79d98a0909230148j47232382oe28c6d88eef181c4@mail.gmail.com> (raw)
In-Reply-To: <aa79d98a0909230044q3548cf0bjda62e05e0400edd6@mail.gmail.com>
On 9/23/09, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> On 9/23/09, Ingo Molnar <mingo@elte.hu> wrote:
>>
>> * Ingo Molnar <mingo@elte.hu> wrote:
>>
>>>
>>> * Peter Zijlstra <peterz@infradead.org> wrote:
>>>
>>> > .size default_send_IPI_self, .-default_send_IPI_self
>>> >
>>> > Which seems to suggest that cmove is in __prepare_ICR, but I'm not
>>> > sure how that can cause a page-fault, as that function is rather
>>> > pointer-less.
>>> >
>>> > Did it maybe delay evaluating apic->dest_logical that late, it appear
>>> > to be the first usage of that argument?
>>> >
>>> > Ingo, any ideas?
>>>
>>> Yeah, the problem is:
>>>
>>> [ 0.042445] Local APIC not detected. Using dummy APIC emulation.
>>>
>>> we shouldnt be trying to program the lapic in that case - all ops
>>> should be a NOP, including send-ipi-self. Cyrill?
>>
>> Cyrill, the right fix would be to define a:
>>
>> struct apic apic_none;
>>
>> with dummy functions injected. Set struct apic *apic to _that_, instead
>> of apic_default.
>>
>> This means that if we manage to detect a local APIC, we will set it to
>> apic_default (or some other driver) - but the bootup default will be 'no
>> APIC'.
>>
>
> May it wait till evening (i'll back from office and take a look)?
>
>> This is a lot cleaner and a lot less error-prone than the direct
>> frobbing of the function pointers.
>>
>> Ingo
>>
>
Btw, meanwhile Chris may try to pass lapic boot-option in attempt to
reenable apic via msr registers. Also (iirc) i feel we may be hiding
errors if complete noop apic would be used since i belive we need to
check out under which condition a particular operation is called and
when apic is disabled it's mean we're switched to UP mode and
inter-cpu interrupts are under suspicion too. Will take a look during
~6 hours ;)
next prev parent reply other threads:[~2009-09-23 8:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 21:09 Chris Malley
2009-09-22 21:24 ` Frederic Weisbecker
2009-09-22 21:44 ` Frederic Weisbecker
2009-09-23 6:16 ` Peter Zijlstra
2009-09-23 7:32 ` Ingo Molnar
2009-09-23 7:40 ` Ingo Molnar
2009-09-23 7:44 ` Cyrill Gorcunov
2009-09-23 8:48 ` Cyrill Gorcunov [this message]
2009-09-23 8:52 ` Peter Zijlstra
2009-09-23 9:15 ` Chris Malley
2009-09-23 9:20 ` Ingo Molnar
2009-09-23 9:48 ` Cyrill Gorcunov
2009-09-23 10:06 ` Chris Malley
2009-09-23 10:12 ` Cyrill Gorcunov
2009-09-23 10:42 ` Ingo Molnar
2009-09-23 11:41 ` Chris Malley
2009-09-23 11:42 ` Ingo Molnar
2009-09-23 12:20 ` Chris Malley
2009-09-23 12:27 ` Ingo Molnar
2009-09-23 10:41 ` Ingo Molnar
2009-09-23 9:03 ` Peter Zijlstra
2009-09-23 11:49 ` [tip:perf/urgent] perf_event, x86: Fix 'perf sched record' crashing the machine tip-bot for Peter Zijlstra
2009-09-23 12:15 ` Chris Malley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa79d98a0909230148j47232382oe28c6d88eef181c4@mail.gmail.com \
--to=gorcunov@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@chrismalley.co.uk \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®