Re: [patch 3/3] x86,apic: limit apic dumping, introduce show_lapic setup option

[Cyrill Gorcunov <gorcunov@openvz.org>]

On 10/14/09, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Cyrill Gorcunov <gorcunov@openvz.org> wrote:
>
>> In case if a system has a large number of cpus printing apics
>> contents may consume a long time period.
>>
>> We limit such an output by 1 apic by default. But to have an
>> ability to see all apics or some part of them we introduce
>> "show_lapic" setup option which allow us to limit/unlimit
>> the number of APICs being dumped.
>>
>> Example: apic=debug show_lapic=5, or apic=debug show_lapic=all
>>
>> Also move apic_verbosity checking upper that way so helper routines
>> do not need to inspect it at all.
>>
>> Suggested-by: Yinghai Lu <yinghai@kernel.org>
>> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
>> ---
>>  arch/x86/kernel/apic/io_apic.c |   47
>> +++++++++++++++++++++++++++--------------
>>  1 file changed, 32 insertions(+), 15 deletions(-)
>
>> +__setup("show_lapic=", setup_show_lapic);
>
> Note: new __setup() functions need an entry in
> Documentation/kernel-parameters.txt as well.
>
> 	Ingo
>
Will update today evening. Thanks!