From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 558CA3264CB for ; Wed, 1 Apr 2026 16:14:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775060051; cv=none; b=De8NGbwPSk0zUpX2gkcDV0bcsDxUP1rkw51p40KslwGRyW9o53ICMxBlNtdELmz6SVc2Abq4HI6AKu9xkaEjry744g+8ywSvEYnhnLpYRLA3WwnOiZw9tuPNH/UIHOL7DtX4dTKKeqHLWq8NYSa0CYWtz/k5t2jDcOjJjkB6I1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775060051; c=relaxed/simple; bh=5vsaEaZXu0b60Fw2daY4xBXRpr8mZ34kaMt1aHDy5Kc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ICq6YKyGkwNgY32gnKo2qKOSpV6/uI/ZQ7yePTPL1FKDZjrNaNFyHKjVy0KctpwZIQLmUOgtmqGwCmXmli8L4OFtc7y7A2Eyv1cTSZVXc7/CrE0OsmxANo6dVy23L7A+s4MBWDpldfyy7VCZy/9AIglq6+hV9GIelkd1VDd9dgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=allelesecurity.com; spf=pass smtp.mailfrom=allelesecurity.com; dkim=pass (1024-bit key) header.d=allelesecurity.com header.i=@allelesecurity.com header.b=Y7vIHXh/; arc=none smtp.client-ip=209.85.221.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=allelesecurity.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=allelesecurity.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=allelesecurity.com header.i=@allelesecurity.com header.b="Y7vIHXh/" Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-56d8365c1efso737709e0c.0 for ; Wed, 01 Apr 2026 09:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=allelesecurity.com; s=google; t=1775060049; x=1775664849; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e+Q1jXLiEJexeZZTXwdCnetPvxe3gmMyFGRYsaWGRvY=; b=Y7vIHXh/iyIIc/cnelQ7eBASDDUFHCz3hiO89qemg9+J6BDBYdK6bMrXheNmsb/Y/E JSzR2DgPwwTwkbR2S4IxCqZLuEozX3VRIHyGTkkS36NvwMCJSljKFyZu4r72zQipQUDK ZfLm/nH8NQKU8zbY0hCBjmCKZA0mOxHjngLI4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775060049; x=1775664849; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e+Q1jXLiEJexeZZTXwdCnetPvxe3gmMyFGRYsaWGRvY=; b=dQvAUxrdSRAxnn8VtZ/5FCcrGLjNvAGn2Rguwusdji3uWaJquEptYqzT2x+X/UD/gK uUeB9IW+W4q9vQ0fShKBLmXidKei+DIyhJSy2YUTZlvOfrfqfvvbI8/QU6hyATf9E6Hr jeztZzGI5MvszVdxXzqciZaO4MSeE8QqUiatvOh14UG+sHksxsrEFhZ7YqYDOnJ+8SBY YvVJOgKDfHXIz106L15jmgRPqSd9U6LLvHR+GyUFkZ2BV4sFnVA9in9292EIvCyfqx8k KC7AZUqgWqOsdCM9gMnrblxaZLoh4m42hkBjyAD+6GfuOS5qWqoP8iHYrjhAlyeJ3PaJ USOw== X-Forwarded-Encrypted: i=1; AJvYcCWmuF4TXx8M/BqCj28RL7n317Ti6Zg0WmEiKAc8EgVyJSN6YqOLCbU14kCQ+POPUGrRMnRC21pM++cYghI=@vger.kernel.org X-Gm-Message-State: AOJu0YyNyvmDriT9voCJOHkoIIVkBCvors9egWF/TBghJVgGEiNhgJNm op9mqJhSbmXoDzjD/G8f9H3Wxt+FJyrWFR2YRjg6m6aHVYYHoLtreMPmhOdPY5YQO+8= X-Gm-Gg: ATEYQzyq0qo3TtefN29bLy4dDSzlCwzExddfnP9NkToxEOpZ3gOSzEmkPgY3eQKogSO nNm7xHde5hqnnQcKvhTy8hSu75jOsjmM3+5OF8OB9r7xiE7PRjptk3/ly4pxH/XOxwZwr8Q/Qf2 37Q/ao6MdZpuj5IHN6Coh3b3cep4CxaIxnUy7r0JdDUjqyYuoEPm+oKtA6ZpTsAv3xGuayeIetb t5a1EUiupL1PoOxPS6qCw0yC2iA9+Eyscl5F3BbNT+rhG/0SPk5iT+kXwVk5K/di+Zdz40K5tZ4 KQlJAPR0goCp2MdBJSTiz7uP189IA2Fu3gItBIVcNX0vvR+dXqCqmgJTakD7gfe35ntI9y1K+Os EryD46uLGGvWzyVX/A5kMkZ2h9vx4E2H72NUajcPMXbNhSVJpAYdu6Rt4gnaWskrPHEqadFH0HY C6PicBHZ6CJ758OUe+zwvSkZ8ia3XV++ybhHDo X-Received: by 2002:a05:6122:553:b0:56b:8ba0:fd58 with SMTP id 71dfb90a1353d-56d8b04d750mr1470500e0c.6.1775060049263; Wed, 01 Apr 2026 09:14:09 -0700 (PDT) Received: from [192.168.1.2] ([179.105.152.82]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56d58a46f4dsm17612731e0c.15.2026.04.01.09.14.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 09:14:09 -0700 (PDT) Message-ID: Date: Wed, 1 Apr 2026 13:14:00 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v4 15/15] rxrpc: fix reference count leak in rxrpc_server_keyring() To: David Howells , netdev@vger.kernel.org Cc: Marc Dionne , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, Luxiao Xu , Yifan Wu , Juefei Pu , Yuan Tan , Xin Liu , Ren Wei , Ren Wei , Simon Horman , stable@kernel.org, anderson@allelesecurity.com References: <20260401105614.1696001-1-dhowells@redhat.com> <20260401105614.1696001-16-dhowells@redhat.com> Content-Language: en-US From: Anderson Nascimento In-Reply-To: <20260401105614.1696001-16-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/1/26 7:56 AM, David Howells wrote: > From: Luxiao Xu > > This patch fixes a reference count leak in rxrpc_server_keyring() > by checking if rx->securities is already set. > > Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both") > Reported-by: Yifan Wu > Reported-by: Juefei Pu > Co-developed-by: Yuan Tan > Signed-off-by: Yuan Tan > Suggested-by: Xin Liu > Tested-by: Ren Wei > Signed-off-by: Luxiao Xu > Signed-off-by: Ren Wei > Signed-off-by: David Howells > cc: Marc Dionne > cc: Eric Dumazet > cc: "David S. Miller" > cc: Jakub Kicinski > cc: Paolo Abeni > cc: Simon Horman > cc: linux-afs@lists.infradead.org > cc: netdev@vger.kernel.org > cc: stable@kernel.org > --- > net/rxrpc/server_key.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/rxrpc/server_key.c b/net/rxrpc/server_key.c > index 36b05fd842a7..d4777851079f 100644 > --- a/net/rxrpc/server_key.c > +++ b/net/rxrpc/server_key.c > @@ -125,6 +125,9 @@ int rxrpc_server_keyring(struct rxrpc_sock *rx, sockptr_t optval, int optlen) > > _enter(""); > > + if (rx->securities) > + return -EEXIST; > + > if (optlen <= 0 || optlen > PAGE_SIZE - 1) > return -EINVAL; > > Isn't this the same issue addressed by my patch "[PATCH net v4 08/15] rxrpc: Fix keyring reference count leak in rxrpc_setsockopt()"? Just asking to make sure this is intended. -- Anderson Nascimento Allele Security Intelligence https://www.allelesecurity.com