mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Dave Hansen <dave.hansen@intel.com>,
	Jiaxi Chen <jiaxi.chen@linux.intel.com>,
	kvm@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	seanjc@google.com, ndesaulniers@google.com,
	alexandre.belloni@bootlin.com, peterz@infradead.org,
	jpoimboe@kernel.org, chang.seok.bae@intel.com,
	pawan.kumar.gupta@linux.intel.com, babu.moger@amd.com,
	jmattson@google.com, sandipan.das@amd.com, tony.luck@intel.com,
	sathyanarayanan.kuppuswamy@linux.intel.com, fenghua.yu@intel.com,
	keescook@chromium.org, jane.malalane@citrix.com,
	nathan@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] x86: KVM: Enable AMX-FP16 CPUID and expose it to guest
Date: Wed, 2 Nov 2022 19:16:37 +0100	[thread overview]
Message-ID: <aa7f6efc-de4c-c5f6-fb5f-ef514e4513a3@redhat.com> (raw)
In-Reply-To: <639c22a1-b0b0-9fb0-2a9a-060c53f9f540@intel.com>

On 11/2/22 19:14, Dave Hansen wrote:
>>   
>>   	kvm_cpu_cap_mask(CPUID_7_1_EAX,
>> -		F(AVX_VNNI) | F(AVX512_BF16) | F(CMPCCXADD)
>> +		F(AVX_VNNI) | F(AVX512_BF16) | F(CMPCCXADD) | F(AMX_FP16)
>>   	);
>>   
>>   	kvm_cpu_cap_mask(CPUID_D_1_EAX,
>
> KVM folks, is the idea that every feature that is enumerated to a guest
> needs to be in one of these masks?  Or is there something special about
> the features in these masks?

Yes, all features are vetted manually to see whether they require new 
MSRs and the like.  Therefore, anything that userspace can set in the 
guest's CPUID must be in the list.

Paolo


  reply	other threads:[~2022-11-02 18:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-19  8:47 [PATCH 0/6] x86: KVM: Expose CPUID to guest for new Intel platform instructions Jiaxi Chen
2022-10-19  8:47 ` [PATCH 1/6] x86: KVM: Enable CMPccXADD CPUID and expose it to guest Jiaxi Chen
2022-10-19 15:15   ` Sean Christopherson
2022-10-20  7:27     ` Chen, Jiaxi
2022-10-26  3:40     ` Jiaxi Chen
2022-10-26 17:15       ` Borislav Petkov
2022-10-27  2:27         ` Jiaxi Chen
2022-11-01  9:07         ` Jiaxi Chen
2022-11-01 15:07           ` Sean Christopherson
2022-11-03  2:35             ` Jiaxi Chen
2022-10-19  8:47 ` [PATCH 2/6] x86: KVM: Enable AMX-FP16 " Jiaxi Chen
2022-11-02 18:14   ` Dave Hansen
2022-11-02 18:16     ` Paolo Bonzini [this message]
2022-11-02 18:21       ` Dave Hansen
2022-11-03  2:38         ` Jiaxi Chen
2022-10-19  8:47 ` [PATCH 3/6] x86: KVM: Enable AVX-IFMA " Jiaxi Chen
2022-10-19  8:47 ` [PATCH 4/6] x86: KVM: Enable AVX-VNNI-INT8 " Jiaxi Chen
2022-10-19  8:52   ` Borislav Petkov
2022-10-19 14:57     ` Sean Christopherson
2022-10-19 15:09       ` Sean Christopherson
2022-10-26  3:33         ` Jiaxi Chen
2022-10-20  7:13     ` Chen, Jiaxi
2022-10-19  8:47 ` [PATCH 5/6] x86: KVM: Enable AVX-NE-CONVERT " Jiaxi Chen
2022-10-19  8:47 ` [PATCH 6/6] x86: KVM: Enable PREFETCHIT0/1 " Jiaxi Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa7f6efc-de4c-c5f6-fb5f-ef514e4513a3@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=jane.malalane@citrix.com \
    --cc=jiaxi.chen@linux.intel.com \
    --cc=jmattson@google.com \
    --cc=jpoimboe@kernel.org \
    --cc=keescook@chromium.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=sandipan.das@amd.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®