From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BCBD33121C
	for <linux-kernel@vger.kernel.org>; Mon,  9 Mar 2026 15:01:32 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1773068492; cv=none; b=mVzkNMF6quQPLtQ0JPV5lnEqASzZvgZoR0oHZucgHH93e0ZICh+3nffj2vDFvtxFB444yscWIVAV96VIbZeraB0INb0Di99OGQFXRMVL4Pu2x8DkFPpzRpHenXWT/QheRmC9SjLA7Q/8KZxHmDEMBhah08KFVL7AUbenUZTVHDI=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1773068492; c=relaxed/simple;
	bh=t4S+tTuMuRCDJ6WlQ+SAQoEeWLR4+1z2yf1E+YGFdd4=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=m/C8JdyU7rhqIak6YqNNg8X0FbN/geEv4Bo+w5yeQDLm3B3rzcDPpuQ1cZcD7ZL428cosIFwCRsb5A57nX1bpTdkngoMWHfvycAZnc+K3v1rqX7cGQxGl9MdqzbUrwAvPRiE3jOKAlDoQydqgcK97aO+OHnHGqbM0SZQBltIrSM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oKELC1qy; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oKELC1qy"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B77CEC2BC86;
	Mon,  9 Mar 2026 15:01:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1773068492;
	bh=t4S+tTuMuRCDJ6WlQ+SAQoEeWLR4+1z2yf1E+YGFdd4=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=oKELC1qyrDmi29hJ+XsbOKmcSRfD4ON6wU+4Hs2wjgg2+0YXdeWAk4CoynXt1PM5u
	 G7Lh8rXF4Y8j2t7ChXpQsIsyphzTk0XveY6GsK5D2+gKv7SesF9+n0I/dJD5FUePEl
	 s945hEHPmpv3mtSxrOclWoJXhWaMy5OxshtlkgZjKRzi4bQi5es+S8qGm+QJDlYnvu
	 Py2PpD5KFfzFHjaX6GllUXRzyeNYLh/7quFvXJtI+6MNTQjVH4yoJuvQdRB2yxhCCq
	 2N4HAQGkJXSfd2kbAFvdE1Yi7J1snecKOsaEPIY7xsxM62JqD7wNMgZFqyHHlj2cpG
	 uwk+yFnxb+raA==
Date: Mon, 9 Mar 2026 09:01:29 -0600
From: Keith Busch <kbusch@kernel.org>
To: alistair23@gmail.com
Cc: hare@suse.de, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Alistair Francis <alistair.francis@wdc.com>,
	Kamaljit Singh <kamaljit.singh@opensource.wdc.com>
Subject: Re: [PATCH v2] nvme-auth: Don't propose NVME_AUTH_DHGROUP_NULL with
 SC_C
Message-ID: <aa7gyZ6arZq8Ud72@kbusch-mbp>
References: <20260309042733.1137108-1-alistair.francis@wdc.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260309042733.1137108-1-alistair.francis@wdc.com>

On Mon, Mar 09, 2026 at 02:27:33PM +1000, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
> 
> Section 8.3.4.5.2 of the NVMe 2.1 base spec states that
> 
> """
> The 00h identifier shall not be proposed in an AUTH_Negotiate message
> that requests secure channel concatenation (i.e., with the SC_C field
> set to a non-zero value).
> """
> 
> We need to ensure that we don't set the NVME_AUTH_DHGROUP_NULL idlist if
> SC_C is set.

Thanks, applied.