From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA3BC433FE for ; Wed, 4 May 2022 18:41:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376995AbiEDSow (ORCPT ); Wed, 4 May 2022 14:44:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237001AbiEDSot (ORCPT ); Wed, 4 May 2022 14:44:49 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63788645E for ; Wed, 4 May 2022 11:41:12 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id w1so3852596lfa.4 for ; Wed, 04 May 2022 11:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=wTxln7YGVkX89i8PG0IKXfsso9aaC9QMWGmO6EX/EGY=; b=z2Ctxr3w9cDEGS/IXiaRNEtZDn6Wv0POATksyAG9keUZE2UBpjRpqxqEhe03gIVezk JUHIQzyf/0MFa26gN3hi0g8FHd/HHXCynEgpy2M5H7LEO8cPdG9LbSNWy4iMxvJh/joQ KVsH9tDJmcqntkqGTL3cxSgFiPZgi+CX0jvzztvuwLE5KOCWpXjvHU8Nm3OXF7d/+Kop MaDt4RjNKWP6xsVrGhiEed3Zu7Y1eH3v+cMbJ04VzT7yPGJHlsXkTiyp1XYyofqvPaQi QbrsqXxwYv8AvPL0L/DqQxBoG7tz9RBWjz0w9SJu5p2yT+8+8vehbDyH1X46CuUQ+MW9 mCgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wTxln7YGVkX89i8PG0IKXfsso9aaC9QMWGmO6EX/EGY=; b=vwUYzepoXX1qkaxy9Bu0xz9hUfcitYXYXQ5FXgqcysf2MUsvqxiiTj+gPnGXWExvjp mMhTyaHN/vM1rbHbLYWlUigwv3ir25DvCDFheXg7fkUALW4RSA9CPWmb4qxak6yMiatr FfWA1Z/EQrJwhN5IVdEH/woq6p3mGoxvuuZOLLjy57dsRX2I9OPPRDlAAVx+LUP7xt0B gI6qhGT24W4c7weBWt/mfnH8gm7IyoSkdHXAMRVdVr1Kbo79EFsVVqI6LCBYW2fTH+Ry rTQ+VMNtdxQ3qJa0jH8T5i256nFECbx0QVqQsLt74QZqs10Xafx7mqrVdQnhViIosPsG lgzQ== X-Gm-Message-State: AOAM533XQFG5xiTDWIZXjuc0WzdjsqHgit2VZzRFahtP7l3EUCckgCuo 5MdsArDKRdzf95PgB2kBvFTHng== X-Google-Smtp-Source: ABdhPJy4zg1hpUl4Auyu5EEfhi6Mx+a0yiiys0cRdUGvJh5KnPLpnHF/RaEZ9+x6pGoF15y0uGxIGA== X-Received: by 2002:a05:6512:683:b0:473:a110:e52 with SMTP id t3-20020a056512068300b00473a1100e52mr8290893lfe.412.1651689670755; Wed, 04 May 2022 11:41:10 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id s15-20020ac25fef000000b0047255d2115esm1274090lfg.141.2022.05.04.11.41.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 May 2022 11:41:10 -0700 (PDT) Message-ID: Date: Wed, 4 May 2022 21:41:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] drm/msm: Limit command submission when no IOMMU Content-Language: en-GB To: Rob Clark , dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Luca Weiss , Rob Clark , Sean Paul , Abhinav Kumar , David Airlie , Daniel Vetter , open list References: <20220502172908.3569799-1-robdclark@gmail.com> From: Dmitry Baryshkov In-Reply-To: <20220502172908.3569799-1-robdclark@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/05/2022 20:29, Rob Clark wrote: > From: Rob Clark > > Running the GPU without an IOMMU is not really a supported (or sane) > configuration. Yet it can be useful during SoC bringup (ie. if the > iommu driver doesn't work yet). > > Lets limit it to users who already have /dev/mem access, to avoid the > chance that a user accidentially configures kernel without IOMMU > support. > > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_gem_submit.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > index 23b68bc945f6..9cd8c8708990 100644 > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > @@ -734,6 +734,11 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, > if (args->pad) > return -EINVAL; > > + if (unlikely(!ctx->aspace) && !capable(CAP_SYS_RAWIO)) { > + DRM_ERROR_RATELIMITED("IOMMU support or CAP_SYS_RAWIO required!\n"); > + return -EPERM; > + } > + > /* for now, we just have 3d pipe.. eventually this would need to > * be more clever to dispatch to appropriate gpu module: > */ -- With best wishes Dmitry